phone2action / ym-api

src/YourMembershipServiceProvider.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
 	 * Package Config Path
 	 * @var string
 	 */
-	private $packageConfigPath = __DIR__.'/config/yourmembership.php';
+	private $packageConfigPath = __DIR__ . '/config/yourmembership.php';
 	/**
 	 * Indicates if loading of the provider is deferred.
 	 *
@@ -34,7 +34,7 @@ 
 			$this->packageConfigPath, $this->packageName
 		);
 
-		$this->app->bind(YourMembershipClient::class, function ($app, $parameters) {
+		$this->app->bind(YourMembershipClient::class, function($app, $parameters) {
 			$guzzleClient = new \GuzzleHttp\Client($app['config']['yourmembership']['guzzle-client']);
 			return new YourMembershipClient($guzzleClient, $parameters[0], $parameters[1]);
 		});

src/Core/Request.php

Indentation +164 added lines, -164 removed lines

@@ -60,169 +60,169 @@
             <SaPasscode>************</SaPasscode>
             </YourMembership>
         */
-        $xml = new \SimpleXMLElement('<YourMembership></YourMembership>');
-        $xml->addChild('Version', self::API_VERSION);
-        $xml->addChild('ApiKey', $this->apiKey);
-        $xml->addChild('CallID', self::$callId);
-        $xml->addChild('SaPasscode', $this->saPasscode);
-
-        return $xml;
-    }
-
-    /**
-     * Generates the XML for a API method call within
-     * @method createCallPayload
-     * @author PA
-     * @throws YourMembershipRequestException
-     * @date   2017-01-09
-     * @param  string            $method    YourMembership API Function Name
-     * @param  array             $arguments Array of Arguments to be passed as part of the YourMembership "Call"
-     * @return \SimpleXMLElement
-     */
-    public function createCallPayload(string $method, array $arguments) : \SimpleXMLElement
-    {
-        //Create Call Node
-        $call = new \SimpleXMLElement('<Call> </Call>');
-        $call->addAttribute('Method', $method);
-
-        //Add Arguments to the Call Node
-        try {
-            $call = $this->sxmlAddChildrenRecursive($call, $arguments);
-        } catch (\Exception $e) {
-            throw new YourMembershipRequestException($e->getMessage(), $e->getCode(), $e);
-        }
-        return $call;
-    }
-    /**
-     * Recursively builds the array into a XML Tree
-     * //NOTE Child arrays must be associative
-     * @method sxmlAddChildrenRecursive
-     * @author PA
-     * @throws \Exception XML Parsing Exception
-     * @date   2017-01-12
-     * @param  \SimpleXMLElement         $root      Root XML Node
-     * @param  array                    $arguments Array of Arguments to be added to XML Node
-     * @return \SimpleXMLElement                    Resulting XML Tree
-     */
-    private function sxmlAddChildrenRecursive(\SimpleXMLElement $root, array $arguments) : \SimpleXMLElement
-    {
-        foreach ($arguments as $key => $value) {
-            if (is_array($value)) {
-                $child = new \SimpleXMLElement(sprintf('<%s></%s>', $key, $key));
-                $this->sxmlAddChildrenRecursive($child, $value);
-                $this->sxmlAppend($root, $child);
-            } else {
-                $root->addChild($key, $value);
-            }
-
-        }
-        return $root;
-    }
-    /**
-     * Builds The XML Request Body for the Your Membership API Call
-     * @method buildXMLBody
-     * @author PA
-     * @date   2017-01-10
-     * @param  string            $method    Your Membership API Function Name
-     * @param  array             $arguments Your Membership Arguments
-     * @return \SimpleXMLElement
-     */
-    public function buildXMLBody(string $method, array $arguments) : \SimpleXMLElement
-    {
-        $xml = $this->buildBasePayload(); // Common Envelope
-
-        if ($this->isSessionRequiredForMethod($method)) {
-            $xml = $this->addSessionIdToRequest($xml);
-        }
-
-        $callPayload = $this->createCallPayload($method, $arguments); // Specific API Call Envelope
-
-        // Put Api call into common envelope
-        $this->sxmlAppend($xml, $callPayload);
-
-        return $xml;
-    }
-    /**
-     * Builds a Guzzle Request Object
-     * @method buildRequest
-     * @author PA
-     * @date   2017-01-11
-     * @param  string        $method    YourMembership API Method
-     * @param  array         $arguments YourMembership API Method Call Arguments
-     * @return \GuzzleHttp\Psr7\Request            Guzzle Request Object
-     */
-    public function buildRequest(string $method, array $arguments) : \GuzzleHttp\Psr7\Request
-    {
-        $requestBody = $this->buildXMLBody($method, $arguments)->asXML();
-        return new GuzzleRequest('POST', self::BASE_URL, ['Content-Type' => 'application/x-www-form-urlencoded; charset=UTF8'], $requestBody);
-    }
-
-    /**
-     * Checks if Request Requires Session ID
-     * @method isSessionRequiredForMethod
-     * @author PA
-     * @date   2017-01-10
-     * @param  string                     $method YourMembership API Method
-     * @return bool
-     */
-    public function isSessionRequiredForMethod(string $method) : bool
-    {
-        //TODO Add config Logic for what API Methods require Session ID
-        return ($method != 'Session.Create');
-    }
-
-    /**
-     * Helper for Deep Copy for of $from element into $to element for SimpleXML
-     * @method sxmlAppend
-     * @author PA
-     * @date   2017-01-09
-     * @param  \SimpleXMLElement $to
-     * @param  \SimpleXMLElement $from
-     * @return void
-     */
-    private function sxmlAppend(\SimpleXMLElement $to, \SimpleXMLElement $from)
-    {
-        $toDom = dom_import_simplexml($to);
-        $fromDom = dom_import_simplexml($from);
-        $toDom->appendChild($toDom->ownerDocument->importNode($fromDom, true));
-    }
-
-    /**
-     * Adds the Session Variable to the given XML Request Payload
-     * @method addSessionIdToRequest
-     * @author PA
-     * @date   2017-01-10
-     * @param  \SimpleXMLElement                $requestXML Base Request XML Payload
-     */
-    private function addSessionIdToRequest(\SimpleXMLElement $requestXML) : \SimpleXMLElement
-    {
-        $requestXML->addChild('SessionID', self::$sessionId);
-        return $requestXML;
-    }
-
-
-    /**
-     * Setter Method for SessionID
-     * @method setSessionId
-     * @author PA
-     * @date   2017-01-10
-     * @param  string       $sessionId YourMembership Session ID
-     */
-    public static function setSessionId(string $sessionId)
-    {
-        self::$sessionId = $sessionId;
-    }
-
-    /**
-     * Checks if we have an active session available
-     * @method hasSession
-     * @author PA
-     * @date   2017-01-11
-     * @return boolean
-     */
-    public function hasSession()
-    {
-        return !is_null(self::$sessionId);
-    }
+		$xml = new \SimpleXMLElement('<YourMembership></YourMembership>');
+		$xml->addChild('Version', self::API_VERSION);
+		$xml->addChild('ApiKey', $this->apiKey);
+		$xml->addChild('CallID', self::$callId);
+		$xml->addChild('SaPasscode', $this->saPasscode);
+
+		return $xml;
+	}
+
+	/**
+	 * Generates the XML for a API method call within
+	 * @method createCallPayload
+	 * @author PA
+	 * @throws YourMembershipRequestException
+	 * @date   2017-01-09
+	 * @param  string            $method    YourMembership API Function Name
+	 * @param  array             $arguments Array of Arguments to be passed as part of the YourMembership "Call"
+	 * @return \SimpleXMLElement
+	 */
+	public function createCallPayload(string $method, array $arguments) : \SimpleXMLElement
+	{
+		//Create Call Node
+		$call = new \SimpleXMLElement('<Call> </Call>');
+		$call->addAttribute('Method', $method);
+
+		//Add Arguments to the Call Node
+		try {
+			$call = $this->sxmlAddChildrenRecursive($call, $arguments);
+		} catch (\Exception $e) {
+			throw new YourMembershipRequestException($e->getMessage(), $e->getCode(), $e);
+		}
+		return $call;
+	}
+	/**
+	 * Recursively builds the array into a XML Tree
+	 * //NOTE Child arrays must be associative
+	 * @method sxmlAddChildrenRecursive
+	 * @author PA
+	 * @throws \Exception XML Parsing Exception
+	 * @date   2017-01-12
+	 * @param  \SimpleXMLElement         $root      Root XML Node
+	 * @param  array                    $arguments Array of Arguments to be added to XML Node
+	 * @return \SimpleXMLElement                    Resulting XML Tree
+	 */
+	private function sxmlAddChildrenRecursive(\SimpleXMLElement $root, array $arguments) : \SimpleXMLElement
+	{
+		foreach ($arguments as $key => $value) {
+			if (is_array($value)) {
+				$child = new \SimpleXMLElement(sprintf('<%s></%s>', $key, $key));
+				$this->sxmlAddChildrenRecursive($child, $value);
+				$this->sxmlAppend($root, $child);
+			} else {
+				$root->addChild($key, $value);
+			}
+
+		}
+		return $root;
+	}
+	/**
+	 * Builds The XML Request Body for the Your Membership API Call
+	 * @method buildXMLBody
+	 * @author PA
+	 * @date   2017-01-10
+	 * @param  string            $method    Your Membership API Function Name
+	 * @param  array             $arguments Your Membership Arguments
+	 * @return \SimpleXMLElement
+	 */
+	public function buildXMLBody(string $method, array $arguments) : \SimpleXMLElement
+	{
+		$xml = $this->buildBasePayload(); // Common Envelope
+
+		if ($this->isSessionRequiredForMethod($method)) {
+			$xml = $this->addSessionIdToRequest($xml);
+		}
+
+		$callPayload = $this->createCallPayload($method, $arguments); // Specific API Call Envelope
+
+		// Put Api call into common envelope
+		$this->sxmlAppend($xml, $callPayload);
+
+		return $xml;
+	}
+	/**
+	 * Builds a Guzzle Request Object
+	 * @method buildRequest
+	 * @author PA
+	 * @date   2017-01-11
+	 * @param  string        $method    YourMembership API Method
+	 * @param  array         $arguments YourMembership API Method Call Arguments
+	 * @return \GuzzleHttp\Psr7\Request            Guzzle Request Object
+	 */
+	public function buildRequest(string $method, array $arguments) : \GuzzleHttp\Psr7\Request
+	{
+		$requestBody = $this->buildXMLBody($method, $arguments)->asXML();
+		return new GuzzleRequest('POST', self::BASE_URL, ['Content-Type' => 'application/x-www-form-urlencoded; charset=UTF8'], $requestBody);
+	}
+
+	/**
+	 * Checks if Request Requires Session ID
+	 * @method isSessionRequiredForMethod
+	 * @author PA
+	 * @date   2017-01-10
+	 * @param  string                     $method YourMembership API Method
+	 * @return bool
+	 */
+	public function isSessionRequiredForMethod(string $method) : bool
+	{
+		//TODO Add config Logic for what API Methods require Session ID
+		return ($method != 'Session.Create');
+	}
+
+	/**
+	 * Helper for Deep Copy for of $from element into $to element for SimpleXML
+	 * @method sxmlAppend
+	 * @author PA
+	 * @date   2017-01-09
+	 * @param  \SimpleXMLElement $to
+	 * @param  \SimpleXMLElement $from
+	 * @return void
+	 */
+	private function sxmlAppend(\SimpleXMLElement $to, \SimpleXMLElement $from)
+	{
+		$toDom = dom_import_simplexml($to);
+		$fromDom = dom_import_simplexml($from);
+		$toDom->appendChild($toDom->ownerDocument->importNode($fromDom, true));
+	}
+
+	/**
+	 * Adds the Session Variable to the given XML Request Payload
+	 * @method addSessionIdToRequest
+	 * @author PA
+	 * @date   2017-01-10
+	 * @param  \SimpleXMLElement                $requestXML Base Request XML Payload
+	 */
+	private function addSessionIdToRequest(\SimpleXMLElement $requestXML) : \SimpleXMLElement
+	{
+		$requestXML->addChild('SessionID', self::$sessionId);
+		return $requestXML;
+	}
+
+
+	/**
+	 * Setter Method for SessionID
+	 * @method setSessionId
+	 * @author PA
+	 * @date   2017-01-10
+	 * @param  string       $sessionId YourMembership Session ID
+	 */
+	public static function setSessionId(string $sessionId)
+	{
+		self::$sessionId = $sessionId;
+	}
+
+	/**
+	 * Checks if we have an active session available
+	 * @method hasSession
+	 * @author PA
+	 * @date   2017-01-11
+	 * @return boolean
+	 */
+	public function hasSession()
+	{
+		return !is_null(self::$sessionId);
+	}
 
 }

src/YourMembershipClient.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 
 		$response = new Response($method, $this->client->send($request));
 
-		if($response->hasError())
+		if ($response->hasError())
 		{
 			throw new YourMembershipResponseException($response->getError(), $response->getErrorCode(), $method);
 		}

Braces +1 added lines, -2 removed lines

@@ -48,8 +48,7 @@
 
 		$response = new Response($method, $this->client->send($request));
 
-		if($response->hasError())
-		{
+		if($response->hasError()) {
 			throw new YourMembershipResponseException($response->getError(), $response->getErrorCode(), $method);
 		}