FilterExtension::init() - Code Metrics - Inspection of "extended filter extiension to handle filter files" - phmLabs/Smoke - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca5b5d...2e03d0 )

by Nils

created 2015-12-16 12:59 UTC

FilterExtension::init() B

↳ Parent: FilterExtension

Complexity

Conditions	5
Paths	5

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	18
rs	8.8571
cc	5
eloc	10
nc	5
nop	2

<?php

namespace whm\Smoke\Extensions\SmokeFilter;

use phmLabs\Components\Annovent\Event\Event;
use whm\Smoke\Http\Response;
use whm\Smoke\Yaml\EnvAwareYaml;

class FilterExtension
{
    private $filters = array();

    public function init($filters = array(), $filterFile = "")
    {
        if ($filterFile != "") {
            if (!file_exists($filterFile)) {
                throw new \RuntimeException('Filter file not found: ' . $filterFile);
            }

            $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));

            foreach ($filterElements as $rule => $uris) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                foreach ($uris as $uri) {
                    $this->filters[] = array("rule" => $rule, "uri" => $uri);
                }
            }
        } else {
            $this->filters = $filters;
        }
    }

    /**
     * @Event("Scanner.CheckResponse.isFiltered")
     */
    public function isFiltered(Event $event, $ruleName, Response $response)
    {
        foreach ($this->filters as $filter) {
            if ($ruleName === $filter['rule'] && 0 < preg_match($filter['uri'], (string)$response->getUri())) {
                $event->setProcessed();
                return true;
            }
        }

        return false;
    }
}


1			<?php
2
3			namespace whm\Smoke\Extensions\SmokeFilter;
4
5			use phmLabs\Components\Annovent\Event\Event;
6			use whm\Smoke\Http\Response;
7			use whm\Smoke\Yaml\EnvAwareYaml;
8
9			class FilterExtension
10			{
11			private $filters = array();
12
13			public function init($filters = array(), $filterFile = "")
14			{
15			if ($filterFile != "") {
16			if (!file_exists($filterFile)) {
17			throw new \RuntimeException('Filter file not found: ' . $filterFile);
18			}
19
20			$filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));
21
22			foreach ($filterElements as $rule => $uris) {
			0 ignored issues – show Bug introduced 2015-12-16 13:03 UTC by Report Bug Copy Issue Report The expression `$filterElements` of type `array\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
23			foreach ($uris as $uri) {
24			$this->filters[] = array("rule" => $rule, "uri" => $uri);
25			}
26			}
27			} else {
28			$this->filters = $filters;
29			}
30			}
31
32			/**
33			* @Event("Scanner.CheckResponse.isFiltered")
34			*/
35			public function isFiltered(Event $event, $ruleName, Response $response)
36			{
37			foreach ($this->filters as $filter) {
38			if ($ruleName === $filter['rule'] && 0 < preg_match($filter['uri'], (string)$response->getUri())) {
39			$event->setProcessed();
40			return true;
41			}
42			}
43
44			return false;
45			}
46			}
47

phmLabs / Smoke

Push — master ( ca5b5d...2e03d0 )

FilterExtension::init() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like