whm\Smoke\Extensions\SmokeFilter\FilterExtension

Complexity

Total Complexity

9

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	3
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
B	init()	0	18	5
A	isFiltered()	0	11	4

<?php

namespace whm\Smoke\Extensions\SmokeFilter;

use phmLabs\Components\Annovent\Event\Event;
use whm\Smoke\Http\Response;
use whm\Smoke\Yaml\EnvAwareYaml;

class FilterExtension
{
    private $filters = array();

    public function init($filters = array(), $filterFile = "")
    {
        if ($filterFile != "") {
            if (!file_exists($filterFile)) {
                throw new \RuntimeException('Filter file not found: ' . $filterFile);
            }

            $filterElements = EnvAwareYaml::parse(file_get_contents($filterFile));

            foreach ($filterElements as $rule => $uris) {

The expression $filterElements of type array|string is not guaranteed to be traversable. How about adding an additional type check?

                foreach ($uris as $uri) {
                    $this->filters[] = array("rule" => $rule, "uri" => $uri);
                }
            }
        } else {
            $this->filters = $filters;
        }
    }

    /**
     * @Event("Scanner.CheckResponse.isFiltered")
     */
    public function isFiltered(Event $event, $ruleName, Response $response)
    {
        foreach ($this->filters as $filter) {
            if ($ruleName === $filter['rule'] && 0 < preg_match($filter['uri'], (string)$response->getUri())) {
                $event->setProcessed();
                return true;
            }
        }

        return false;
    }
}