phmLabs / Smoke

src/Rules/CheckResult.php

Doc Comments +2 added lines, -2 removed lines

@@ -44,7 +44,7 @@ 
     }
 
     /**
-     * @param array $attributes
+     * @param array $attribute
      */
     public function addAttribute(Attribute $attribute)
     {
@@ -68,7 +68,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getMessage()
     {

src/Rules/Http/HttpsCertificateExpireRule.php

Spacing +4 added lines, -4 removed lines

@@ -31,7 +31,7 @@ 
         } else {
 
             if ($certInfo['validFrom_time_t'] > time() || $certInfo['validTo_time_t'] < time()) {
-                $errorMessage = 'Certificate is expired. [' . $validFrom . ' - ' . $validTo . ']';
+                $errorMessage = 'Certificate is expired. ['.$validFrom.' - '.$validTo.']';
 
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage);
                 $infoJson = json_encode($certInfo);
@@ -41,8 +41,8 @@ 
                     $result->addAttribute(new Attribute('certificate information', $infoJson, true));
                 }
                 return $result;
-            } elseif ($certInfo['validTo_time_t'] < strtotime('+' . $this->expireWarningTime . 'days')) {
-                $errorMessage = 'Certificate warning, expires in less than ' . $this->expireWarningTime . ' days. Certificate expires at: ' . $validTo;
+            } elseif ($certInfo['validTo_time_t'] < strtotime('+'.$this->expireWarningTime.'days')) {
+                $errorMessage = 'Certificate warning, expires in less than '.$this->expireWarningTime.' days. Certificate expires at: '.$validTo;
 
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $errorMessage);
                 $result->addAttribute(new Attribute('certificate information', json_encode($certInfo), true));
@@ -50,6 +50,6 @@ 
             }
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next ' . $this->expireWarningTime . ' days. Expire date: ' . $validTo . '.');
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'The certificate does not expire within the next '.$this->expireWarningTime.' days. Expire date: '.$validTo.'.');
     }
 }

src/Rules/Http/HttpsRule.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
         $sslOptions = stream_context_create(array('ssl' => array('capture_peer_cert' => true)));
 
         $request = @stream_socket_client(
-            'ssl://' . $host . ':443',
+            'ssl://'.$host.':443',
             $errno,
             $errstr,
             30,

src/Scanner/Scanner.php

Spacing +3 added lines, -3 removed lines

@@ -55,14 +55,14 @@ 
 
         while (($response = $this->responseRetriever->next()) && !$this->eventDispatcher->notifyUntil(new Event('Scanner.Scan.isStopped'))) {
 
-            var_dump((string)$response->getUri());
+            var_dump((string) $response->getUri());
 
             // this is the url filter
             if ($this->eventDispatcher->notifyUntil(new Event('Scanner.ProcessHtml.isFiltered', array('uri' => $response->getUri())))) {
                 continue;
             }
 
-            var_dump((string)$response->getUri());
+            var_dump((string) $response->getUri());
 
             $results = $this->checkResponse($response);
 
@@ -99,7 +99,7 @@ 
             } catch (ValidationFailedException $e) {
                 $result = new CheckResult(CheckResult::STATUS_FAILURE, $e->getMessage());
             } catch (\Exception $e) {
-                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: ' . $e->getMessage());
+                $result = new CheckResult(CheckResult::STATUS_FAILURE, 'An error occured: '.$e->getMessage());
             }
 
             $result->setResponse($response);

src/Extensions/SmokeReporter/Reporter/LeankoalaReporter.php

Spacing +11 added lines, -11 removed lines

@@ -120,7 +120,7 @@ 
         foreach ($this->results as $results) {
             foreach ($results as $result) {
                 /* @var CheckResult $result */
-                $tool = 'Smoke' . $result->getRuleName();
+                $tool = 'Smoke'.$result->getRuleName();
                 $checks[$tool][] = $result;
             }
         }
@@ -132,19 +132,19 @@ 
                 continue;
             }
 
-            $message = 'The smoke test for #system_name# failed (Rule: ' . $toolName . ').<ul>';
+            $message = 'The smoke test for #system_name# failed (Rule: '.$toolName.').<ul>';
             $status = Event::STATUS_SUCCESS;
             $failureCount = 0;
-            $identifier = $toolName . '_' . $this->system;
+            $identifier = $toolName.'_'.$this->system;
 
             foreach ($results as $result) {
                 /** @var CheckResult $result */
                 if ($result->getStatus() === CheckResult::STATUS_FAILURE) {
                     $comingFrom = '';
                     if ($this->addComingFrom && $this->retriever->getComingFrom($result->getResponse()->getUri())) {
-                        $comingFrom = ', coming from: ' . $this->retriever->getComingFrom($result->getResponse()->getUri());
+                        $comingFrom = ', coming from: '.$this->retriever->getComingFrom($result->getResponse()->getUri());
                     }
-                    $message .= '<li>' . $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . $comingFrom . ')</li>';
+                    $message .= '<li>'.$result->getMessage().' (url: '.(string) $result->getResponse()->getUri().$comingFrom.')</li>';
                     ++$failureCount;
                 }
             }
@@ -152,9 +152,9 @@ 
                 $status = Event::STATUS_FAILURE;
                 $message .= '</ul>';
                 $firstResult = array_pop($results);
-                $attributes[] = new Attribute('html-content', (string)$firstResult->getResponse()->getBody(), true);
+                $attributes[] = new Attribute('html-content', (string) $firstResult->getResponse()->getBody(), true);
             } else {
-                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:' . $toolName . '].';
+                $message = 'All checks for system "#system_name#" succeeded [SmokeBasic:'.$toolName.'].';
             }
 
             $this->send($identifier, $this->system, $message, $status, $failureCount, $this->tool, $this->system, $attributes);
@@ -167,7 +167,7 @@ 
             foreach ($results as $result) {
                 /* @var CheckResult $result */
 
-                $identifier = '_' . $this->getIdentifier($result);
+                $identifier = '_'.$this->getIdentifier($result);
                 $tool = $this->getPrefix($result->getRuleName());
 
                 $component = $this->getComponent($result->getRuleName());
@@ -175,7 +175,7 @@ 
 
                 $attributes = array();
                 if ($result->getStatus() == CheckResult::STATUS_FAILURE) {
-                    $attributes[] = new Attribute('html content', (string)$result->getResponse()->getBody(), true);
+                    $attributes[] = new Attribute('html content', (string) $result->getResponse()->getBody(), true);
                     $attributes[] = new Attribute('http header', json_encode($result->getResponse()->getHeaders()), true);
                     $attributes[] = new Attribute('http status code', $result->getResponse()->getStatusCode());
                 }
@@ -194,7 +194,7 @@ 
                 $this->send(
                     $identifier,
                     $currentSystem,
-                    $result->getMessage() . ' (url: ' . (string)$result->getResponse()->getUri() . ')',
+                    $result->getMessage().' (url: '.(string) $result->getResponse()->getUri().')',
                     $result->getStatus(),
                     $result->getValue(),
                     $tool,
@@ -207,7 +207,7 @@ 
 
     private function getIdentifier(CheckResult $result)
     {
-        return $this->tool . '_' . $result->getRuleName();
+        return $this->tool.'_'.$result->getRuleName();
     }
 
     private function getPrefix($string)