phmLabs / Smoke

src/Rules/Xml/Sitemap/ValidRule.php

Doc Comments +7 added lines

@@ -27,6 +27,9 @@ 
         $this->strictMode = $strictMode;
     }
 
+    /**
+     * @param boolean $isIndex
+     */
     private function getSchema($isIndex)
     {
         if ($isIndex) {
@@ -40,6 +43,10 @@ 
         }
     }
 
+    /**
+     * @param string $body
+     * @param string $filename
+     */
     private function validateBody($body, $filename, $isIndex = true)
     {
         $dom = new \DOMDocument();

Spacing +7 added lines, -7 removed lines

@@ -30,13 +30,13 @@ 
     private function getSchema($isIndex)
     {
         if ($isIndex) {
-            return __DIR__ . '/' . self::INDEX;
+            return __DIR__.'/'.self::INDEX;
         }
 
         if ($this->strictMode) {
-            return __DIR__ . '/' . self::SCHEMA;
+            return __DIR__.'/'.self::SCHEMA;
         } else {
-            return __DIR__ . '/' . self::NON_STRICT_SCHEMA;
+            return __DIR__.'/'.self::NON_STRICT_SCHEMA;
         }
     }
 
@@ -50,19 +50,19 @@ 
         if (!$valid) {
             $lastError = libxml_get_last_error();
             throw new ValidationFailedException(
-                'The given sitemap file (' . $filename . ') did not validate against the sitemap schema (last error: ' . str_replace("\n", '', $lastError->message) . ').');
+                'The given sitemap file ('.$filename.') did not validate against the sitemap schema (last error: '.str_replace("\n", '', $lastError->message).').');
         }
     }
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         // sitemapindex or urlset
         if (preg_match('/<sitemapindex/', $body)) {
-            $this->validateBody($body, (string)$response->getUri());
+            $this->validateBody($body, (string) $response->getUri());
         } elseif (preg_match('/<urlset/', $body)) {
-            $this->validateBody($body, (string)$response->getUri(), false);
+            $this->validateBody($body, (string) $response->getUri(), false);
         }
     }
 }

src/Rules/Xml/Rss/ValidRule.php

Spacing +7 added lines, -7 removed lines

@@ -15,7 +15,7 @@ 
 
     private function getSchema()
     {
-        return __DIR__ . '/' . self::SCHEMA;
+        return __DIR__.'/'.self::SCHEMA;
     }
 
     public function validate(ResponseInterface $response)
@@ -24,7 +24,7 @@ 
             return;
         }
 
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
         if (preg_match('/<rss/', $body)) {
             libxml_clear_errors();
             $dom = new \DOMDocument();
@@ -32,17 +32,17 @@ 
             $lastError = libxml_get_last_error();
             if ($lastError) {
                 throw new ValidationFailedException(
-                    'The given xml file is not well formed (last error: ' .
-                    str_replace("\n", '', $lastError->message) . ').');
+                    'The given xml file is not well formed (last error: '.
+                    str_replace("\n", '', $lastError->message).').');
             }
             $valid = @$dom->schemaValidate($this->getSchema());
             if (!$valid) {
                 $lastError = libxml_get_last_error();
                 $lastErrorMessage = str_replace("\n", '', $lastError->message);
                 throw new ValidationFailedException(
-                    'The given xml file did not Validate vs. ' .
-                    $this->getSchema() . ' (last error: ' .
-                    $lastErrorMessage . ').');
+                    'The given xml file did not Validate vs. '.
+                    $this->getSchema().' (last error: '.
+                    $lastErrorMessage.').');
             }
         }
     }

src/Rules/Xml/XmlValidXsdRule.php

Spacing +4 added lines, -4 removed lines

@@ -22,12 +22,12 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $dom = new \DOMDocument();
         @$dom->loadXML($body);
 
-        $filename = (string)$response->getUri();
+        $filename = (string) $response->getUri();
 
         $error = false;
         $messageParts = array();
@@ -39,12 +39,12 @@ 
                 $error = true;
                 $lastError = libxml_get_last_error();
 
-                $messageParts[] = $xsdFile['xsdfilename'] . ' - ' . $xsdFile['xsdfileurl'] . '(last error: ' . str_replace("\n", '', $lastError->message) . ').';
+                $messageParts[] = $xsdFile['xsdfilename'].' - '.$xsdFile['xsdfileurl'].'(last error: '.str_replace("\n", '', $lastError->message).').';
             }
         }
 
         if ($error === true) {
-            $message = 'XML file (' . $filename . ')  does not validate against the following XSD files: ' . implode(', ', $messageParts);
+            $message = 'XML file ('.$filename.')  does not validate against the following XSD files: '.implode(', ', $messageParts);
             throw new ValidationFailedException($message);
         }
     }

src/Rules/Xml/DuplicateIdRule.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
             return;
         }
 
-        $crawler = new Crawler((string)$response->getBody());
+        $crawler = new Crawler((string) $response->getBody());
 
         $idList = $crawler->filterXPath('//*[@id!=""]');
 
@@ -36,7 +36,7 @@ 
 
         if (count($duplicatedIds) > 0) {
             unset($duplicatedIds['']);
-            throw new ValidationFailedException('Duplicate ids found (' . implode(', ', array_keys($duplicatedIds)) . ')');
+            throw new ValidationFailedException('Duplicate ids found ('.implode(', ', array_keys($duplicatedIds)).')');
         }
     }
 }

src/Rules/Json/ValidRule.php

Spacing +2 added lines, -2 removed lines

@@ -26,9 +26,9 @@
 
     public function doValidation(ResponseInterface $response)
     {
-        $result = json_decode((string)$response->getBody());
+        $result = json_decode((string) $response->getBody());
         if ($result === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         }
     }
 }

src/Rules/Json/JsonPathExistsRule.php

Spacing +4 added lines, -4 removed lines

@@ -54,7 +54,7 @@ 
 
     public function doValidation(ResponseInterface $response)
     {
-        $body = (string)$response->getBody();
+        $body = (string) $response->getBody();
 
         $json = json_decode($body);
 
@@ -73,17 +73,17 @@ 
 
             if ($jsonValue === false || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON Path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON Path not found)';
             }
             if ($this->checkRelation($path['relation'], $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (number of JSONPaths is not correct corresponding to the given relation/value)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (number of JSONPaths is not correct corresponding to the given relation/value)';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Json/JsonSchema/JsonSchemaRule.php

Spacing +5 added lines, -5 removed lines

@@ -33,9 +33,9 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $data = json_decode((string)$response->getBody());
+        $data = json_decode((string) $response->getBody());
         if ($data === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         } else {
             $errorStatus = false;
             $messageParts = array();
@@ -51,14 +51,14 @@ 
                     $errorStatus = true;
                     $errorMessage = '';
                     foreach ($validator->getErrors() as $error) {
-                        $errorMessage = $errorMessage . sprintf("[%s] %s\n", $error['property'], $error['message']);
+                        $errorMessage = $errorMessage.sprintf("[%s] %s\n", $error['property'], $error['message']);
                     }
-                    $messageParts[] = $jsonSchemaFile['jsonfilename'] . ' - ' . $jsonSchemaFile['jsonfileurl'] . '(last error: ' . $errorMessage . ').';
+                    $messageParts[] = $jsonSchemaFile['jsonfilename'].' - '.$jsonSchemaFile['jsonfileurl'].'(last error: '.$errorMessage.').';
                 }
             }
 
             if ($errorStatus === true) {
-                $message = 'JSON file (' . (string) $response->getUri() . ')  does not validate against the following JSON Schema files: ' . implode(', ', $messageParts);
+                $message = 'JSON file ('.(string) $response->getUri().')  does not validate against the following JSON Schema files: '.implode(', ', $messageParts);
                 throw new ValidationFailedException($message);
             }
         }

src/Rules/Html/ForeignDomainImageRule.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
 
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody());
+        $document = new Document((string) $response->getBody());
         $images = $document->getImages($response->getUri());
 
         $foreignImages = array();
@@ -37,10 +37,10 @@ 
         foreach ($images as $image) {
             /* @var $image Uri */
             if ($currentUri->getHost($this->depth) !== $image->getHost($this->depth)) {
-                $foreignImages[] = (string)$image;
+                $foreignImages[] = (string) $image;
             }
         }
 
-        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
+        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found ('.implode(', ', $foreignImages).')');
     }
 }

src/Rules/Html/ClosingHtmlTagRule.php

Spacing +2 added lines, -2 removed lines

@@ -16,8 +16,8 @@
     {
         if ($response instanceof ContentTypeAwareResponse) {
             if (($response->getStatusCode() < 300 || $response->getStatusCode() >= 400) && $response->getContentType() === 'text/html') {
-                if (stripos((string)$response->getBody(), '</html>') === false) {
-                    throw new ValidationFailedException('Closing html tag is missing (document lengh: ' . strlen((string)$response->getBody()) . ').');
+                if (stripos((string) $response->getBody(), '</html>') === false) {
+                    throw new ValidationFailedException('Closing html tag is missing (document lengh: '.strlen((string) $response->getBody()).').');
                 }
             }
         }