phmLabs / Smoke

src/Rules/Html/RegExExistsRule.php

Doc Comments -1 removed lines

@@ -15,7 +15,6 @@
     protected $contentTypes = array('text/html');
 
     /**
-     * @param int $string The string that the document must contain
      */
     public function init(array $regExs)
     {

Spacing +5 added lines, -5 removed lines

@@ -29,12 +29,12 @@ 
 
         foreach ($this->regExs as $regEx) {
             if ($regEx['isRegEx']) {
-                if (preg_match('^' . $regEx['pattern'] . '^', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Regular expression: ' . $regEx['pattern'];
+                if (preg_match('^'.$regEx['pattern'].'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Regular expression: '.$regEx['pattern'];
                 }
             } else {
-                if (preg_match('^' . preg_quote($regEx['pattern']) . '^', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Text: ' . $regEx['pattern'];
+                if (preg_match('^'.preg_quote($regEx['pattern']).'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Text: '.$regEx['pattern'];
                 }
             }
         }
@@ -43,7 +43,7 @@ 
             $errorString = 'The following text elements were not found: <ul>';
 
             foreach ($errors as $error) {
-                $errorString .= '<li>' . $error . '</li>';
+                $errorString .= '<li>'.$error.'</li>';
             }
 
             $errorString .= '</ul>';

src/Rules/Js/SyntaxRule.php

Spacing +5 added lines, -5 removed lines

@@ -30,18 +30,18 @@
             return;
         }
 
-        $filename = $this->tmpDir . DIRECTORY_SEPARATOR . md5($response->getBody()) . '.js';
+        $filename = $this->tmpDir.DIRECTORY_SEPARATOR.md5($response->getBody()).'.js';
         file_put_contents($filename, $response->getBody());
-        $conf = __DIR__ . DIRECTORY_SEPARATOR . 'jsHint.conf';
+        $conf = __DIR__.DIRECTORY_SEPARATOR.'jsHint.conf';
 
-        $command = $this->jsHintExecutable . ' --config ' . $conf . ' --verbose ' . $filename . ' | grep -E E[0-9]+.$';
+        $command = $this->jsHintExecutable.' --config '.$conf.' --verbose '.$filename.' | grep -E E[0-9]+.$';
         $validationResult = shell_exec($command);
 
         unlink($filename);
 
         if (!is_null($validationResult)) {
-            $errorMsg = str_replace($filename . ':', '', $validationResult);
-            throw new ValidationFailedException('JavaScript error found: ' . $errorMsg);
+            $errorMsg = str_replace($filename.':', '', $validationResult);
+            throw new ValidationFailedException('JavaScript error found: '.$errorMsg);
         }
     }
 }

src/Rules/Xml/DuplicateIdRule.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 
         if (count($duplicatedIds) > 0) {
             unset($duplicatedIds['']);
-            throw new ValidationFailedException('Duplicate ids found (' . implode(', ', array_keys($duplicatedIds)) . ')');
+            throw new ValidationFailedException('Duplicate ids found ('.implode(', ', array_keys($duplicatedIds)).')');
         }
     }
 }

src/Rules/Image/FavIconRule.php

Spacing +1 added lines, -1 removed lines

@@ -31,6 +31,6 @@
 
         $imageHash = md5($response->getBody());
 
-        $this->assert(!array_key_exists($imageHash, $this->favicons), 'Seems like you use the standard favicon of your framework (' . $this->favicons[$imageHash] . ').');
+        $this->assert(!array_key_exists($imageHash, $this->favicons), 'Seems like you use the standard favicon of your framework ('.$this->favicons[$imageHash].').');
     }
 }

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace whm\Smoke\Rules\Image;
 
 use Psr\Http\Message\ResponseInterface;
-use whm\Smoke\Http\Response;
 use whm\Smoke\Rules\StandardRule;
 
 /**

src/Rules/Security/PasswordSecureTransferRule.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 
             while ($parent = $parent->parentNode) {
                 if (property_exists($parent, 'tagName')) {
-                    $fullPath = $parent->tagName . '/' . $fullPath;
+                    $fullPath = $parent->tagName.'/'.$fullPath;
                 } else {
                     break;
                 }

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use Psr\Http\Message\ResponseInterface;
 use Symfony\Component\DomCrawler\Crawler;
-use whm\Smoke\Http\Response;
-use whm\Smoke\Rules\Rule;
 use whm\Smoke\Rules\StandardRule;
 
 /**

src/Rules/Json/ValidRule.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     {
         $result = json_decode($response->getBody());
         if ($result === null) {
-            throw new ValidationFailedException("The given JSON data can not be validated (last error: '" . $this->json_errors[json_last_error()] . "').");
+            throw new ValidationFailedException("The given JSON data can not be validated (last error: '".$this->json_errors[json_last_error()]."').");
         }
     }
 }

src/Cli/Command/ExplainCommand.php

Spacing +4 added lines, -4 removed lines

@@ -37,15 +37,15 @@
 
         foreach ($rules as $name => $rule) {
             $info = Init::getInitInformationByClass(get_class($rule));
-            $output->writeln('  ' . $name . ':');
-            $output->writeln('    class: ' . get_class($rule));
-            $output->writeln('    description: ' . str_replace("\n", "\n                 ", $info['documentation']));
+            $output->writeln('  '.$name.':');
+            $output->writeln('    class: '.get_class($rule));
+            $output->writeln('    description: '.str_replace("\n", "\n                 ", $info['documentation']));
 
             if (count($info['parameters']) > 0) {
                 $output->writeln('    parameter:');
 
                 foreach ($info['parameters'] as $parameter) {
-                    $output->writeln('      ' . $parameter['name'] . ': ' . $parameter['description'] . ' (default: ' . $parameter['default'] . ')');
+                    $output->writeln('      '.$parameter['name'].': '.$parameter['description'].' (default: '.$parameter['default'].')');
                 }
             }
 

src/Cli/Command/ScanCommand.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      */
     private function initConfiguration($num_urls, $run_level, Uri $uri, Dispatcher $dispatcher)
     {
-        $configArray = $this->getConfigArray(__DIR__ . '/../../settings/' . self::CONFIG_FILE);
+        $configArray = $this->getConfigArray(__DIR__.'/../../settings/'.self::CONFIG_FILE);
 
         $config = new Configuration($uri, $dispatcher, $configArray);
 

src/Cli/Command/WarmUpCommand.php

Spacing +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
      */
     private function initConfiguration(Uri $uri, Dispatcher $dispatcher)
     {
-        $configArray = $this->getConfigArray(__DIR__ . '/../../settings/warmup.yml');
+        $configArray = $this->getConfigArray(__DIR__.'/../../settings/warmup.yml');
 
         $config = new Configuration($uri, $dispatcher, $configArray);