Completed
Push — master ( 33a55e...ca53a0 )
by Nils
07:47
created
src/Rules/Html/StringNotExistsRule.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,6 +25,6 @@
 block discarded – undo
25 25
     public function doValidation(ResponseInterface $response)
26 26
     {
27 27
         $this->assert(strpos($response->getBody(), $this->string) !== false,
28
-            'The given string (' . $this->string . ') was found in this document.');
28
+            'The given string ('.$this->string.') was found in this document.');
29 29
     }
30 30
 }
Please login to merge, or discard this patch.
src/Rules/Html/XPathExistsRule.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     public function doValidation(ResponseInterface $response)
23 23
     {
24 24
         $domDocument = new \DOMDocument();
25
-        @$domDocument->loadHTML((string)$response->getBody());
25
+        @$domDocument->loadHTML((string) $response->getBody());
26 26
 
27 27
         $domXPath = new \DOMXPath($domDocument);
28 28
 
@@ -30,16 +30,16 @@  discard block
 block discarded – undo
30 30
             $count = $domXPath->query($xpath['pattern'])->length;
31 31
 
32 32
             if ($xpath['relation'] === 'equals') {
33
-                $result = $count === (int)$xpath['value'];
34
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
33
+                $result = $count === (int) $xpath['value'];
34
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
35 35
             } elseif ($xpath['relation'] === 'less than') {
36
-                $result = $count < (int)$xpath['value'];
37
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
36
+                $result = $count < (int) $xpath['value'];
37
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
38 38
             } elseif ($xpath['relation'] === 'greater than') {
39
-                $result = $count > (int)$xpath['value'];
40
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
39
+                $result = $count > (int) $xpath['value'];
40
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
41 41
             } else {
42
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
42
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
43 43
             }
44 44
 
45 45
             $this->assert($result, $message);
Please login to merge, or discard this patch.
src/Rules/Html/CssSelectorExistsRule.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     public function doValidation(ResponseInterface $response)
25 25
     {
26 26
         $domDocument = new \DOMDocument();
27
-        @$domDocument->loadHTML((string)$response->getBody());
27
+        @$domDocument->loadHTML((string) $response->getBody());
28 28
 
29 29
         $domXPath = new \DOMXPath($domDocument);
30 30
 
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
             try {
38 38
                 $selectorAsXPath = $converter->toXPath($selector['pattern']);
39 39
             } catch (\Exception $e) {
40
-                throw new ValidationFailedException('Invalid css selector (' . $selector['pattern'] . ').');
40
+                throw new ValidationFailedException('Invalid css selector ('.$selector['pattern'].').');
41 41
             }
42 42
 
43 43
             $count = $domXPath->query($selectorAsXPath)->length;
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
         if ($error === true) {
52 52
             $allNotFoundSelectors = implode('", "', $snotFoundSelectors);
53 53
 
54
-            throw new ValidationFailedException('CSS Selector "' . $allNotFoundSelectors . '" not found in DOM.');
54
+            throw new ValidationFailedException('CSS Selector "'.$allNotFoundSelectors.'" not found in DOM.');
55 55
         }
56 56
     }
57 57
 }
Please login to merge, or discard this patch.
src/Rules/Seo/GoogleMobileFriendlyRule.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
     private function getEndpoint(Uri $uri)
16 16
     {
17
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
17
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
18 18
     }
19 19
 
20 20
     public function validate(ResponseInterface $response)
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             )));
34 34
 
35 35
         if (property_exists($result, 'error')) {
36
-            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
36
+            $checkResult = new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
37 37
             $checkResult->addAttribute(new Attribute('Google response', json_encode($result), true));
38 38
             return $checkResult;
39 39
         }
@@ -41,9 +41,9 @@  discard block
 block discarded – undo
41 41
         $passResult = $result->ruleGroups->USABILITY;
42 42
 
43 43
         if (!$passResult->pass) {
44
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
44
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
45 45
         }
46 46
 
47
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
47
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
48 48
     }
49 49
 }
Please login to merge, or discard this patch.
src/Cli/Command/SmokeCommand.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
55 55
      */
56 56
     protected function writeSmokeCredentials($url = null)
57 57
     {
58
-        $this->output->writeln("\n Smoke " . SMOKE_VERSION . " by Nils Langner\n");
58
+        $this->output->writeln("\n Smoke ".SMOKE_VERSION." by Nils Langner\n");
59 59
 
60 60
         if ($url) {
61
-            $this->output->writeln(' <info>Scanning ' . $url . "</info>\n");
61
+            $this->output->writeln(' <info>Scanning '.$url."</info>\n");
62 62
         }
63 63
     }
64 64
 
@@ -88,12 +88,12 @@  discard block
 block discarded – undo
88 88
         if ($configFile) {
89 89
             if (strpos($configFile, 'http://') === 0 || strpos($configFile, 'https://') === 0) {
90 90
                 $curlClient = new CurlHttpAdapter();
91
-                $fileContent = (string)$curlClient->get($configFile)->getBody();
91
+                $fileContent = (string) $curlClient->get($configFile)->getBody();
92 92
             } else {
93 93
                 if (file_exists($configFile)) {
94 94
                     $fileContent = file_get_contents($configFile);
95 95
                 } else {
96
-                    throw new \RuntimeException("Config file was not found ('" . $configFile . "').");
96
+                    throw new \RuntimeException("Config file was not found ('".$configFile."').");
97 97
                 }
98 98
             }
99 99
             $configArray = EnvAwareYaml::parse($fileContent);
Please login to merge, or discard this patch.