phmLabs / Smoke

src/Rules/Html/StringExistsRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,6 +25,6 @@
     protected function doValidation(ResponseInterface $response)
     {
         $this->assert(strpos($response->getBody(), $this->string) !== false,
-            'The given string (' . $this->string . ') was not found in this document.');
+            'The given string ('.$this->string.') was not found in this document.');
     }
 }

src/Rules/Html/RegExNotExistsRule.php

Spacing +2 added lines, -2 removed lines

@@ -25,8 +25,8 @@
     protected function doValidation(ResponseInterface $response)
     {
         foreach ($this->regExs as $regEx) {
-            $this->assert(preg_match('^' . $regEx . '^', (string)$response->getBody()) === 0,
-                'The given regular expression (' . $regEx . ') was found in this document.');
+            $this->assert(preg_match('^'.$regEx.'^', (string) $response->getBody()) === 0,
+                'The given regular expression ('.$regEx.') was found in this document.');
         }
     }
 }

src/Rules/Html/SizeRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,6 +26,6 @@
     protected function doValidation(ResponseInterface $response)
     {
         $size = strlen($response->getBody()) / 1000;
-        $this->assert($size <= $this->maxSize, 'The size of this html file is too big (' . $size . ' KB)');
+        $this->assert($size <= $this->maxSize, 'The size of this html file is too big ('.$size.' KB)');
     }
 }

src/Rules/Html/RegExExistsRule.php

Spacing +5 added lines, -5 removed lines

@@ -29,12 +29,12 @@ 
 
         foreach ($this->regExs as $regEx) {
             if ($regEx['isRegEx']) {
-                if (preg_match('^' . $regEx['pattern'] . '^', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Regular expression: ' . $regEx['pattern'];
+                if (preg_match('^'.$regEx['pattern'].'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Regular expression: '.$regEx['pattern'];
                 }
             } else {
-                if (preg_match('^' . preg_quote($regEx['pattern']) . '^', (string)$response->getBody()) === 0) {
-                    $errors[] = 'Text: ' . $regEx['pattern'];
+                if (preg_match('^'.preg_quote($regEx['pattern']).'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Text: '.$regEx['pattern'];
                 }
             }
         }
@@ -43,7 +43,7 @@ 
             $errorString = 'The following text elements were not found: <ul>';
 
             foreach ($errors as $error) {
-                $errorString .= '<li>' . $error . '</li>';
+                $errorString .= '<li>'.$error.'</li>';
             }
 
             $errorString .= '</ul>';

src/Rules/Html/CountRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
     protected function doValidation(ResponseInterface $response)
     {
-        $document = new Document((string)$response->getBody());
+        $document = new Document((string) $response->getBody());
         $files = $this->getFilesToCount($document, $response);
 
         $this->assert(count($files) <= $this->maxCount, sprintf($this->errorMessage, count($files)));

src/Rules/Html/ForeignDomainImageRule.php

Spacing +2 added lines, -2 removed lines

@@ -37,10 +37,10 @@
         foreach ($images as $image) {
             /* @var $image Uri */
             if ($currentUri->getHost($this->depth) !== $image->getHost($this->depth)) {
-                $foreignImages[] = (string)$image;
+                $foreignImages[] = (string) $image;
             }
         }
 
-        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
+        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found ('.implode(', ', $foreignImages).')');
     }
 }

src/Rules/Html/ClosingHtmlTagRule.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
         if ($response instanceof ContentTypeAwareResponse) {
             if (($response->getStatusCode() < 300 || $response->getStatusCode() >= 400) && $response->getContentType() === 'text/html') {
                 if (stripos($response->getBody(), '</html>') === false) {
-                    throw new ValidationFailedException('Closing html tag is missing (document lengh: ' . strlen($response->getBody()) . ').');
+                    throw new ValidationFailedException('Closing html tag is missing (document lengh: '.strlen($response->getBody()).').');
                 }
             }
         }

src/Rules/Html/StringNotExistsRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,6 +25,6 @@
     public function doValidation(ResponseInterface $response)
     {
         $this->assert(strpos($response->getBody(), $this->string) !== false,
-            'The given string (' . $this->string . ') was found in this document.');
+            'The given string ('.$this->string.') was found in this document.');
     }
 }

src/Rules/Html/XPathExistsRule.php

Spacing +8 added lines, -8 removed lines

@@ -22,7 +22,7 @@ 
     public function doValidation(ResponseInterface $response)
     {
         $domDocument = new \DOMDocument();
-        @$domDocument->loadHTML((string)$response->getBody());
+        @$domDocument->loadHTML((string) $response->getBody());
 
         $domXPath = new \DOMXPath($domDocument);
 
@@ -30,16 +30,16 @@ 
             $count = $domXPath->query($xpath['pattern'])->length;
 
             if ($xpath['relation'] === 'equals') {
-                $result = $count === (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $result = $count === (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
-                $result = $count < (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $result = $count < (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
-                $result = $count > (int)$xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $result = $count > (int) $xpath['value'];
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);