phmLabs / Smoke

src/Extensions/SmokeResponseRetriever/Retriever/Koalamon/Retriever.php

Doc Comments +5 added lines

@@ -42,6 +42,11 @@
         return json_decode($systems->getBody());
     }
 
+    /**
+     * @param string $url
+     *
+     * @return string
+     */
     private function prepareUrl($url)
     {
         $preparedUrl = str_replace("#project#", $this->project, $url);

src/Http/Response.php

Doc Comments +3 added lines

@@ -13,6 +13,9 @@
         return $this->getStatusCode();
     }
 
+    /**
+     * @return string
+     */
     public function getContentType()
     {
         $exploded = explode(';', $this->hasHeader('Content-Type') ? $this->getHeader('Content-Type')[0] : null);

src/Extensions/SmokeReporter/Reporter/KoalamonReporter.php

Doc Comments +4 added lines

@@ -159,6 +159,10 @@
         }
     }
 
+    /**
+     * @param string $identifier
+     * @param string $message
+     */
     public function send($identifier, $system, $message, $status, $url = '', $value = 0)
     {
         $event = new Event($identifier, $system, $status, $this->tool, $message, $value);

Spacing +15 added lines, -15 removed lines

@@ -92,7 +92,7 @@ 
 
     public function finish()
     {
-        $this->output->writeln('Sending results to ' . $this->server . " ... \n");
+        $this->output->writeln('Sending results to '.$this->server." ... \n");
 
         if ($this->groupBy === 'prefix') {
             $this->sendGroupedByPrefix();
@@ -123,7 +123,7 @@ 
 
         foreach ($this->getRuleKeys() as $rule) {
             foreach ($systems as $system) {
-                $identifier = $this->tool . '_' . $this->getPrefix($rule) . '_' . $system;
+                $identifier = $this->tool.'_'.$this->getPrefix($rule).'_'.$system;
                 $failureMessages[$identifier]['message'] = '';
                 $failureMessages[$identifier]['system'] = $system;
                 $failureMessages[$identifier]['tool'] = $this->getPrefix($rule);
@@ -140,22 +140,22 @@ 
                         $system = $this->retriever->getSystem(($result->getUrl()));
                     }
 
-                    $identifer = $this->tool . '_' . $this->getPrefix($ruleLKey) . '_' . $system;
+                    $identifer = $this->tool.'_'.$this->getPrefix($ruleLKey).'_'.$system;
 
                     if ($failureMessages[$identifer]['message'] === '') {
-                        $failureMessages[$identifer]['message'] = 'The ' . $this->getPrefix($ruleLKey) . ' test for ' . $system . ' failed.<ul>';
+                        $failureMessages[$identifer]['message'] = 'The '.$this->getPrefix($ruleLKey).' test for '.$system.' failed.<ul>';
                     }
                     ++$counter[$identifer];
-                    $failureMessages[$identifer]['message'] .= '<li>' . $message . '<br>url: ' . $result->getUrl() . ', coming from: ' . $this->retriever->getComingFrom($result->getUrl()) . '</li>';
+                    $failureMessages[$identifer]['message'] .= '<li>'.$message.'<br>url: '.$result->getUrl().', coming from: '.$this->retriever->getComingFrom($result->getUrl()).'</li>';
                 }
             }
         }
 
         foreach ($failureMessages as $key => $failureMessage) {
             if ($failureMessage['message'] !== '') {
-                $this->send($this->identifier . '_' . $key, $failureMessage['system'], $failureMessage['message'] . '</ul>', self::STATUS_FAILURE, '', $counter[$key], $failureMessage['tool']);
+                $this->send($this->identifier.'_'.$key, $failureMessage['system'], $failureMessage['message'].'</ul>', self::STATUS_FAILURE, '', $counter[$key], $failureMessage['tool']);
             } else {
-                $this->send($this->identifier . '_' . $key, $failureMessage['system'], '', self::STATUS_SUCCESS, '', 0, $failureMessage['tool']);
+                $this->send($this->identifier.'_'.$key, $failureMessage['system'], '', self::STATUS_SUCCESS, '', 0, $failureMessage['tool']);
             }
         }
     }
@@ -167,7 +167,7 @@ 
             $failedTests = array();
             if ($result->isFailure()) {
                 foreach ($result->getMessages() as $ruleLKey => $message) {
-                    $identifier = 'smoke_' . $ruleLKey . '_' . $result->getUrl();
+                    $identifier = 'smoke_'.$ruleLKey.'_'.$result->getUrl();
 
                     if ($this->system === '') {
                         $system = str_replace('http://', '', $result->getUrl());
@@ -180,7 +180,7 @@ 
             }
             foreach ($rules as $rule) {
                 if (!in_array($rule, $failedTests, true)) {
-                    $identifier = 'smoke_' . $rule . '_' . $result->getUrl();
+                    $identifier = 'smoke_'.$rule.'_'.$result->getUrl();
 
                     if ($this->systemUseRetriever) {
                         $system = $this->retriever->getSystem($result->getUrl());
@@ -189,7 +189,7 @@ 
                     } else {
                         $system = $this->system;
                     }
-                    $this->send($identifier, $system, 'smoke_' . $rule . '_' . $result->getUrl(), self::STATUS_SUCCESS, (string) $result->getUrl());
+                    $this->send($identifier, $system, 'smoke_'.$rule.'_'.$result->getUrl(), self::STATUS_SUCCESS, (string) $result->getUrl());
                 }
             }
         }
@@ -213,16 +213,16 @@ 
                         $system = $this->retriever->getSystem(new Uri($result->getUrl()));
                     }
                     if ($failureMessages[$ruleLKey] === '') {
-                        $failureMessages[$ruleLKey]['message'] = '    The smoke test for ' . $system . ' failed (Rule: ' . $ruleLKey . ').<ul>';
+                        $failureMessages[$ruleLKey]['message'] = '    The smoke test for '.$system.' failed (Rule: '.$ruleLKey.').<ul>';
                     }
                     ++$counter[$ruleLKey];
 
                     $comingFrom = '';
                     if ($this->retriever->getComingFrom($result->getUrl())) {
-                        $comingFrom = ', coming from: ' . $this->retriever->getComingFrom($result->getUrl());
+                        $comingFrom = ', coming from: '.$this->retriever->getComingFrom($result->getUrl());
                     }
 
-                    $failureMessages[$ruleLKey]['message'] .= '<li>' . $message . ' (url: ' . $result->getUrl() . $comingFrom . ')</li > ';
+                    $failureMessages[$ruleLKey]['message'] .= '<li>'.$message.' (url: '.$result->getUrl().$comingFrom.')</li > ';
                     $failureMessages[$ruleLKey]['system'] = $system;
                 }
             }
@@ -230,9 +230,9 @@ 
 
         foreach ($failureMessages as $key => $failureMessage) {
             if ($failureMessage !== '') {
-                $this->send($this->identifier . '_' . $key, $this->system, $failureMessage['message'] . ' </ul > ', self::STATUS_FAILURE, '', $counter[$key]);
+                $this->send($this->identifier.'_'.$key, $this->system, $failureMessage['message'].' </ul > ', self::STATUS_FAILURE, '', $counter[$key]);
             } else {
-                $this->send($this->identifier . '_' . $key, $this->system, '', self::STATUS_SUCCESS, '', 0);
+                $this->send($this->identifier.'_'.$key, $this->system, '', self::STATUS_SUCCESS, '', 0);
             }
         }
     }

src/Rules/Html/RegExExistsRule.php

Doc Comments -1 removed lines

@@ -15,7 +15,6 @@
     protected $contentTypes = array('text/html');
 
     /**
-     * @param int $string The string that the document must contain
      */
     public function init(array $regExs)
     {

Spacing +2 added lines, -2 removed lines

@@ -25,8 +25,8 @@
     protected function doValidation(Response $response)
     {
         foreach ($this->regExs as $regEx) {
-            $this->assert(preg_match('^' . $regEx . '^', (string) $response->getBody()) > 0,
-                'The given regular expression (' . $regEx . ') was not found in this document.');
+            $this->assert(preg_match('^'.$regEx.'^', (string) $response->getBody()) > 0,
+                'The given regular expression ('.$regEx.') was not found in this document.');
         }
     }
 }

src/Yaml/EnvAwareYaml.php

Spacing +2 added lines, -2 removed lines

@@ -11,10 +11,10 @@
         preg_match_all('^\${(.*)}^', $fileContent, $matches);
         foreach ($matches[1] as $varName) {
             if (!getenv($varName)) {
-                throw new \RuntimeException('The mandatory env variable (' . $varName . ') from the config file was not set.');
+                throw new \RuntimeException('The mandatory env variable ('.$varName.') from the config file was not set.');
             }
 
-            $fileContent = str_replace('${' . $varName . '}', getenv($varName), $fileContent);
+            $fileContent = str_replace('${'.$varName.'}', getenv($varName), $fileContent);
         }
 
         return Yaml::parse($fileContent);

src/Rules/Seo/RobotsDisallowAllRule.php

Spacing +4 added lines, -4 removed lines

@@ -13,12 +13,12 @@ 
 {
     public function validate(Response $response)
     {
-        $url = $response->getUri()->getScheme() . '://' . $response->getUri()->getHost();
+        $url = $response->getUri()->getScheme().'://'.$response->getUri()->getHost();
 
         if (substr_count($url, '/') === 2) {
-            $filename = $robotsUrl = $url . '/robots.txt';
+            $filename = $robotsUrl = $url.'/robots.txt';
         } elseif (substr_count($url, '/') === 3) {
-            $filename = $robotsUrl = $url . 'robots.txt';
+            $filename = $robotsUrl = $url.'robots.txt';
         } else {
             return;
         }
@@ -29,7 +29,7 @@ 
             $content = file_get_contents($filename);
             $normalizedContent = str_replace(' ', '', $content);
 
-            if (strpos($normalizedContent, 'Disallow:/' . PHP_EOL) !== false) {
+            if (strpos($normalizedContent, 'Disallow:/'.PHP_EOL) !== false) {
                 throw new ValidationFailedException('The robots.txt contains disallow all (Disallow: /)');
             }
         }

src/Rules/Js/SyntaxRule.php

Spacing +5 added lines, -5 removed lines

@@ -30,18 +30,18 @@
             return;
         }
 
-        $filename = $this->tmpDir . DIRECTORY_SEPARATOR . md5($response->getBody()) . '.js';
+        $filename = $this->tmpDir.DIRECTORY_SEPARATOR.md5($response->getBody()).'.js';
         file_put_contents($filename, $response->getBody());
-        $conf = __DIR__ . DIRECTORY_SEPARATOR . 'jsHint.conf';
+        $conf = __DIR__.DIRECTORY_SEPARATOR.'jsHint.conf';
 
-        $command = $this->jsHintExecutable . ' --config ' . $conf . ' --verbose ' . $filename . ' | grep -E E[0-9]+.$';
+        $command = $this->jsHintExecutable.' --config '.$conf.' --verbose '.$filename.' | grep -E E[0-9]+.$';
         $validationResult = shell_exec($command);
 
         unlink($filename);
 
         if (!is_null($validationResult)) {
-            $errorMsg = str_replace($filename . ':', '', $validationResult);
-            throw new ValidationFailedException('JavaScript error found: ' . $errorMsg);
+            $errorMsg = str_replace($filename.':', '', $validationResult);
+            throw new ValidationFailedException('JavaScript error found: '.$errorMsg);
         }
     }
 }

src/Rules/Http/DurationRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     public function validate(Response $response)
     {
         if ($response->getDuration() > $this->maxDuration) {
-            throw new ValidationFailedException('the http request lasted ' . $response->getDuration() . ' milliseconds.');
+            throw new ValidationFailedException('the http request lasted '.$response->getDuration().' milliseconds.');
         }
     }
 }

src/Rules/Http/Header/ExistsRule.php

Spacing +2 added lines, -2 removed lines

@@ -22,13 +22,13 @@
     {
         foreach ($this->checkedHeaders as $headerConfig) {
             if (!$response->hasHeader($headerConfig['key'])) {
-                throw new ValidationFailedException('Header not found (' . $headerConfig['key'] . ')');
+                throw new ValidationFailedException('Header not found ('.$headerConfig['key'].')');
             }
 
             $currentValue = $response->getHeader($headerConfig['key'])[0];
 
             if ($currentValue !== $headerConfig['value']) {
-                throw new ValidationFailedException('Header "' . $headerConfig['key'] . '" does not equal "' . $headerConfig['value'] . '". Current value is "' . $currentValue . '"');
+                throw new ValidationFailedException('Header "'.$headerConfig['key'].'" does not equal "'.$headerConfig['value'].'". Current value is "'.$currentValue.'"');
             }
         }
     }