phmLabs / Smoke

src/Http/Response.php

Doc Comments +3 added lines

@@ -13,6 +13,9 @@
         return $this->getStatusCode();
     }
 
+    /**
+     * @return string
+     */
     public function getContentType()
     {
         $exploded = explode(';', $this->hasHeader('Content-Type') ? $this->getHeader('Content-Type')[0] : null);

src/Rules/Html/RegExExistsRule.php

Doc Comments -1 removed lines

@@ -15,7 +15,6 @@
     protected $contentTypes = array('text/html');
 
     /**
-     * @param int $string The string that the document must contain
      */
     public function init(array $regExs)
     {

Spacing +5 added lines, -5 removed lines

@@ -29,12 +29,12 @@ 
 
         foreach ($this->regExs as $regEx) {
             if ($regEx['isRegEx']) {
-                if (preg_match('^' . $regEx['pattern'] . '^', (string) $response->getBody()) === 0) {
-                    $errors[] = 'Regular expression: ' . $regEx['pattern'];
+                if (preg_match('^'.$regEx['pattern'].'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Regular expression: '.$regEx['pattern'];
                 }
             } else {
-                if (preg_match('^' . preg_quote($regEx['pattern']) . '^', (string) $response->getBody()) === 0) {
-                    $errors[] = 'Text: ' . $regEx['pattern'];
+                if (preg_match('^'.preg_quote($regEx['pattern']).'^', (string) $response->getBody()) === 0) {
+                    $errors[] = 'Text: '.$regEx['pattern'];
                 }
             }
         }
@@ -43,7 +43,7 @@ 
             $errorString = 'The following text elements were not found: <ul>';
 
             foreach ($errors as $error) {
-                $errorString .= '<li>' . $error . '</li>';
+                $errorString .= '<li>'.$error.'</li>';
             }
 
             $errorString .= '</ul>';

src/Rules/Js/SyntaxRule.php

Spacing +5 added lines, -5 removed lines

@@ -30,18 +30,18 @@
             return;
         }
 
-        $filename = $this->tmpDir . DIRECTORY_SEPARATOR . md5($response->getBody()) . '.js';
+        $filename = $this->tmpDir.DIRECTORY_SEPARATOR.md5($response->getBody()).'.js';
         file_put_contents($filename, $response->getBody());
-        $conf = __DIR__ . DIRECTORY_SEPARATOR . 'jsHint.conf';
+        $conf = __DIR__.DIRECTORY_SEPARATOR.'jsHint.conf';
 
-        $command = $this->jsHintExecutable . ' --config ' . $conf . ' --verbose ' . $filename . ' | grep -E E[0-9]+.$';
+        $command = $this->jsHintExecutable.' --config '.$conf.' --verbose '.$filename.' | grep -E E[0-9]+.$';
         $validationResult = shell_exec($command);
 
         unlink($filename);
 
         if (!is_null($validationResult)) {
-            $errorMsg = str_replace($filename . ':', '', $validationResult);
-            throw new ValidationFailedException('JavaScript error found: ' . $errorMsg);
+            $errorMsg = str_replace($filename.':', '', $validationResult);
+            throw new ValidationFailedException('JavaScript error found: '.$errorMsg);
         }
     }
 }

src/Rules/Http/Header/SuccessStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
     public function validate(Response $response)
     {
         if ($response->getStatus() > $this->maxStatusCode) {
-            throw new ValidationFailedException('Status code ' . $response->getStatus() . ' found.');
+            throw new ValidationFailedException('Status code '.$response->getStatus().' found.');
         }
     }
 }

src/Rules/Http/Header/HttpStatusRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
     public function validate(Response $response)
     {
         if ($response->getStatus() !== $this->expectedStatus) {
-            throw new ValidationFailedException('Status code ' . $response->getStatus() . ' found, ' . $this->expectedStatus . ' expected.');
+            throw new ValidationFailedException('Status code '.$response->getStatus().' found, '.$this->expectedStatus.' expected.');
         }
     }
 }

src/Rules/Html/SizeRule.php

Spacing +1 added lines, -1 removed lines

@@ -26,6 +26,6 @@
     protected function doValidation(Response $response)
     {
         $size = strlen($response->getBody()) / 1000;
-        $this->assert($size <= $this->maxSize, 'The size of this html file is too big (' . $size . ' KB)');
+        $this->assert($size <= $this->maxSize, 'The size of this html file is too big ('.$size.' KB)');
     }
 }

src/Rules/Html/ForeignDomainImageRule.php

Spacing +1 added lines, -1 removed lines

@@ -41,6 +41,6 @@
             }
         }
 
-        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found (' . implode(', ', $foreignImages) . ')');
+        $this->assert(count($foreignImages) === 0, 'Images from a foreign domain where found ('.implode(', ', $foreignImages).')');
     }
 }

src/Rules/Html/InsecureContentRule.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
         foreach ($resources as $resource) {
             if ($resource->getScheme() && 'https' !== $resource->getScheme()) {
-                throw new ValidationFailedException('At least one dependency was found on a secure url, that was transfered insecure (' . (string) $resource . ')');
+                throw new ValidationFailedException('At least one dependency was found on a secure url, that was transfered insecure ('.(string) $resource.')');
             }
         }
     }

src/Rules/Html/StringNotExistsRule.php

Spacing +1 added lines, -1 removed lines

@@ -25,6 +25,6 @@
     public function doValidation(Response $response)
     {
         $this->assert(strpos($response->getBody(), $this->string) !== false,
-            'The given string (' . $this->string . ') was found in this document.');
+            'The given string ('.$this->string.') was found in this document.');
     }
 }