phmLabs / Smoke

src/Scanner/Scanner.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 
             $results = $this->checkResponse($response);
 
-            if(count($results) == 0) {
+            if (count($results) == 0) {
                 $checkResult = new CheckResult(CheckResult::STATUS_NONE, '');
                 $checkResult->setResponse($response);
                 $results = [$checkResult];

src/Extensions/SmokeReporter/Reporter/WarmUpLiveReporter.php

Spacing +2 added lines, -2 removed lines

@@ -22,14 +22,14 @@
         if (count($results) > 0) {
             ++$this->urlCount;
             $firstResult = array_pop($results);
-            $this->output->writeln('   ' . (string)$firstResult->getResponse()->getUri());
+            $this->output->writeln('   '.(string) $firstResult->getResponse()->getUri());
             $this->output->writeln('');
         }
     }
 
     public function finish()
     {
-        $this->output->writeln('   <comment>Warm up finished. ' . $this->urlCount . ' urls visited.</comment>');
+        $this->output->writeln('   <comment>Warm up finished. '.$this->urlCount.' urls visited.</comment>');
         $this->output->writeln('');
     }
 }

src/Extensions/SmokeResponseRetriever/Retriever/Koalamon/Retriever.php

Doc Comments +5 added lines

@@ -43,6 +43,11 @@
         return json_decode($systems->getBody(), true);
     }
 
+    /**
+     * @param string $url
+     *
+     * @return string
+     */
     private function prepareUrl($url)
     {
         $preparedUrl = str_replace('#project#', $this->project, $url);

src/Rules/Json/JsonPathExistsRule.php

Spacing +3 added lines, -3 removed lines

@@ -73,17 +73,17 @@
 
             if ($jsonValue === false || (is_array($jsonValue) && empty($jsonValue))) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (JSON Path not found)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (JSON Path not found)';
             }
             if ($this->checkRelation($path['relation'], $path['value'], $count) === false) {
                 $error = true;
-                $noCorrectJsonPaths[] = $path['pattern'] . ' (number of JSONPaths is not correct corresponding to the given relation/value)';
+                $noCorrectJsonPaths[] = $path['pattern'].' (number of JSONPaths is not correct corresponding to the given relation/value)';
             }
         }
 
         if ($error === true) {
             $allNoCorrectJsonPaths = implode('", "', $noCorrectJsonPaths);
-            throw new ValidationFailedException('Disonances with JSON Paths "' . $allNoCorrectJsonPaths . '!');
+            throw new ValidationFailedException('Disonances with JSON Paths "'.$allNoCorrectJsonPaths.'!');
         }
     }
 }

src/Rules/Html/XPathExistsRule.php

Spacing +4 added lines, -4 removed lines

@@ -31,15 +31,15 @@
 
             if ($xpath['relation'] === 'equals') {
                 $result = $count === (int) $xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were exact ' . $xpath['value'] . ' occurencies.';
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were exact '.$xpath['value'].' occurencies.';
             } elseif ($xpath['relation'] === 'less than') {
                 $result = $count < (int) $xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were less than ' . $xpath['value'] . '.';
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were less than '.$xpath['value'].'.';
             } elseif ($xpath['relation'] === 'greater than') {
                 $result = $count > (int) $xpath['value'];
-                $message = 'The xpath "' . $xpath['pattern'] . '" was found ' . $count . ' times. Expected were more than ' . $xpath['value'] . '.';
+                $message = 'The xpath "'.$xpath['pattern'].'" was found '.$count.' times. Expected were more than '.$xpath['value'].'.';
             } else {
-                throw new \RuntimeException('Relation not defined. Given "' . $xpath['relation'] . '" expected [equals, greater than, less than]');
+                throw new \RuntimeException('Relation not defined. Given "'.$xpath['relation'].'" expected [equals, greater than, less than]');
             }
 
             $this->assert($result, $message);

src/Rules/Seo/GoogleMobileFriendlyRule.php

Spacing +4 added lines, -4 removed lines

@@ -15,7 +15,7 @@ 
     private function getEndpoint(Uri $uri)
     {
         // return str_replace('#url#', urlencode('https://webhook.koalamon.com'), self::ENDPOINT);
-        return str_replace('#url#', urlencode((string)$uri), self::ENDPOINT);
+        return str_replace('#url#', urlencode((string) $uri), self::ENDPOINT);
     }
 
     public function validate(Response $response)
@@ -34,15 +34,15 @@ 
             )));
 
         if (property_exists($result, 'error')) {
-            throw new ValidationFailedException('Google mobile friendly test was not passed. Error "' . $result->error->message . '"');
+            throw new ValidationFailedException('Google mobile friendly test was not passed. Error "'.$result->error->message.'"');
         }
 
         $passResult = $result->ruleGroups->USABILITY;
 
         if (!$passResult->pass) {
-            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+            return new CheckResult(CheckResult::STATUS_FAILURE, 'Google mobile friendly test was not passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
         }
 
-        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score ' . $passResult->score . '/100.', (int)$passResult->score);
+        return new CheckResult(CheckResult::STATUS_SUCCESS, 'Google mobile friendly test passed. Score '.$passResult->score.'/100.', (int) $passResult->score);
     }
 }

src/Rules/Http/HttpsCertificateAuthorityRule.php

Spacing +2 added lines, -2 removed lines

@@ -23,10 +23,10 @@
     {
         if (array_key_exists('issuer', $certInfo) and array_key_exists('CN', $certInfo['issuer'])) {
             if ($certInfo['issuer']['CN'] !== $this->authorityName) {
-                throw new ValidationFailedException('Expected authority was "' . $this->authorityName . '", "' . $certInfo['issuer']['CN'] . '" found.');
+                throw new ValidationFailedException('Expected authority was "'.$this->authorityName.'", "'.$certInfo['issuer']['CN'].'" found.');
             }
         } else {
-            throw new ValidationFailedException('Expected authority was "' . $this->authorityName . '". No authority found.');
+            throw new ValidationFailedException('Expected authority was "'.$this->authorityName.'". No authority found.');
         }
     }
 }

src/Yaml/EnvAwareYaml.php

Spacing +2 added lines, -2 removed lines

@@ -12,10 +12,10 @@
 
         foreach ($matches[1] as $varName) {
             if (!getenv($varName)) {
-                throw new \RuntimeException('The mandatory env variable (' . $varName . ') from the config file was not set.');
+                throw new \RuntimeException('The mandatory env variable ('.$varName.') from the config file was not set.');
             }
 
-            $fileContent = str_replace('${' . $varName . '}', getenv($varName), $fileContent);
+            $fileContent = str_replace('${'.$varName.'}', getenv($varName), $fileContent);
         }
 
         return Yaml::parse($fileContent);

src/Rules/Http/DurationRule.php

Spacing +2 added lines, -2 removed lines

@@ -27,13 +27,13 @@
         if ($response->getDuration() > $this->maxDuration) {
             return new CheckResult(
                 CheckResult::STATUS_FAILURE,
-                'The http request took ' . (int) $response->getDuration() . ' milliseconds (limit was ' . $this->maxDuration . 'ms).',
+                'The http request took '.(int) $response->getDuration().' milliseconds (limit was '.$this->maxDuration.'ms).',
                 (int) $response->getDuration());
         }
 
         return new CheckResult(
             CheckResult::STATUS_SUCCESS,
-            'The http request took ' . (int) $response->getDuration() . ' milliseconds.',
+            'The http request took '.(int) $response->getDuration().' milliseconds.',
             (int) $response->getDuration());
     }
 }