Test Setup Failed
Pull Request — master (#623)
by Alejandro Carstens
13:00
created
app/Services/Musixmatch.php 4 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     }
37 37
     
38 38
     /**
39
-     * @param App\Models\Song $song
39
+     * @param Song $song
40 40
      * 
41 41
      * @return mixed|null
42 42
      */
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
      * @param string $name
61 61
      * @param string $artistName
62 62
      * 
63
-     * @return mixed|false
63
+     * @return false|string
64 64
      */
65 65
     public function search(string $name, string $artistName = null)
66 66
     {
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
     /**
99 99
      * @param JSON $response
100 100
      * 
101
-     * @return string|null
101
+     * @return string|false
102 102
      */
103 103
     private function getLyrics($response)
104 104
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace App\Services;
4 4
 
5 5
 use App\Models\Song;
6
-use Cache;
7 6
 use GuzzleHttp\Client;
8 7
 use Log;
9 8
 
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
      */
43 43
     public function searchLyricsRelatedToSong(Song $song)
44 44
     {
45
-        if($song->hasLyrics() == false)
45
+        if ($song->hasLyrics() == false)
46 46
         {
47 47
             if (!$song->artist->isUnknown() && !$song->artist->isVarious()) {
48 48
                 $lyrics = $this->search($song->title, $song->artist->name);
@@ -74,11 +74,11 @@  discard block
 block discarded – undo
74 74
             $this->key
75 75
         );
76 76
         
77
-        try{
77
+        try {
78 78
             $response = $this->jsonpDecode($this->get($uri));
79 79
             
80 80
             return $this->getLyrics($response);
81
-        }catch(\Exception $e){
81
+        } catch (\Exception $e) {
82 82
             Log::error($e);
83 83
 
84 84
             return false;
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
      */
93 93
     private function jsonpDecode($response)
94 94
     {
95
-        return json_decode(substr(preg_replace("/[^(]*\((.*)\)/","$1",$response), 0, -1));
95
+        return json_decode(substr(preg_replace("/[^(]*\((.*)\)/", "$1", $response), 0, -1));
96 96
     }
97 97
     
98 98
     /**
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     {
105 105
         $lyrics = $response->message->body->lyrics->lyrics_body;
106 106
         
107
-        if(strlen($lyrics))
107
+        if (strlen($lyrics))
108 108
         {
109 109
             // Correct Musixmatch spelling mistake (is for are).
110 110
             return substr($lyrics, 0, strpos($lyrics, "******* This Lyrics is NOT for Commercial use *******")).
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
             $response = $this->jsonpDecode($this->get($uri));
79 79
             
80 80
             return $this->getLyrics($response);
81
-        }catch(\Exception $e){
81
+        } catch(\Exception $e){
82 82
             Log::error($e);
83 83
 
84 84
             return false;
Please login to merge, or discard this patch.