App\Console\Commands\Traits\AskForPassword::askForPassword()

Complexity

Conditions	3
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

<?php
    private function askForPassword(): string
    {
        do {
            $password = $this->secret('Your desired password');

It seems like secret() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if (!$password) {
                $this->error('Passwords cannot be empty. You know that.');

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                continue;
            }

            $confirmedPassword = $this->secret('Again, just to be sure');
        } while (!$this->comparePasswords($password, $confirmedPassword ?? null));

        return $password;
    }