App\Console\Commands\Traits\AskForPassword

Complexity

Total Complexity

7

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	askForPassword()	0	14	3
A	comparePasswords()	0	13	4

<?php

namespace App\Console\Commands\Traits;

trait AskForPassword
{
    private function askForPassword(): string
    {
        do {
            $password = $this->secret('Your desired password');

It seems like secret() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if (!$password) {
                $this->error('Passwords cannot be empty. You know that.');

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                continue;
            }

            $confirmedPassword = $this->secret('Again, just to be sure');
        } while (!$this->comparePasswords($password, $confirmedPassword ?? null));

        return $password;
    }

    private function comparePasswords(?string $password, ?string $confirmedPassword): bool
    {
        if (!$password || !$confirmedPassword) {
            return false;
        }

        if (strcmp($password, $confirmedPassword) !== 0) {
            $this->error('The passwords do not match. Try again maybe?');

            return false;
        }

        return true;
    }
}