pgaultier / yii2-oauth2

src/controllers/AuthorizeController.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 
 use OAuth2\Request as OAuth2Request;
 use OAuth2\Response as OAuth2Response;
-use sweelix\oauth2\server\models\Client;
 use sweelix\oauth2\server\models\Scope;
 use sweelix\oauth2\server\Module;
 use yii\web\Controller;

Spacing +1 added lines, -1 removed lines

@@ -118,7 +118,7 @@
         $requestedScopes = [];
         if (empty($additionalScopes) === false) {
             $additionalScopes = explode(' ', $additionalScopes);
-            foreach($additionalScopes as $scope) {
+            foreach ($additionalScopes as $scope) {
                 $dbScope = Scope::findOne($scope);
                 if ($dbScope !== null) {
                     $requestedScopes[] = [

src/models/BaseModel.php

Doc Comments +2 added lines, -2 removed lines

@@ -129,7 +129,7 @@ 
 
     /**
      * Returns the old key value of the object
-     * @return mixed|null
+     * @return string
      * @since XXX
      */
     public function getOldKey()
@@ -217,7 +217,7 @@ 
      * If this record is the result of a query and the attribute is not loaded,
      * null will be returned.
      * @param string $name the attribute name
-     * @return mixed the old attribute value. Null if the attribute is not loaded before
+     * @return string the old attribute value. Null if the attribute is not loaded before
      * or does not exist.
      * @see hasAttribute()
      */

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use yii\base\InvalidParamException;
 use yii\base\Model;
 use yii\base\ModelEvent;
-use Yii;
 use Exception;
 use yii\base\NotSupportedException;
 use yii\helpers\Inflector;

Spacing +4 added lines, -4 removed lines

@@ -171,7 +171,7 @@ 
         if ($this->hasAttribute($name)) {
             $this->_attributes[$name] = $value;
         } else {
-            throw new InvalidParamException(get_class($this) . ' has no attribute named "' . $name . '".');
+            throw new InvalidParamException(get_class($this).' has no attribute named "'.$name.'".');
         }
     }
 
@@ -208,7 +208,7 @@ 
         if (isset($this->_oldAttributes[$name]) || $this->hasAttribute($name)) {
             $this->_oldAttributes[$name] = $value;
         } else {
-            throw new InvalidParamException(get_class($this) . ' has no attribute named "' . $name . '".');
+            throw new InvalidParamException(get_class($this).' has no attribute named "'.$name.'".');
         }
     }
 
@@ -382,10 +382,10 @@ 
      * If not set, [[formName()]] will be used.
      * @return boolean whether the model is successfully populated with some data.
      */
-    public function loadIds($data, $formName=null)
+    public function loadIds($data, $formName = null)
     {
         $camelData = [];
-        foreach($data as $key => $value) {
+        foreach ($data as $key => $value) {
             $key = lcfirst(Inflector::id2camel($key));
             $camelData[$key] = $value;
         }

src/services/Oauth.php

Doc Comments +1 added lines

@@ -85,6 +85,7 @@
 
     /**
      * @param mixed $config
+     * @param \yii\base\Module|null $module
      * @return array Oauth server configuration
      * @since XXX
      */

src/services/redis/BaseService.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 namespace sweelix\oauth2\server\services\redis;
 
 use sweelix\oauth2\server\interfaces\BaseModelInterface;
-use sweelix\oauth2\server\models\BaseModel;
 use sweelix\oauth2\server\traits\redis\TypeConverter;
 use yii\base\Object;
 use yii\helpers\Json;

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
     protected function encodeAttributes(Array $attributes)
     {
         $data = Json::encode($attributes);
-        $etag = '"' . rtrim(base64_encode(sha1($data, true)), '=') . '"';
+        $etag = '"'.rtrim(base64_encode(sha1($data, true)), '=').'"';
         return $etag;
     }
 

src/services/redis/JtiService.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use sweelix\oauth2\server\interfaces\JtiServiceInterface;
 use yii\db\Exception as DatabaseException;
 use Yii;
-use Exception;
 
 /**
  * This is the jti service for redis

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
      */
     protected function getJtiKey($jid)
     {
-        return $this->namespace . ':' . $jid;
+        return $this->namespace.':'.$jid;
     }
 
     /**

src/services/redis/JwtService.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use sweelix\oauth2\server\interfaces\JwtServiceInterface;
 use yii\db\Exception as DatabaseException;
 use Yii;
-use Exception;
 
 /**
  * This is the jwt service for redis

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
      */
     protected function getJwtKey($jid)
     {
-        return $this->namespace . ':' . $jid;
+        return $this->namespace.':'.$jid;
     }
 
     /**

src/commands/ClientController.php

Spacing +5 added lines, -5 removed lines

@@ -73,10 +73,10 @@ 
         $client->grantTypes = empty($this->grantTypes) ? null : explode(',', $this->grantTypes);
         if ($client->save() === true) {
             $this->stdout('Client created :'."\n");
-            $this->stdout(' - id: ' . $client->id . "\n");
-            $this->stdout(' - secret: ' . $client->secret . "\n");
-            $this->stdout(' - name: ' . $client->name . "\n");
-            $this->stdout(' - redirectUri: ' . $client->redirectUri . "\n");
+            $this->stdout(' - id: '.$client->id."\n");
+            $this->stdout(' - secret: '.$client->secret."\n");
+            $this->stdout(' - name: '.$client->name."\n");
+            $this->stdout(' - redirectUri: '.$client->redirectUri."\n");
         } else {
             $this->stdout('Client cannot be created.'."\n");
         }
@@ -90,7 +90,7 @@ 
      */
     protected function getRandomString($length = 40)
     {
-        $bytes = (int) $length/2;
+        $bytes = (int)$length/2;
         return bin2hex(openssl_random_pseudo_bytes($bytes));
     }
 }
\ No newline at end of file

src/commands/KeyController.php

Spacing +2 added lines, -2 removed lines

@@ -82,8 +82,8 @@
         }
         if ($cypherKey->save() === true) {
             $this->stdout('Key created :'."\n");
-            $this->stdout(' - id: ' . $cypherKey->id . "\n");
-            $this->stdout(' - Algorithm: ' . $cypherKey->encryptionAlgorithm . "\n");
+            $this->stdout(' - id: '.$cypherKey->id."\n");
+            $this->stdout(' - Algorithm: '.$cypherKey->encryptionAlgorithm."\n");
         } else {
             $this->stdout('Key cannot be created.'."\n");
         }

src/commands/ScopeController.php

Spacing +3 added lines, -3 removed lines

@@ -60,9 +60,9 @@
         $scope->definition = $this->definition;
         if ($scope->save() === true) {
             $this->stdout('Scope created :'."\n");
-            $this->stdout(' - id: ' . $scope->id . "\n");
-            $this->stdout(' - isDefault: ' . ($scope->isDefault ? 'Yes' : 'No') . "\n");
-            $this->stdout(' - definition: ' . $scope->definition . "\n");
+            $this->stdout(' - id: '.$scope->id."\n");
+            $this->stdout(' - isDefault: '.($scope->isDefault ? 'Yes' : 'No')."\n");
+            $this->stdout(' - definition: '.$scope->definition."\n");
         } else {
             $this->stdout('Scope cannot be created.'."\n");
         }