pgaultier / yii2-oauth2

src/models/BaseModel.php

Unused Use Statements -1 removed lines

@@ -18,7 +18,6 @@
 use yii\base\InvalidParamException;
 use yii\base\Model;
 use yii\base\ModelEvent;
-use Yii;
 use Exception;
 use yii\base\NotSupportedException;
 use yii\helpers\Inflector;

Spacing +4 added lines, -4 removed lines

@@ -171,7 +171,7 @@ 
         if ($this->hasAttribute($name)) {
             $this->_attributes[$name] = $value;
         } else {
-            throw new InvalidParamException(get_class($this) . ' has no attribute named "' . $name . '".');
+            throw new InvalidParamException(get_class($this).' has no attribute named "'.$name.'".');
         }
     }
 
@@ -208,7 +208,7 @@ 
         if (isset($this->_oldAttributes[$name]) || $this->hasAttribute($name)) {
             $this->_oldAttributes[$name] = $value;
         } else {
-            throw new InvalidParamException(get_class($this) . ' has no attribute named "' . $name . '".');
+            throw new InvalidParamException(get_class($this).' has no attribute named "'.$name.'".');
         }
     }
 
@@ -382,10 +382,10 @@ 
      * If not set, [[formName()]] will be used.
      * @return boolean whether the model is successfully populated with some data.
      */
-    public function loadIds($data, $formName=null)
+    public function loadIds($data, $formName = null)
     {
         $camelData = [];
-        foreach($data as $key => $value) {
+        foreach ($data as $key => $value) {
             $key = lcfirst(Inflector::id2camel($key));
             $camelData[$key] = $value;
         }

Doc Comments +2 added lines, -2 removed lines

@@ -118,7 +118,7 @@ 
 
     /**
      * Returns the key value of the object
-     * @return mixed|null
+     * @return string
      * @since XXX
      */
     public function getKey()
@@ -129,7 +129,7 @@ 
 
     /**
      * Returns the old key value of the object
-     * @return mixed|null
+     * @return string
      * @since XXX
      */
     public function getOldKey()

src/services/Oauth.php

Doc Comments +1 added lines

@@ -85,6 +85,7 @@
 
     /**
      * @param mixed $config
+     * @param \yii\base\Module|null $module
      * @return array Oauth server configuration
      * @since XXX
      */

src/services/redis/JwtService.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use sweelix\oauth2\server\interfaces\JwtServiceInterface;
 use yii\db\Exception as DatabaseException;
 use Yii;
-use Exception;
 
 /**
  * This is the jwt service for redis

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
      */
     protected function getJwtKey($jid)
     {
-        return $this->namespace . ':' . $jid;
+        return $this->namespace.':'.$jid;
     }
 
     /**

src/commands/KeyController.php

Spacing +2 added lines, -2 removed lines

@@ -82,8 +82,8 @@
         }
         if ($cypherKey->save() === true) {
             $this->stdout('Key created :'."\n");
-            $this->stdout(' - id: ' . $cypherKey->id . "\n");
-            $this->stdout(' - Algorithm: ' . $cypherKey->encryptionAlgorithm . "\n");
+            $this->stdout(' - id: '.$cypherKey->id."\n");
+            $this->stdout(' - Algorithm: '.$cypherKey->encryptionAlgorithm."\n");
         } else {
             $this->stdout('Key cannot be created.'."\n");
         }

src/commands/ScopeController.php

Spacing +3 added lines, -3 removed lines

@@ -60,9 +60,9 @@
         $scope->definition = $this->definition;
         if ($scope->save() === true) {
             $this->stdout('Scope created :'."\n");
-            $this->stdout(' - id: ' . $scope->id . "\n");
-            $this->stdout(' - isDefault: ' . ($scope->isDefault ? 'Yes' : 'No') . "\n");
-            $this->stdout(' - definition: ' . $scope->definition . "\n");
+            $this->stdout(' - id: '.$scope->id."\n");
+            $this->stdout(' - isDefault: '.($scope->isDefault ? 'Yes' : 'No')."\n");
+            $this->stdout(' - definition: '.$scope->definition."\n");
         } else {
             $this->stdout('Scope cannot be created.'."\n");
         }

src/controllers/TokenController.php

Spacing +1 added lines, -1 removed lines

@@ -124,7 +124,7 @@
             $response->content = $oauthResponse->getResponseBody('xml');
         }
         $headers = $oauthResponse->getHttpHeaders();
-        foreach($headers as $name => $value)
+        foreach ($headers as $name => $value)
         {
             $response->headers->set($name, $value);
         }

src/traits/redis/TypeConverter.php

Spacing +4 added lines, -4 removed lines

@@ -56,7 +56,7 @@ 
         if ((isset($this->attributesDefinitions[$key]) === true)
             && (in_array($this->attributesDefinitions[$key], $bypassTypes) === false)
         ) {
-            switch($this->attributesDefinitions[$key]) {
+            switch ($this->attributesDefinitions[$key]) {
                 case 'bool':
                 case 'boolean':
                     $value = $value ? 1 : 0;
@@ -95,11 +95,11 @@ 
             switch ($this->attributesDefinitions[$key]) {
                 case 'bool':
                 case 'boolean':
-                    $value = (bool) $value;
+                    $value = (bool)$value;
                     break;
                 case 'int':
                 case 'integer':
-                    $value = (int) $value;
+                    $value = (int)$value;
                     break;
                 case 'array':
                     try {
@@ -111,7 +111,7 @@ 
                 case 'real':
                 case 'double':
                 case 'float':
-                    $value = (float) $value;
+                    $value = (float)$value;
                     break;
             }
         }

src/services/redis/BaseService.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
     protected function encodeAttributes(Array $attributes)
     {
         $data = Json::encode($attributes);
-        $etag = '"' . rtrim(base64_encode(sha1($data, true)), '=') . '"';
+        $etag = '"'.rtrim(base64_encode(sha1($data, true)), '=').'"';
         return $etag;
     }
 

Unused Use Statements -2 removed lines

@@ -15,14 +15,12 @@
 namespace sweelix\oauth2\server\services\redis;
 
 use sweelix\oauth2\server\interfaces\BaseModelInterface;
-use sweelix\oauth2\server\models\BaseModel;
 use sweelix\oauth2\server\Module;
 use sweelix\oauth2\server\traits\redis\TypeConverter;
 use yii\base\Object;
 use yii\di\Instance;
 use yii\helpers\Json;
 use yii\redis\Connection;
-use Yii;
 
 /**
  * This is the base service for redis

src/services/redis/ScopeService.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
      */
     protected function getScopeKey($sid)
     {
-        return $this->namespace . ':' . $sid;
+        return $this->namespace.':'.$sid;
     }
 
     /**
@@ -56,7 +56,7 @@ 
      */
     protected function getScopeListKey()
     {
-        return $this->namespace . ':keys';
+        return $this->namespace.':keys';
     }
 
     /**
@@ -65,7 +65,7 @@ 
      */
     protected function getScopeDefaultListKey()
     {
-        return $this->namespace . ':defaultkeys';
+        return $this->namespace.':defaultkeys';
     }
 
     /**