petkopara / PetkoparaCrudGeneratorBundle

Generator/PetkoparaCrudGenerator.php

Doc Comments +1 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
     /**
      * 
      * @param BundleInterface $bundle
-     * @param type $entity
+     * @param string $entity
      * @param ClassMetadataInfo $metadata
      * @param Configuration $config
      * @throws RuntimeException
@@ -160,7 +160,6 @@ 
 
         /**
          * Generates the controller class only.
-         * @param boolean $config->getOverwrite()
          */
         protected function generateCrudControllerClass() {
         $dir = $this->bundle->getPath();

Tests/Command/CrudCommandTest.php

Doc Comments +3 added lines

@@ -197,6 +197,9 @@
         $this->assertContains($expected, file_get_contents($rootDir . '/config/routing.yml'));
     }
 
+    /**
+     * @return \Symfony\Component\Console\Command\Command
+     */
     protected function getCommand($generator, $input)
     {
         $command = $this

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Petkopara\CrudGeneratorBundle\Configuration\Configuration;
 use Sensio\Bundle\GeneratorBundle\Tests\Command\GenerateCommandTest;
 use Symfony\Component\Console\Tester\CommandTester;
-use Symfony\Component\Filesystem\Filesystem;
 
 /*
  * This file is part of the CrudGeneratorBundle

Spacing +10 added lines, -10 removed lines

@@ -54,13 +54,13 @@ 
     {
         return array(
             array(array(), "AcmeBlogBundle:Blog/Post\nn\ninput\nbase.html.twig\nannotation\n/foobar\n\n", array('Blog\\Post', false, 'input', 'base.html.twig', 'annotation', 'foobar', false, false, false, false, false, false)),
-            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--bundle-views'=> true), '', array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', false, false, false, false, true,false)),
+            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--bundle-views'=> true), '', array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', false, false, false, false, true, false)),
             array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--template'=> 'base.html.twig', '--filter-type'=>'none'), '', array('Blog\\Post', false, 'none', 'base.html.twig', 'annotation', 'blog_post', false, false, false, false, false, false)),
-            array(array(), "AcmeBlogBundle:Blog/Post\nn\nform\nbase.html.twig\nyml\n/foobar\n\n", array('Blog\\Post', false, 'form', 'base.html.twig', 'yml', 'foobar', false, false, false, false,false, false)),
-            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--format' => 'yml', '--route-prefix' => 'foo', '--without-write' => true, '--filter-type' => 'input'), '', array('Blog\\Post', true, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'yml', 'foo', false, false, false, false,false, false)),
-            array(array('--without-show' => true, '--without-bulk' => true,), "AcmeBlogBundle:Blog/Post\nn\ninput\nbase.html.twig\nannotation\n/foobar\n\n", array('Blog\\Post', false, 'input', 'base.html.twig', 'annotation', 'foobar', true, true, false, false, false,false)),
-            array(array('--without-sorting' => true, '--without-page-size' => true, '--bundle-views'=> true), "AcmeBlogBundle:Blog/Post\nn\ninput\nbase.html.twig\nannotation\n/foobar\n\n", array('Blog\\Post', false, 'input', 'base.html.twig', 'annotation', 'foobar', false, false, true, true, true,false)),
-            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--overwrite'=> true,'--without-sorting' => true, '--without-page-size' => true, '--without-show' => true, '--without-bulk' => true,), '', array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', true, true, true, true, false, true)),
+            array(array(), "AcmeBlogBundle:Blog/Post\nn\nform\nbase.html.twig\nyml\n/foobar\n\n", array('Blog\\Post', false, 'form', 'base.html.twig', 'yml', 'foobar', false, false, false, false, false, false)),
+            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--format' => 'yml', '--route-prefix' => 'foo', '--without-write' => true, '--filter-type' => 'input'), '', array('Blog\\Post', true, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'yml', 'foo', false, false, false, false, false, false)),
+            array(array('--without-show' => true, '--without-bulk' => true,), "AcmeBlogBundle:Blog/Post\nn\ninput\nbase.html.twig\nannotation\n/foobar\n\n", array('Blog\\Post', false, 'input', 'base.html.twig', 'annotation', 'foobar', true, true, false, false, false, false)),
+            array(array('--without-sorting' => true, '--without-page-size' => true, '--bundle-views'=> true), "AcmeBlogBundle:Blog/Post\nn\ninput\nbase.html.twig\nannotation\n/foobar\n\n", array('Blog\\Post', false, 'input', 'base.html.twig', 'annotation', 'foobar', false, false, true, true, true, false)),
+            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--overwrite'=> true, '--without-sorting' => true, '--without-page-size' => true, '--without-show' => true, '--without-bulk' => true,), '', array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', true, true, true, true, false, true)),
         );
     }
 
@@ -96,10 +96,10 @@ 
     public function getNonInteractiveCommandData()
     {
         return array(
-            array(array('--entity' => 'AcmeBlogBundle:Blog/Post'),  array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', false, false, false, false,  false, false)),
-            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--filter-type'=> 'form', '--bundle-views'=> true,  '--template'=> 'base.html.twig'),  array('Blog\\Post', false, 'form', 'base.html.twig', 'annotation', 'blog_post', false, false, false, false, true, false)),
-            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--format' => 'yml', '--route-prefix' => 'foo', '--without-write' => true),  array('Blog\\Post', true, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'yml', 'foo', false, false, false, false, false, false)),
-            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--without-show' => true, '--without-bulk' => true,'--without-sorting' => true, '--without-page-size' => true),  array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', true, true, true, true,  false, false)),
+            array(array('--entity' => 'AcmeBlogBundle:Blog/Post'), array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', false, false, false, false, false, false)),
+            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--filter-type'=> 'form', '--bundle-views'=> true, '--template'=> 'base.html.twig'), array('Blog\\Post', false, 'form', 'base.html.twig', 'annotation', 'blog_post', false, false, false, false, true, false)),
+            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--format' => 'yml', '--route-prefix' => 'foo', '--without-write' => true), array('Blog\\Post', true, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'yml', 'foo', false, false, false, false, false, false)),
+            array(array('--entity' => 'AcmeBlogBundle:Blog/Post', '--without-show' => true, '--without-bulk' => true, '--without-sorting' => true, '--without-page-size' => true), array('Blog\\Post', false, 'input', 'PetkoparaCrudGeneratorBundle::base.html.twig', 'annotation', 'blog_post', true, true, true, true, false, false)),
         );
     }
 

Tests/Generator/TritonFilterGeneratorTest.php

Doc Comments +6 added lines

@@ -61,6 +61,9 @@ 
         }
     }
 
+    /**
+     * @param boolean $overwrite
+     */
     private function generateFormFilter($overwrite)
     {
 
@@ -70,6 +73,9 @@ 
         $generator->generate($bundle, 'Post', $metadata, $overwrite, CrudGeneratorCommand::FILTER_TYPE_FORM);
     }
 
+    /**
+     * @param boolean $overwrite
+     */
     private function generateMultiSearchFilter($overwrite)
     {
         $generator = $this->getFilterGenerator();

Command/CrudValidators.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
         $filterType = strtolower($filterType);
 
-        if($filterType==1){//set to default value
+        if ($filterType == 1) {//set to default value
             $filterType = CrudGeneratorCommand::FILTER_TYPE_FORM;
         }
         // in case they typed "no", but ok with that

Generator/PetkoparaFilterGenerator.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Petkopara\CrudGeneratorBundle\Generator;
 
-use Doctrine\Bundle\DoctrineBundle\Mapping\DisconnectedMetadataFactory;
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
 use Petkopara\CrudGeneratorBundle\Command\CrudGeneratorCommand;
 use Petkopara\CrudGeneratorBundle\Generator\Guesser\MetadataGuesser;

Indentation +4 added lines, -4 removed lines

@@ -20,10 +20,10 @@
     private $classPath;
     private $metadataGuesser;
 
-  /**
-   * 
-   * @param MetadataGuesser $guesser
-   */
+    /**
+     * 
+     * @param MetadataGuesser $guesser
+     */
     public function __construct(MetadataGuesser $guesser)
     {
         $this->metadataGuesser = $guesser;

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
         // Convert type to filter widget
         foreach ($fieldsData as $fieldName => $data) {
             $fieldWidget = $this->getFilterType($fieldsData[$fieldName]['type'], $fieldName);
-            if ($fieldWidget!== false) {
+            if ($fieldWidget !== false) {
                 $fieldsResult[$fieldName]['fieldName'] = $fieldName;
                 $fieldsResult[$fieldName]['filterWidget'] = $this->getFilterType($fieldsData[$fieldName]['type'], $fieldName);
             }

Generator/PetkoparaFormGenerator.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Petkopara\CrudGeneratorBundle\Generator;
 
-use Doctrine\Bundle\DoctrineBundle\Mapping\DisconnectedMetadataFactory;
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
 use Petkopara\CrudGeneratorBundle\Generator\Guesser\MetadataGuesser;
 use RuntimeException;