CurrencyWebservice::getExchangeRate() - Code Metrics - Inspection of "Update the scrutinizer.yml again" - pengyue/Awin-ReportTask - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 659f53...df9043 )

by Peng

created 2018-01-15 22:09 UTC

CurrencyWebservice::getExchangeRate() C

↳ Parent: CurrencyWebservice

Complexity

Conditions	14
Paths	26

Size

Total Lines	59
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	14
eloc	49
nc	26
nop	2
dl	0
loc	59
rs	6.4055
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Awin\ReportTask\Bundle\ReportBundle\Model;

use Awin\ReportTask\Bundle\ReportBundle\Exception\CurrencyExchangeRateNotFoundException;

/**
 * The fake currency webservice, the currency exchange rate betweem 2 currencies are random,
 * Ideally this class should be a service, rather than a model, according to the requirement, keep it in model for now
 *
 * @date       24/06/2017
 * @time       11:35
 * @author     Peng Yue <[email protected]>
 * @copyright  2004-2017 Peng Yue
 */

class CurrencyWebservice
{
    /**
     * Return random value here for basic currencies like GBP USD EUR (simulates real API)
     * @param string $originalCurrency
     * @param string $targetCurrency
     *
     * @return float
     */
    public function getExchangeRate($originalCurrency, $targetCurrency)
    {
        $rate = null;

        switch ($originalCurrency) {
            case 'GBP':
                switch($targetCurrency) {
                    case 'GBP':
                        $rate = 1.00;
                        break;
                    case 'USD':
                        $rate = random_int(124, 139) / 100;
                        break;
                    case 'EUR':
                        $rate = random_int(111, 115) / 100;
                        break;
                    default:
                        break;
                }
                break;
            case 'USD':
                switch($targetCurrency) {
                    case 'GBP':
                        $rate = random_int(77, 82) / 100;
                        break;
                    case 'USD':
                        $rate = 1.00;
                        break;
                    case 'EUR':
                        $rate = random_int(87, 92) / 100;
                        break;
                    default:
                        break;
                }
                break;
            case 'EUR':
                switch($targetCurrency) {
                    case 'GBP':
                        $rate = random_int(85, 90) / 100;
                        break;
                    case 'USD':
                        $rate = random_int(109, 114) / 100;
                        break;
                    case 'EUR':
                        $rate = 1.00;
                        break;
                    default:
                        break;
                }
                break;
            default:
                break;
        }

        if (null == $rate) {

            throw new CurrencyExchangeRateNotFoundException($originalCurrency, $targetCurrency);
        }

        return (float)$rate;
    }
}

1			<?php
2
3			namespace Awin\ReportTask\Bundle\ReportBundle\Model;
4
5			use Awin\ReportTask\Bundle\ReportBundle\Exception\CurrencyExchangeRateNotFoundException;
6
7			/**
8			* The fake currency webservice, the currency exchange rate betweem 2 currencies are random,
9			* Ideally this class should be a service, rather than a model, according to the requirement, keep it in model for now
10			*
11			* @date 24/06/2017
12			* @time 11:35
13			* @author Peng Yue <[email protected]>
14			* @copyright 2004-2017 Peng Yue
15			*/
16
17			class CurrencyWebservice
18			{
19			/**
20			* Return random value here for basic currencies like GBP USD EUR (simulates real API)
21			* @param string $originalCurrency
22			* @param string $targetCurrency
23			*
24			* @return float
25			*/
26			public function getExchangeRate($originalCurrency, $targetCurrency)
27			{
28			$rate = null;
29
30			switch ($originalCurrency) {
31			case 'GBP':
32			switch($targetCurrency) {
33			case 'GBP':
34			$rate = 1.00;
35			break;
36			case 'USD':
37			$rate = random_int(124, 139) / 100;
38			break;
39			case 'EUR':
40			$rate = random_int(111, 115) / 100;
41			break;
42			default:
43			break;
44			}
45			break;
46			case 'USD':
47			switch($targetCurrency) {
48			case 'GBP':
49			$rate = random_int(77, 82) / 100;
50			break;
51			case 'USD':
52			$rate = 1.00;
53			break;
54			case 'EUR':
55			$rate = random_int(87, 92) / 100;
56			break;
57			default:
58			break;
59			}
60			break;
61			case 'EUR':
62			switch($targetCurrency) {
63			case 'GBP':
64			$rate = random_int(85, 90) / 100;
65			break;
66			case 'USD':
67			$rate = random_int(109, 114) / 100;
68			break;
69			case 'EUR':
70			$rate = 1.00;
71			break;
72			default:
73			break;
74			}
75			break;
76			default:
77			break;
78			}
79
80			if (null == $rate) {
			0 ignored issues – show Bug Best Practice introduced 2017-11-18 22:38 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$rate` of type `null\|integer` against `null`; this is ambiguous if the integer can be zero. Consider using a strict comparison `===` instead. Loading history...
81			throw new CurrencyExchangeRateNotFoundException($originalCurrency, $targetCurrency);
82			}
83
84			return (float)$rate;
85			}
86			}

pengyue / Awin-ReportTask

GitHub Access Token became invalid

Push — master ( 659f53...df9043 )

CurrencyWebservice::getExchangeRate() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like