Awin\ReportTask\Bundle\ReportBundle\Model\CurrencyWebservice

Complexity

Total Complexity

14

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	getExchangeRate()	0	59	14

<?php

namespace Awin\ReportTask\Bundle\ReportBundle\Model;

use Awin\ReportTask\Bundle\ReportBundle\Exception\CurrencyExchangeRateNotFoundException;

/**
 * The fake currency webservice, the currency exchange rate betweem 2 currencies are random,
 * Ideally this class should be a service, rather than a model, according to the requirement, keep it in model for now
 *
 * @date       24/06/2017
 * @time       11:35
 * @author     Peng Yue <penyue@gmail.com>
 * @copyright  2004-2017 Peng Yue
 */

class CurrencyWebservice
{
    /**
     * Return random value here for basic currencies like GBP USD EUR (simulates real API)
     * @param string $originalCurrency
     * @param string $targetCurrency
     *
     * @return float
     */
    public function getExchangeRate($originalCurrency, $targetCurrency)
    {
        $rate = null;

        switch ($originalCurrency) {
            case 'GBP':
                switch($targetCurrency) {
                    case 'GBP':
                        $rate = 1.00;
                        break;
                    case 'USD':
                        $rate = random_int(124, 139) / 100;
                        break;
                    case 'EUR':
                        $rate = random_int(111, 115) / 100;
                        break;
                    default:
                        break;
                }
                break;
            case 'USD':
                switch($targetCurrency) {
                    case 'GBP':
                        $rate = random_int(77, 82) / 100;
                        break;
                    case 'USD':
                        $rate = 1.00;
                        break;
                    case 'EUR':
                        $rate = random_int(87, 92) / 100;
                        break;
                    default:
                        break;
                }
                break;
            case 'EUR':
                switch($targetCurrency) {
                    case 'GBP':
                        $rate = random_int(85, 90) / 100;
                        break;
                    case 'USD':
                        $rate = random_int(109, 114) / 100;
                        break;
                    case 'EUR':
                        $rate = 1.00;
                        break;
                    default:
                        break;
                }
                break;
            default:
                break;
        }

        if (null == $rate) {

It seems like you are loosely comparing $rate of type null|integer against null; this is ambiguous if the integer can be zero. Consider using a strict comparison === instead.

            throw new CurrencyExchangeRateNotFoundException($originalCurrency, $targetCurrency);
        }

        return (float)$rate;
    }
}