pdavila13 / tasksAPI

app/Http/Controllers/TagController.php

Doc Comments +7 added lines, -4 removed lines

@@ -15,7 +15,7 @@ 
     /**
      * Display a listing of the resource.
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function index() {
         //return Tag::all();
@@ -52,7 +52,7 @@ 
      * Display the specified resource.
      *
      * @param  int  $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function show($id) {
         //return $tag = Tag::findOrFail($id);
@@ -89,7 +89,7 @@ 
      *
      * @param  \Illuminate\Http\Request  $request
      * @param  int  $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse|null
      */
     public function update(Request $request, $id) {
         //$tag = Tag::findOrFail($id);
@@ -122,6 +122,9 @@ 
         Tag::destroy($id);
     }
 
+    /**
+     * @param \Illuminate\Database\Eloquent\Collection $tag
+     */
     public function transformCollection($tag) {
         return array_map([$this, 'transform'], $tag->toArray());
     }
@@ -134,7 +137,7 @@ 
 
     /**
      * @param Request $request
-     * @param $tag
+     * @param Tag $tag
      */
     public function saveTag(Request $request, $tag) {
         $tag->name = $request->name;

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 namespace App\Http\Controllers;
 
 use App\Tag;
-use App\Transformers\TagTransformer;
 use Illuminate\Http\Request;
-
-use App\Http\Requests;
 use App\Http\Controllers\Controller;
 use Response;
 

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
 
         return Response::json([
             'data' => $this->transformCollection($tag)
-        ],200);
+        ], 200);
     }
 
     /**
@@ -71,7 +71,7 @@ 
 
         return Response::json([
             'data' => $this->transform($tag->toArray())
-        ],200);
+        ], 200);
     }
 
     /**
@@ -107,7 +107,7 @@ 
 
         return Response::json([
             'data' => $tag->toArray()
-        ],200);
+        ], 200);
 
         $this->saveTag($request, $tag);
     }
@@ -126,7 +126,7 @@ 
         return array_map([$this, 'transform'], $tag->toArray());
     }
 
-    private function transform($tag){
+    private function transform($tag) {
         return [
             'name' => $tag['name']
         ];

app/Http/Controllers/TaskController.php

Doc Comments +7 added lines, -3 removed lines

@@ -13,7 +13,7 @@ 
     /**
      * Display a listing of the resource.
      *
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function index() {
         // 1. No es retorna: paginacion
@@ -52,7 +52,7 @@ 
      * Display the specified resource.
      *
      * @param  int  $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse
      */
     public function show($id) {
         //return $tag = Task::findOrFail($id);
@@ -89,7 +89,7 @@ 
      *
      * @param  \Illuminate\Http\Request  $request
      * @param  int  $id
-     * @return \Illuminate\Http\Response
+     * @return \Illuminate\Http\JsonResponse|null
      */
     public function update(Request $request, $id) {
         //$task = Task::findOrFail($id);
@@ -122,6 +122,9 @@ 
         Task::destroy($id);
     }
 
+    /**
+     * @param \Illuminate\Database\Eloquent\Collection $task
+     */
     public function transformCollection($task) {
         return array_map([$this, 'transform'], $task->toArray());
     }
@@ -137,6 +140,7 @@ 
     /**
      * @param Request $request
      * @param $tag
+     * @param Task $task
      */
     public function saveTask(Request $request, $task) {
         $task->name = $request->name;

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 
 use App\Task;
 use Illuminate\Http\Request;
-
-use App\Http\Requests;
 use App\Http\Controllers\Controller;
 use Response;
 

Indentation +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
                 'error' => [
                     'message' => 'Task does not exist',
                     'code' => 195
-                 ]
+                    ]
             ], 404);
         }
 

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
         return Response::json([
             'data' => $this->transformCollection($task)
             //'data' => $task->toArray()
-        ],200);
+        ], 200);
     }
 
     /**
@@ -71,7 +71,7 @@ 
         return Response::json([
             'data' => $this->transform($task->toArray())
             //'data' => $task->toArray()
-        ],200);
+        ], 200);
     }
 
     /**
@@ -107,7 +107,7 @@ 
 
         return Response::json([
             'data' => $task->toArray()
-        ],200);
+        ], 200);
 
         $this->saveTask($request, $task);
     }
@@ -126,7 +126,7 @@ 
         return array_map([$this, 'transform'], $task->toArray());
     }
 
-    private function transform($task){
+    private function transform($task) {
         return [
             'name' => $task['name'],
             'priority' => (boolean) $task['priority'],

app/Console/Kernel.php

Indentation +1 added lines, -1 removed lines

@@ -25,6 +25,6 @@
     protected function schedule(Schedule $schedule)
     {
         $schedule->command('inspire')
-                 ->hourly();
+                    ->hourly();
     }
 }

app/Providers/RouteServiceProvider.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
      */
     public function map(Router $router)
     {
-        $router->group(['namespace' => $this->namespace], function ($router) {
+        $router->group(['namespace' => $this->namespace], function($router) {
             require app_path('Http/routes.php');
         });
     }

app/Http/routes.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 |
 */
 
-Route::get('/', function () {
+Route::get('/', function() {
     return view('welcome');
 });
 

app/Transformers/TagTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
 
 
 class TagTransformer extends Transformer {
-    public function transform($item){
+    public function transform($item) {
         return [
             'name' => $item['name'],
             'tran' => (boolean) $item['tran']