@@ -199,8 +199,7 @@ |
||
199 | 199 | // We simply return and continue the login procedure (The normal way :)), |
200 | 200 | // and will disable all pages until he has added a 2FA key. |
201 | 201 | return $event; |
202 | - } |
|
203 | - else |
|
202 | + } else |
|
204 | 203 | { |
205 | 204 | $this->session_helper->generate_page($event['login']['user_row']['user_id'], $event['admin'], $event['autologin'], !$this->request->is_set_post('viewonline'), $this->request->variable('redirect', '')); |
206 | 205 | } |
@@ -91,16 +91,16 @@ discard block |
||
91 | 91 | */ |
92 | 92 | public function __construct(helper $controller_helper, driver_interface $db, template $template, user $user, request_interface $request, config $config, log $log, session_helper_interface $session_helper, $root_path, $php_ext) |
93 | 93 | { |
94 | - $this->controller_helper = $controller_helper; |
|
95 | - $this->template = $template; |
|
96 | - $this->db = $db; |
|
97 | - $this->user = $user; |
|
98 | - $this->request = $request; |
|
99 | - $this->config = $config; |
|
100 | - $this->session_helper = $session_helper; |
|
101 | - $this->root_path = $root_path; |
|
102 | - $this->php_ext = $php_ext; |
|
103 | - $this->log = $log; |
|
94 | + $this->controller_helper = $controller_helper; |
|
95 | + $this->template = $template; |
|
96 | + $this->db = $db; |
|
97 | + $this->user = $user; |
|
98 | + $this->request = $request; |
|
99 | + $this->config = $config; |
|
100 | + $this->session_helper = $session_helper; |
|
101 | + $this->root_path = $root_path; |
|
102 | + $this->php_ext = $php_ext; |
|
103 | + $this->log = $log; |
|
104 | 104 | } |
105 | 105 | |
106 | 106 | /** |
@@ -135,9 +135,9 @@ discard block |
||
135 | 135 | 'tfa_random' => '', |
136 | 136 | 'tfa_uid' => 0, |
137 | 137 | ); |
138 | - $sql = 'UPDATE ' . SESSIONS_TABLE . ' SET ' . $this->db->sql_build_array('UPDATE', $sql_ary) . " |
|
138 | + $sql = 'UPDATE '.SESSIONS_TABLE.' SET '.$this->db->sql_build_array('UPDATE', $sql_ary)." |
|
139 | 139 | WHERE |
140 | - session_id = '" . $this->db->sql_escape($this->user->data['session_id']) . "' AND |
|
140 | + session_id = '" . $this->db->sql_escape($this->user->data['session_id'])."' AND |
|
141 | 141 | session_user_id = " . (int) $this->user->data['user_id']; |
142 | 142 | $this->db->sql_query($sql); |
143 | 143 | |
@@ -201,8 +201,8 @@ discard block |
||
201 | 201 | if ($admin) |
202 | 202 | { |
203 | 203 | // the login array is used because the user ids do not differ for re-authentication |
204 | - $sql = 'DELETE FROM ' . SESSIONS_TABLE . " |
|
205 | - WHERE session_id = '" . $this->db->sql_escape($old_session_id) . "' |
|
204 | + $sql = 'DELETE FROM '.SESSIONS_TABLE." |
|
205 | + WHERE session_id = '" . $this->db->sql_escape($old_session_id)."' |
|
206 | 206 | AND session_user_id = " . (int) $user_id; |
207 | 207 | $this->db->sql_query($sql); |
208 | 208 |
@@ -162,8 +162,7 @@ discard block |
||
162 | 162 | $this->template->assign_var('S_ERROR', $this->user->lang('TFA_INCORRECT_KEY')); |
163 | 163 | $this->session_helper->generate_page($user_id, $admin, $auto_login, $viewonline, $redirect); |
164 | 164 | } |
165 | - } |
|
166 | - catch (http_exception $ex) // @TODO: Replace exception with own exception |
|
165 | + } catch (http_exception $ex) // @TODO: Replace exception with own exception |
|
167 | 166 | { |
168 | 167 | |
169 | 168 | $this->log->add('critical', $this->user->data['user_id'], $this->user->ip, 'LOG_TFA_EXCEPTION', false, [$ex->getMessage()]); |
@@ -177,8 +176,7 @@ discard block |
||
177 | 176 | { |
178 | 177 | $this->template->assign_var('S_ERROR', $this->user->lang($ex->getMessage())); |
179 | 178 | $this->session_helper->generate_page($user_id, $admin, $auto_login, $viewonline, $redirect); |
180 | - } |
|
181 | - else |
|
179 | + } else |
|
182 | 180 | { |
183 | 181 | throw $ex; |
184 | 182 | } |