partnermarketing / PartnermarketingTranslationBundle

src/Exception/YMLParseException.php

Doc Comments +3 added lines

@@ -11,6 +11,9 @@
      */
     private $ymlFile;
 
+    /**
+     * @param string $yamlFile
+     */
     public function __construct(ParseException $previous, $yamlFile)
     {
         $message = 'Failed to parse file: \''.$yamlFile.'\' on line '.$previous->getParsedLine().'.';

Spacing +2 added lines, -2 removed lines

@@ -13,7 +13,7 @@ 
 
     public function __construct(ParseException $previous, $yamlFile)
     {
-        $message = 'Failed to parse file: \''.$yamlFile.'\' on line '.$previous->getParsedLine().'.';
+        $message = 'Failed to parse file: \'' . $yamlFile . '\' on line ' . $previous->getParsedLine() . '.';
         parent::__construct($message, $previous->getCode(), $previous);
         $this->setYmlFile($yamlFile);
     }
@@ -29,7 +29,7 @@ 
     /**
      * @param string $ymlFile
      */
-    public function setYmlFile( $ymlFile )
+    public function setYmlFile($ymlFile)
     {
         $this->ymlFile = $ymlFile;
     }

src/Adapter/OneSkyAdapter.php

Spacing +22 added lines, -22 removed lines

@@ -48,8 +48,8 @@ 
         $files = $this->getBaseTranslationFiles();
         $client = $this->getClient();
 
-        if(count($files) > 0) {
-            foreach($files as $filePath) {
+        if (count($files) > 0) {
+            foreach ($files as $filePath) {
                 $response = $client->files('upload', [
                     'project_id' => $this->oneSkyProjectId,
                     'file' => $filePath,
@@ -86,31 +86,31 @@ 
     /**
      * Will ask adaptor for all files in all supported_languages and dump them to individual yml files.
      */
-    public function dumpAllTranslationsToYamlFiles(){
+    public function dumpAllTranslationsToYamlFiles() {
         $files = $this->getBaseTranslationFiles();
         $supportedLanguages = $this->getSupportedLanguages();
 
-        foreach($supportedLanguages as $supportedLanguage) {
+        foreach ($supportedLanguages as $supportedLanguage) {
             foreach ($files as $baseTranslationFilePath) {
-                $fileName            = $this->getFilenameFromFilePath( $baseTranslationFilePath );
-                $adapterFileContent = $this->getTranslationFile( $supportedLanguage, $fileName );
+                $fileName = $this->getFilenameFromFilePath($baseTranslationFilePath);
+                $adapterFileContent = $this->getTranslationFile($supportedLanguage, $fileName);
                 try {
-                    $adapterTranslationsArray = YamlParser::parse( $adapterFileContent );
-                } catch(ParseException $e) {
+                    $adapterTranslationsArray = YamlParser::parse($adapterFileContent);
+                } catch (ParseException $e) {
                     throw new YMLParseException($e, $fileName);
                 }
 
-                $phraseCollectionKey = $this->getPhraseCollectionKeyFromFilename( $baseTranslationFilePath );
+                $phraseCollectionKey = $this->getPhraseCollectionKeyFromFilename($baseTranslationFilePath);
 
                 if (is_array($adapterTranslationsArray) && count($adapterTranslationsArray) > 0) {
                     $this->ksortMultiDimensional($adapterTranslationsArray);
-                    $this->dumpToYaml( $adapterTranslationsArray, $phraseCollectionKey, $supportedLanguage );
+                    $this->dumpToYaml($adapterTranslationsArray, $phraseCollectionKey, $supportedLanguage);
                 } else {
                     // Ensure adapterTranslationsArray is an array.
                     $adapterTranslationsArray = [];
                 }
                 // This is only execute for base language.
-                if($supportedLanguage === $this->getBaseLanguage()) {
+                if ($supportedLanguage === $this->getBaseLanguage()) {
                     $existingTranslations = YamlParser::parse(file_get_contents($baseTranslationFilePath));
                     $mergedTranslations = array_replace_recursive($existingTranslations, $adapterTranslationsArray);
 
@@ -143,8 +143,8 @@ 
         $languageParts = explode('-', $languageString);
         $countryCode = $languageParts[0];
         $languageTag = $countryCode;
-        if(count($languageParts) > 1) {
-            $languageTag .= '_'.$languageParts[1];
+        if (count($languageParts) > 1) {
+            $languageTag .= '_' . $languageParts[1];
         }
 
         return $languageTag;
@@ -179,10 +179,10 @@ 
      */
     private function keepQuotesOnBooleanValue($yamlString)
     {
-        $yaml = preg_replace('/: (\byes\b)/i', ": '"."$1"."'", $yamlString);
-        $yaml = preg_replace('/: (\bno\b)/i', ": '"."$1"."'", $yaml);
-        $yaml = preg_replace('/: (\bon\b)/i', ": '"."$1"."'", $yaml);
-        $yaml = preg_replace('/: (\boff\b)/i', ": '"."$1"."'", $yaml);
+        $yaml = preg_replace('/: (\byes\b)/i', ": '" . "$1" . "'", $yamlString);
+        $yaml = preg_replace('/: (\bno\b)/i', ": '" . "$1" . "'", $yaml);
+        $yaml = preg_replace('/: (\bon\b)/i', ": '" . "$1" . "'", $yaml);
+        $yaml = preg_replace('/: (\boff\b)/i', ": '" . "$1" . "'", $yaml);
 
         return $yaml;
     }
@@ -214,7 +214,7 @@ 
     public function getPhrasesFromFilename($filename)
     {
         $yamlPhrases = YamlParser::parse(file_get_contents($filename));
-        if(!is_array($yamlPhrases)) {
+        if (!is_array($yamlPhrases)) {
             $yamlPhrases = [];
         }
         $phrases = $this->yamlArrayToDottedPhrasesArray($yamlPhrases);
@@ -277,7 +277,7 @@ 
     public function getFilenameFromFilePath($filePath)
     {
         $parts = explode('/', $filePath);
-        $fileName = $parts[count($parts)-1];
+        $fileName = $parts[count($parts) - 1];
 
         return trim($fileName);
     }
@@ -290,8 +290,8 @@ 
     /**
      * @return Client
      */
-    public function getClient(){
-        if(!$this->client) {
+    public function getClient() {
+        if (!$this->client) {
             $this->client = $this->createClient();
         }
         return $this->client;
@@ -335,7 +335,7 @@ 
     /**
      * @param array $supportedLanguages
      */
-    public function setSupportedLanguages( $supportedLanguages )
+    public function setSupportedLanguages($supportedLanguages)
     {
         $this->supportedLanguages = $supportedLanguages;
     }

src/Adapter/TranslationAdapter.php

Indentation +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
 
 abstract class TranslationAdapter
 {
-	/**
+    /**
      * After 6th level it will go to inline YAML.
      */
     const YAML_INLINE_AFTER = 6;

src/Command/PushBaseTranslationsCommand.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
                 null,
                 InputOption::VALUE_NONE,
                 'If set, it will not pull before push.'
-            );;
+            ); ;
     }
 
     /**

src/Tests/Unit/Adapter/OneSkyAdapterTest.php

Indentation +45 added lines, -45 removed lines

@@ -100,9 +100,9 @@ 
         $methodParams['file'] = $this->baseTranslationsDir . '/pages/movies.yml';
 
         $oneSkyMockClient->expects($this->at(1))
-                         ->method('__call')
-                         ->with($this->equalTo('files'), $this->equalTo(['upload', $methodParams]))
-                         ->willReturn(json_encode(["meta" => ["status" => 201]]));
+                            ->method('__call')
+                            ->with($this->equalTo('files'), $this->equalTo(['upload', $methodParams]))
+                            ->willReturn(json_encode(["meta" => ["status" => 201]]));
 
         $this->adapter->setClient($oneSkyMockClient);
         $this->adapter->pushBaseTranslations();
@@ -111,8 +111,8 @@ 
     public function testGetTranslationFile()
     {
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
         $methodParams = [
             'project_id' => 111,
@@ -121,9 +121,9 @@ 
         ];
 
         $oneSkyMockClient->expects($this->at(0))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 page_title: "10 Best Movies"');
 
 
@@ -141,8 +141,8 @@ 
 
     public function testDumpAllTranslationsIntoYmlFiles(){
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
 
         $methodParams = [
@@ -152,9 +152,9 @@ 
         ];
 
         $oneSkyMockClient->expects($this->at(0))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 book_1:
     title: Bunnies for Dummies
 
@@ -163,9 +163,9 @@ 
 
         $methodParams['source_file_name'] = 'movies.yml';
         $oneSkyMockClient->expects($this->at(1))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 page_title: "10 Best Movies"');
 
         $this->adapter->setSupportedLanguages(['en_GB']);
@@ -176,8 +176,8 @@ 
 
     public function testDumpAllTranslationsIntoYmlFilesWithoutDeletingExistingTranslations(){
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
 
         $methodParams = [
@@ -187,9 +187,9 @@ 
         ];
 
         $oneSkyMockClient->expects($this->at(0))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 book_2:
     title: Teddy Bear Stories Updated
 
@@ -233,8 +233,8 @@ 
 
     public function testDumpAllTranslationsIntoYmlFilesWithMoreThenOneSupportedLanguage(){
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
 
         $methodParams = [
@@ -244,9 +244,9 @@ 
         ];
 
         $oneSkyMockClient->expects($this->at(0))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 book_1:
     title: Bunnies for Dummies
 
@@ -255,17 +255,17 @@ 
 
         $methodParams['source_file_name'] = 'movies.yml';
         $oneSkyMockClient->expects($this->at(1))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 page_title: "10 Best Movies"');
 
         $methodParams['locale'] = 'pt_PT';
         $methodParams['source_file_name'] = 'books.yml';
         $oneSkyMockClient->expects($this->at(2))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 book_1:
     title: Coelhos para totos
 
@@ -274,9 +274,9 @@ 
 
         $methodParams['source_file_name'] = 'movies.yml';
         $oneSkyMockClient->expects($this->at(3))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 page_title: "10 Melhores filmes"');
 
 
@@ -299,8 +299,8 @@ 
      */
     public function testDumpAllTranslationsIntoYmlFilesInvalidYMLFile(){
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
 
         $methodParams = [
@@ -310,9 +310,9 @@ 
         ];
 
         $oneSkyMockClient->expects($this->at(0))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 
 ? "true"
   : "Yes"
@@ -330,8 +330,8 @@ 
      */
     public function testDumpAllTranslationsIntoYmlFilesKeepQuotesOnBooleanValues(){
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
-                                 ->disableOriginalConstructor()
-                                 ->getMock();
+                                    ->disableOriginalConstructor()
+                                    ->getMock();
 
 
         $methodParams = [
@@ -341,9 +341,9 @@ 
         ];
 
         $oneSkyMockClient->expects($this->at(0))
-                         ->method('__call')
-                         ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
-                         ->willReturn('---
+                            ->method('__call')
+                            ->with($this->equalTo('translations'), $this->equalTo(['export', $methodParams]))
+                            ->willReturn('---
 
 active: "Yes"
 inactive: "No"

Spacing +12 added lines, -12 removed lines

@@ -130,7 +130,7 @@ 
         $this->adapter->setClient($oneSkyMockClient);
         $fileContent = $this->adapter->getTranslationFile('en_GB', 'movies.yml');
 
-        $this->assertContains('page_title: "10 Best Movies"',$fileContent);
+        $this->assertContains('page_title: "10 Best Movies"', $fileContent);
     }
 
 
@@ -139,7 +139,7 @@ 
 
     }
 
-    public function testDumpAllTranslationsIntoYmlFiles(){
+    public function testDumpAllTranslationsIntoYmlFiles() {
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
                                  ->disableOriginalConstructor()
                                  ->getMock();
@@ -174,7 +174,7 @@ 
     }
 
 
-    public function testDumpAllTranslationsIntoYmlFilesWithoutDeletingExistingTranslations(){
+    public function testDumpAllTranslationsIntoYmlFilesWithoutDeletingExistingTranslations() {
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
                                  ->disableOriginalConstructor()
                                  ->getMock();
@@ -203,13 +203,13 @@ 
 
         $this->restoreBaseTranslationFiles();
 
-        $existingTranslations = Yaml::parse(file_get_contents($this->baseTranslationsDir.'/books.yml'));
+        $existingTranslations = Yaml::parse(file_get_contents($this->baseTranslationsDir . '/books.yml'));
 
         $this->assertEquals($this->bookBaseTranslations, $existingTranslations);
 
         $this->adapter->dumpAllTranslationsToYamlFiles();
 
-        $updatedTranslations = Yaml::parse(file_get_contents($this->baseTranslationsDir.'/books.yml'));
+        $updatedTranslations = Yaml::parse(file_get_contents($this->baseTranslationsDir . '/books.yml'));
 
         $expectedTranslationsAfterUpdate = [
             'book_1' => [
@@ -231,7 +231,7 @@ 
     }
 
 
-    public function testDumpAllTranslationsIntoYmlFilesWithMoreThenOneSupportedLanguage(){
+    public function testDumpAllTranslationsIntoYmlFilesWithMoreThenOneSupportedLanguage() {
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
                                  ->disableOriginalConstructor()
                                  ->getMock();
@@ -285,10 +285,10 @@ 
         $this->adapter->dumpAllTranslationsToYamlFiles();
 
         // Ensure files were created.
-        $this->assertFileExists($this->baseTranslationsDir.'/../translations/books.en_GB.yml');
-        $this->assertFileExists($this->baseTranslationsDir.'/../translations/books.pt_PT.yml');
-        $this->assertFileExists($this->baseTranslationsDir.'/../translations/pages/movies.en_GB.yml');
-        $this->assertFileExists($this->baseTranslationsDir.'/../translations/pages/movies.pt_PT.yml');
+        $this->assertFileExists($this->baseTranslationsDir . '/../translations/books.en_GB.yml');
+        $this->assertFileExists($this->baseTranslationsDir . '/../translations/books.pt_PT.yml');
+        $this->assertFileExists($this->baseTranslationsDir . '/../translations/pages/movies.en_GB.yml');
+        $this->assertFileExists($this->baseTranslationsDir . '/../translations/pages/movies.pt_PT.yml');
     }
 
 
@@ -297,7 +297,7 @@ 
      *
      * @expectedException \Partnermarketing\TranslationBundle\Exception\YMLParseException
      */
-    public function testDumpAllTranslationsIntoYmlFilesInvalidYMLFile(){
+    public function testDumpAllTranslationsIntoYmlFilesInvalidYMLFile() {
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
                                  ->disableOriginalConstructor()
                                  ->getMock();
@@ -328,7 +328,7 @@ 
     /**
      * This test is required because OneSky is using YAML 1.1 and values like ['Yes', 'No']
      */
-    public function testDumpAllTranslationsIntoYmlFilesKeepQuotesOnBooleanValues(){
+    public function testDumpAllTranslationsIntoYmlFilesKeepQuotesOnBooleanValues() {
         $oneSkyMockClient = $this->getMockBuilder('Onesky\Api\Client')
                                  ->disableOriginalConstructor()
                                  ->getMock();

src/Tests/Unit/Command/PullTranslationsCommandTest.php

Indentation +2 added lines, -2 removed lines

@@ -47,8 +47,8 @@
     public function testPullAllSupportedLanguages()
     {
         $this->fakeAdapter->expects($this->once())
-                          ->method('dumpAllTranslationsToYamlFiles')
-                          ->with();
+                            ->method('dumpAllTranslationsToYamlFiles')
+                            ->with();
 
         $commandTester = new CommandTester($this->command);
         $commandTester->execute([

src/Tests/Unit/DependencyInjection/PartnermarketingTranslationExtensionTest.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
 
         );
 
-        $this->extension->load( array( $configs ), $container = $this->getContainer() );
+        $this->extension->load(array($configs), $container = $this->getContainer());
 
         $this->assertTrue($container->hasParameter($this->root . ".supported_languages"));
         $this->assertTrue($container->hasParameter($this->root . ".one_sky.project_id"));