partnermarketing / PartnermarketingFileSystemBundle

src/Adapter/LocalStorage.php

Doc Comments +6 added lines, -1 removed lines

@@ -25,6 +25,7 @@ 
 
     /**
      * Constructor for LocalStorage adapter
+     * @param \Symfony\Component\Filesystem\Filesystem $service
      */
     public function __construct($service, array $parameters, $localTmpDir)
     {
@@ -123,6 +124,10 @@ 
         $this->service->mkdir($this->absolutePath.'/'.$dir);
     }
 
+    /**
+     * @param string $originFile
+     * @param string $targetFile
+     */
     public function copy($originFile, $targetFile)
     {
         $originFile = $this->pathOrUrlToPath($originFile);
@@ -220,7 +225,7 @@ 
 
     /**
      * @param  string $input
-     * @return array  The path to the file inside the file system. Does not contain a preceding
+     * @return string  The path to the file inside the file system. Does not contain a preceding
      *                slash.
      */
     private function pathOrUrlToPath($input)

Spacing +7 added lines, -7 removed lines

@@ -30,7 +30,7 @@ 
     {
         $this->service = $service;
 
-        $absolutePathNormalised = '/' . trim($parameters['path'], '/');
+        $absolutePathNormalised = '/'.trim($parameters['path'], '/');
         if (is_dir($absolutePathNormalised) && realpath($absolutePathNormalised)) {
             $this->absolutePath = realpath($absolutePathNormalised);
         } else {
@@ -53,7 +53,7 @@ 
             $fullPath = $path;
         } else {
             $path = $this->pathOrUrlToPath($path);
-            $fullPath = $this->absolutePath . '/' . $path;
+            $fullPath = $this->absolutePath.'/'.$path;
         }
 
         return (string) file_get_contents($fullPath);
@@ -113,10 +113,10 @@ 
     {
         $directory = $this->pathOrUrlToPath($directory);
 
-        $files = ServerFileSystem::getFilesInDirectory($this->absolutePath . '/' . $directory);
+        $files = ServerFileSystem::getFilesInDirectory($this->absolutePath.'/'.$directory);
 
-        return array_map(function ($file) {
-            return str_replace($this->absolutePath . '/', '', $file);
+        return array_map(function($file) {
+            return str_replace($this->absolutePath.'/', '', $file);
         }, $files);
     }
 
@@ -203,7 +203,7 @@ 
      */
     public function getFileSize($path)
     {
-        $fullPath = $this->absolutePath . '/' . $this->pathOrUrlToPath($path);
+        $fullPath = $this->absolutePath.'/'.$this->pathOrUrlToPath($path);
 
         return filesize($fullPath);
     }
@@ -215,7 +215,7 @@ 
     {
         $content = $this->read($path);
         $extension = pathinfo($path, PATHINFO_EXTENSION);
-        $target = tempnam($this->localTmpDir, null) . '.' . $extension;
+        $target = tempnam($this->localTmpDir, null).'.'.$extension;
 
         file_put_contents($target, $content);
 

src/Tests/Unit/Adapter/LocalStorageTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Partnermarketing\FileSystemBundle\Tests\Unit\Adapter;
 
-use Partnermarketing\FileSystemBundle\Adapter\LocalStorage;
 use Partnermarketing\FileSystemBundle\Factory\FileSystemFactory;
 
 class LocalStorageTest extends \PHPUnit_Framework_TestCase

src/Tests/Unit/Factory/FileSystemFactoryTest.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Partnermarketing\FileSystemBundle\Tests\Functional\Factory;
 
 use Partnermarketing\FileSystemBundle\Factory\FileSystemFactory;
-use Partnermarketing\TestBundle\Tests\Base\BaseFunctionalTest;
 
 class FileSystemFactoryTest extends \PHPUnit_Framework_TestCase
 {

src/Utility/PathHelper.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
         $withoutExtensionAndWithoutQueryString = implode('.', $pathParts);
 
         if (count($extensionAndQueryStringParts) === 2) {
-            return $withoutExtensionAndWithoutQueryString . '?' . $extensionAndQueryStringParts[1];
+            return $withoutExtensionAndWithoutQueryString.'?'.$extensionAndQueryStringParts[1];
         } else {
             return $withoutExtensionAndWithoutQueryString;
         }

src/Tests/Unit/ServerFileSystem/ServerFileSystemTest.php

Spacing +7 added lines, -7 removed lines

@@ -15,7 +15,7 @@ 
 
     public function testGetFilesInDirectoryIsRecursiveAndAlphabetical()
     {
-        $files = ServerFileSystem::getFilesInDirectory(__DIR__  . '/../');
+        $files = ServerFileSystem::getFilesInDirectory(__DIR__.'/../');
 
         $this->assertCount(6, $files);
         $this->assertStringEndsWith('Unit/Adapter/LocalStorageTest.php', $files[0]);
@@ -24,16 +24,16 @@ 
 
     public function testDeleteFilesInDirectoryRecursively()
     {
-        $dir = __DIR__ . '/deleteFilesInDirectoryRecursively/';
+        $dir = __DIR__.'/deleteFilesInDirectoryRecursively/';
 
         if (!is_dir($dir)) {
             mkdir($dir);
         }
-        file_put_contents($dir . '1.txt', '1');
-        file_put_contents($dir . '2.txt', '2');
-        mkdir($dir . 'subdir');
-        file_put_contents($dir . 'subdir/3.txt', '3');
-        file_put_contents($dir . 'subdir/4.txt', '4');
+        file_put_contents($dir.'1.txt', '1');
+        file_put_contents($dir.'2.txt', '2');
+        mkdir($dir.'subdir');
+        file_put_contents($dir.'subdir/3.txt', '3');
+        file_put_contents($dir.'subdir/4.txt', '4');
 
         $filesBefore = ServerFileSystem::getFilesInDirectory($dir);
         $this->assertCount(4, $filesBefore);

src/Adapter/AmazonS3.php

Indentation +4 added lines, -4 removed lines

@@ -230,10 +230,10 @@
     }
 
     /**
-    * Ensures the specified bucket exists. If is does not, and create is true, it will try to create it.
-    *
-    * @return boolean
-    */
+     * Ensures the specified bucket exists. If is does not, and create is true, it will try to create it.
+     *
+     * @return boolean
+     */
     private function ensureBucketExists()
     {
         if ($this->haveEnsuredBucketExists) {

Spacing +4 added lines, -4 removed lines

@@ -169,8 +169,8 @@ 
         /*
          * Add '/' character to the directories if necessary
          */
-        $sourceDir = $sourceDir . (substr($sourceDir, -1) == '/' ? '' : '/');
-        $targetDir = $targetDir . (substr($targetDir, -1) == '/' ? '' : '/');
+        $sourceDir = $sourceDir.(substr($sourceDir, -1) == '/' ? '' : '/');
+        $targetDir = $targetDir.(substr($targetDir, -1) == '/' ? '' : '/');
 
         $this->ensureBucketExists();
 
@@ -179,7 +179,7 @@ 
         $batch = array();
         for ($i = 0; $i < count($files); $i++) {
             $targetFile = str_replace($sourceDir, "", $files[$i]);
-            $batch[] =  $this->service->getCommand('CopyObject', array(
+            $batch[] = $this->service->getCommand('CopyObject', array(
                 'Bucket'     => $targetBucket,
                 'Key'        => "{$targetDir}{$targetFile}",
                 'CopySource' => "{$sourceBucket}/{$files[$i]}",
@@ -301,7 +301,7 @@ 
     {
         $content = $this->read($path);
         $extension = pathinfo($path, PATHINFO_EXTENSION);
-        $target = tempnam($this->localTmpDir, null) . '.' . $extension;
+        $target = tempnam($this->localTmpDir, null).'.'.$extension;
 
         file_put_contents($target, $content);
 

src/Command/FindCommand.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
         $adapterName = $input->getArgument('adapter');
         if (!in_array($adapterName, $this->availableAdapters)) {
             $output->writeln(
-                'Invalid adapter name supplied! Adapters available: ' . implode(', ', $this->availableAdapters)
+                'Invalid adapter name supplied! Adapters available: '.implode(', ', $this->availableAdapters)
             );
 
             return;
@@ -45,9 +45,9 @@ 
         $filename = $input->getArgument('filename');
 
         if ($fileSystem->exists($filename)) {
-            $output->writeln('File was found using adapter (' . $adapterName . ')');
+            $output->writeln('File was found using adapter ('.$adapterName.')');
         } else {
-            $output->writeln('File not found using adapter (' . $adapterName . ')');
+            $output->writeln('File not found using adapter ('.$adapterName.')');
         }
     }
 }

src/Factory/FileSystemFactory.php

Doc Comments +5 added lines

@@ -16,6 +16,10 @@ 
     private $config;
     private $tmpDir;
 
+    /**
+     * @param string $defaultFileSystem
+     * @param string $tmpDir
+     */
     public function __construct($defaultFileSystem, $config, $tmpDir = null)
     {
         $this->defaultFileSystem = $defaultFileSystem;
@@ -24,6 +28,7 @@ 
     }
 
     /**
+     * @param string $adapterName
      * @return \Partnermarketing\FileSystemBundle\Adapter\AdapterInterface
      */
     public function build($adapterName = null)