parsingphase / takeAticket

src/Phase/TakeATicket/PlaylistExporter.php

Spacing +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 
         if (is_array($band) && !empty($band[$instrument])) {
             $performers = array_map(
-                function ($performer) {
+                function($performer) {
                     return $performer['performerName'];
                 },
                 $band[$instrument]

var/SymfonyRequirements.php

Doc Comments +2 added lines, -2 removed lines

@@ -223,7 +223,7 @@ 
      * Adds a mandatory requirement in form of a php.ini configuration.
      *
      * @param string        $cfgName           The configuration name used for ini_get()
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
+     * @param boolean|string $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
@@ -241,7 +241,7 @@ 
      * Adds an optional recommendation in form of a php.ini configuration.
      *
      * @param string        $cfgName           The configuration name used for ini_get()
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
+     * @param string|false $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.

Spacing +17 added lines, -17 removed lines

@@ -49,11 +49,11 @@ 
      */
     public function __construct($fulfilled, $testMessage, $helpHtml, $helpText = null, $optional = false)
     {
-        $this->fulfilled = (bool) $fulfilled;
-        $this->testMessage = (string) $testMessage;
-        $this->helpHtml = (string) $helpHtml;
-        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string) $helpText;
-        $this->optional = (bool) $optional;
+        $this->fulfilled = (bool)$fulfilled;
+        $this->testMessage = (string)$testMessage;
+        $this->helpHtml = (string)$helpHtml;
+        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string)$helpText;
+        $this->optional = (bool)$optional;
     }
 
     /**
@@ -417,13 +417,13 @@ 
         );
 
         $this->addRequirement(
-            is_dir(__DIR__.'/../vendor/composer'),
+            is_dir(__DIR__ . '/../vendor/composer'),
             'Vendor libraries must be installed',
-            'Vendor libraries are missing. Install composer following instructions from <a href="http://getcomposer.org/">http://getcomposer.org/</a>. '.
+            'Vendor libraries are missing. Install composer following instructions from <a href="http://getcomposer.org/">http://getcomposer.org/</a>. ' .
                 'Then run "<strong>php composer.phar install</strong>" to install them.'
         );
 
-        $cacheDir = is_dir(__DIR__.'/../var/cache') ? __DIR__.'/../var/cache' : __DIR__.'/cache';
+        $cacheDir = is_dir(__DIR__ . '/../var/cache') ? __DIR__ . '/../var/cache' : __DIR__ . '/cache';
 
         $this->addRequirement(
             is_writable($cacheDir),
@@ -431,7 +431,7 @@ 
             'Change the permissions of either "<strong>app/cache/</strong>" or  "<strong>var/cache/</strong>" directory so that the web server can write into it.'
         );
 
-        $logsDir = is_dir(__DIR__.'/../var/logs') ? __DIR__.'/../var/logs' : __DIR__.'/logs';
+        $logsDir = is_dir(__DIR__ . '/../var/logs') ? __DIR__ . '/../var/logs' : __DIR__ . '/logs';
 
         $this->addRequirement(
             is_writable($logsDir),
@@ -544,7 +544,7 @@ 
             );
         }
 
-        $pcreVersion = defined('PCRE_VERSION') ? (float) PCRE_VERSION : null;
+        $pcreVersion = defined('PCRE_VERSION') ? (float)PCRE_VERSION : null;
 
         $this->addRequirement(
             null !== $pcreVersion,
@@ -564,13 +564,13 @@ 
 
         /* optional recommendations follow */
 
-        if (file_exists(__DIR__.'/../vendor/composer')) {
-            require_once __DIR__.'/../vendor/autoload.php';
+        if (file_exists(__DIR__ . '/../vendor/composer')) {
+            require_once __DIR__ . '/../vendor/autoload.php';
 
             try {
                 $r = new ReflectionClass('Sensio\Bundle\DistributionBundle\SensioDistributionBundle');
 
-                $contents = file_get_contents(dirname($r->getFileName()).'/Resources/skeleton/app/SymfonyRequirements.php');
+                $contents = file_get_contents(dirname($r->getFileName()) . '/Resources/skeleton/app/SymfonyRequirements.php');
             } catch (ReflectionException $e) {
                 $contents = '';
             }
@@ -783,7 +783,7 @@ 
         $unit = '';
         if (!ctype_digit($size)) {
             $unit = strtolower(substr($size, -1, 1));
-            $size = (int) substr($size, 0, -1);
+            $size = (int)substr($size, 0, -1);
         }
         switch ($unit) {
             case 'g':
@@ -793,7 +793,7 @@ 
             case 'k':
                 return $size * 1024;
             default:
-                return (int) $size;
+                return (int)$size;
         }
     }
 
@@ -804,7 +804,7 @@ 
      */
     protected function getPhpRequiredVersion()
     {
-        if (!file_exists($path = __DIR__.'/../composer.lock')) {
+        if (!file_exists($path = __DIR__ . '/../composer.lock')) {
             return false;
         }
 
@@ -815,7 +815,7 @@ 
                 continue;
             }
 
-            return (int) $package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
+            return (int)$package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
         }
 
         return false;

web/app.php

Spacing +2 added lines, -2 removed lines

@@ -5,8 +5,8 @@
 /**
  * @var Composer\Autoload\ClassLoader
  */
-$loader = require __DIR__.'/../app/autoload.php';
-include_once __DIR__.'/../var/bootstrap.php.cache';
+$loader = require __DIR__ . '/../app/autoload.php';
+include_once __DIR__ . '/../var/bootstrap.php.cache';
 
 // Enable APC for autoloading to improve performance.
 // You should change the ApcClassLoader first argument to a unique prefix

web/app_dev.php

Spacing +2 added lines, -2 removed lines

@@ -15,13 +15,13 @@
     || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
 ) {
     header('HTTP/1.0 403 Forbidden');
-    exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
+    exit('You are not allowed to access this file. Check ' . basename(__FILE__) . ' for more information.');
 }
 
 /**
  * @var Composer\Autoload\ClassLoader $loader
  */
-$loader = require __DIR__.'/../app/autoload.php';
+$loader = require __DIR__ . '/../app/autoload.php';
 Debug::enable();
 
 $kernel = new AppKernel('dev', true);

src/Phase/TakeATicketBundle/Controller/DefaultController.php

Indentation +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
         //$protocol = $_SERVER['HTTPS'] ? 'https' : 'http';
         $protocol = 'http'; // $_SERVER['HTTPS'] ? 'https' : 'http';
         /**
- * @noinspection RealpathInSteamContextInspection
+         * @noinspection RealpathInSteamContextInspection
 */
         $viewParams = [
             //'serverInfo' => $protocol . '://' . $_SERVER['SERVER_ADDR'] . ':' . $_SERVER['SERVER_PORT'] . '/',

Spacing +5 added lines, -5 removed lines

@@ -36,8 +36,8 @@ 
 */
         $viewParams = [
             //'serverInfo' => $protocol . '://' . $_SERVER['SERVER_ADDR'] . ':' . $_SERVER['SERVER_PORT'] . '/',
-            'serverInfo' => $protocol.'://127.0.0.1:8000/', //FIXME get server name (from config if not in request?)
-            'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
+            'serverInfo' => $protocol . '://127.0.0.1:8000/', //FIXME get server name (from config if not in request?)
+            'base_dir' => realpath($this->getParameter('kernel.root_dir') . '/..'),
         ];
         $viewParams['displayOptions'] = $this->getDisplayOptions();
 
@@ -46,14 +46,14 @@ 
 
     public function announceAction($section)
     {
-        $rootDir = realpath(__DIR__.'/../../../../');
-        $announceDir = $rootDir.'/docs/announcements';
+        $rootDir = realpath(__DIR__ . '/../../../../');
+        $announceDir = $rootDir . '/docs/announcements';
 
         if (!preg_match('/^\w+$/', $section)) {
             throw new NotFoundHttpException(); // don't give access to anything but plain names
         }
 
-        $candidateFile = $announceDir.'/'.$section.'.md';
+        $candidateFile = $announceDir . '/' . $section . '.md';
 
         if (!file_exists($candidateFile)) {
             throw new NotFoundHttpException();

src/Phase/TakeATicket/DataSource/MySql.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      */
     protected function concatenateEscapedFields($fields)
     {
-        return 'CONCAT('.implode(', ', $fields).')';
+        return 'CONCAT(' . implode(', ', $fields) . ')';
     }
 
     /**

Doc Comments +2 added lines, -2 removed lines

@@ -24,7 +24,7 @@ 
      * @param $title
      * @param $songId
      *
-     * @return int|false
+     * @return string|false
      */
     public function storeNewTicket($title, $songId)
     {
@@ -48,7 +48,7 @@ 
      * @param $performerName
      * @param bool|false    $createMissing
      *
-     * @return mixed
+     * @return string|boolean
      */
     public function fetchPerformerIdByName($performerName, $createMissing = false)
     {

app/autoload.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 /**
  * @var ClassLoader $loader
  */
-$loader = require __DIR__.'/../vendor/autoload.php';
+$loader = require __DIR__ . '/../vendor/autoload.php';
 
 AnnotationRegistry::registerLoader([$loader, 'loadClass']);
 

app/AppKernel.php

Spacing +3 added lines, -3 removed lines

@@ -36,16 +36,16 @@
 
     public function getCacheDir()
     {
-        return dirname(__DIR__).'/var/cache/'.$this->getEnvironment();
+        return dirname(__DIR__) . '/var/cache/' . $this->getEnvironment();
     }
 
     public function getLogDir()
     {
-        return dirname(__DIR__).'/var/logs';
+        return dirname(__DIR__) . '/var/logs';
     }
 
     public function registerContainerConfiguration(LoaderInterface $loader)
     {
-        $loader->load($this->getRootDir().'/config/config_'.$this->getEnvironment().'.yml');
+        $loader->load($this->getRootDir() . '/config/config_' . $this->getEnvironment() . '.yml');
     }
 }

src/Phase/TakeATicket/DataSource/AbstractSql.php

Doc Comments +9 added lines, -3 removed lines

@@ -262,6 +262,9 @@ 
         }
     }
 
+    /**
+     * @param string $performerName
+     */
     public function fetchPerformerIdByName($performerName, $createMissing = false)
     {
         $conn = $this->getDbConn();
@@ -638,7 +641,7 @@ 
     /**
      * Return SQL in appropriate dialect to concatenate the listed values
      *
-     * @param array $fields
+     * @param string[] $fields
      *
      * @return string
      */
@@ -814,6 +817,9 @@ 
         return $source;
     }
 
+    /**
+     * @param string $platformName
+     */
     public function fetchPlatformByName($platformName)
     {
         $platform = null;
@@ -833,7 +839,7 @@ 
     }
 
     /**
-     * @param $songId
+     * @param integer $songId
      * @param array $platformIds
      */
     public function storeSongPlatformLinks($songId, array $platformIds)
@@ -887,7 +893,7 @@ 
 
 
     /**
-     * @param $songId
+     * @param integer $songId
      * @param array $instrumentIds
      * @throws \Doctrine\DBAL\Exception\InvalidArgumentException
      */

Spacing +4 added lines, -4 removed lines

@@ -170,7 +170,7 @@ 
         $dataStore = $this;
         $instruments = $dataStore->fetchInstrumentsForSongId($song['id']);
         $instruments = array_map(
-            function (Instrument $instrument) {
+            function(Instrument $instrument) {
                 return $instrument->getName();
             },
             $instruments
@@ -184,7 +184,7 @@ 
 
         $platforms = $dataStore->fetchPlatformsForSongId($song['id']);
         $platforms = array_map(
-            function (Platform $platform) {
+            function(Platform $platform) {
                 return $platform->getName();
             },
             $platforms
@@ -914,7 +914,7 @@ 
 
         $dbConn = $this;
         $instruments = array_map(
-            function ($row) use ($dbConn) {
+            function($row) use ($dbConn) {
                 return $dbConn->buildInstrumentFromDbRow($row);
             },
             $instrumentRows
@@ -937,7 +937,7 @@ 
 
         $dbConn = $this;
         $platforms = array_map(
-            function ($row) use ($dbConn) {
+            function($row) use ($dbConn) {
                 return $dbConn->buildPlatformFromDbRow($row);
             },
             $platformRows