Inspection of "Update usage of choice type to Symfony3" - pamil/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — symfony3 ( 405d0c...88ded0 )

by Kamil

created 2016-11-17 10:13 UTC

Status

Doc Comments +12 added lines patch added patch discarded remove patch

@@ -19,17 +19,25 @@  discard block
 block discarded – undo
  */
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $themeName
+     * @return void
      */
     public function setTheme($themeName);
 
     /**
      * @throws ElementNotFoundException
+     * @return void
      */
     public function unsetTheme();
 
@@ -40,6 +48,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $language
+     * @return void
      */
     public function chooseLocale($language);
 
@@ -52,6 +61,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $currencyCode
+     * @return void
      */
     public function chooseCurrency($currencyCode);
 
@@ -64,6 +74,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $shippingMethod
+     * @return void
      */
     public function chooseShippingMethod($shippingMethod);
 
@@ -76,6 +87,7 @@  discard block
 block discarded – undo
 
     /**
      * @param string $paymentMethod
+     * @return void
      */
     public function choosePaymentMethod($paymentMethod);
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Context/Setup/ShippingContext.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -17,7 +17,6 @@
 block discarded – undo
 use Sylius\Component\Addressing\Model\ZoneInterface;
 use Sylius\Component\Addressing\Repository\ZoneRepositoryInterface;
 use Sylius\Component\Core\Formatter\StringInflector;
-use Sylius\Component\Core\Model\ChannelInterface;
 use Sylius\Component\Core\Model\ShippingMethodInterface;
 use Sylius\Component\Resource\Factory\FactoryInterface;
 use Sylius\Component\Shipping\Calculator\DefaultCalculators;

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/Channel/CreatePageInterface.php 1 patch

Doc Comments +17 added lines patch added patch discarded remove patch

@@ -18,62 +18,79 @@
 block discarded – undo
  */
 interface CreatePageInterface extends BaseCreatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
 
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $name
+     * @return void
      */
     public function nameIt($name);
 
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $description
+     * @return void
      */
     public function describeItAs($description);
 
     /**
      * @param string $hostname
+     * @return void
      */
     public function setHostname($hostname);
 
     /**
      * @param string $color
+     * @return void
      */
     public function defineColor($color);
 
     /**
      * @param string $language
+     * @return void
      */
     public function chooseLocale($language);
 
     /**
      * @param string $currencyCode
+     * @return void
      */
     public function chooseCurrency($currencyCode);
 
     /**
      * @param string $taxZone
+     * @return void
      */
     public function chooseDefaultTaxZone($taxZone);
 
     /**
      * @param string $locale
+     * @return void
      */
     public function chooseDefaultLocale($locale);
 
     /**
      * @param string $currency
+     * @return void
      */
     public function chooseDefaultCurrency($currency);
 
     /**
      * @param string $taxCalculationStrategy
+     * @return void
      */
     public function chooseTaxCalculationStrategy($taxCalculationStrategy);
 }

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Admin/PaymentMethod/CreatePageInterface.php 1 patch

Doc Comments +13 added lines patch added patch discarded remove patch

@@ -18,39 +18,52 @@
 block discarded – undo
  */
 interface CreatePageInterface extends BaseCreatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable();
+
+    /**
+     * @return void
+     */
     public function disable();
 
     /**
      * @param string $name
      * @param string $languageCode
+     * @return void
      */
     public function nameIt($name, $languageCode);
 
     /**
      * @param string $code
+     * @return void
      */
     public function specifyCode($code);
 
     /**
      * @param string $gateway
+     * @return void
      */
     public function chooseGateway($gateway);
 
     /**
      * @param string $channelName
+     * @return void
      */
     public function checkChannel($channelName);
 
     /**
      * @param string $description
      * @param string $languageCode
+     * @return void
      */
     public function describeIt($description, $languageCode);
 
     /**
      * @param string $instructions
      * @param string $languageCode
+     * @return void
      */
     public function setInstructions($instructions, $languageCode);
 

Please login to merge, or discard this patch.

src/Sylius/Behat/Page/Shop/HomePage.php 1 patch

Braces +2 added lines, -1 removed lines patch added patch discarded remove patch

@@ -106,7 +106,8 @@
 block discarded – undo
      * {@inheritdoc}
      */
     public function getLatestProductsNames()
-    {;
+    {
+;
         return array_map(
             function (NodeElement $element) { return $element->getText(); },
             $this->getDocument()->findAll('css', '.sylius-product-name')

Please login to merge, or discard this patch.

src/Sylius/Behat/Context/Setup/PaymentContext.php 1 patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

@@ -17,7 +17,6 @@
 block discarded – undo
 use Sylius\Component\Addressing\Model\ZoneInterface;
 use Sylius\Component\Addressing\Repository\ZoneRepositoryInterface;
 use Sylius\Component\Core\Formatter\StringInflector;
-use Sylius\Component\Core\Model\ChannelInterface;
 use Sylius\Component\Core\Model\ShippingMethodInterface;
 use Sylius\Component\Resource\Factory\FactoryInterface;
 use Sylius\Component\Shipping\Calculator\DefaultCalculators;

Please login to merge, or discard this patch.

		@@ -18,62 +18,79 @@
		block discarded – undo
18	18	*/
19	19	interface CreatePageInterface extends BaseCreatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
22	25
	26	+ /**
	27	+ * @return void
	28	+ */
23	29	public function disable();
24	30
25	31	/**
26	32	* @param string $name
	33	+ * @return void
27	34	*/
28	35	public function nameIt($name);
29	36
30	37	/**
31	38	* @param string $code
	39	+ * @return void
32	40	*/
33	41	public function specifyCode($code);
34	42
35	43	/**
36	44	* @param string $description
	45	+ * @return void
37	46	*/
38	47	public function describeItAs($description);
39	48
40	49	/**
41	50	* @param string $hostname
	51	+ * @return void
42	52	*/
43	53	public function setHostname($hostname);
44	54
45	55	/**
46	56	* @param string $color
	57	+ * @return void
47	58	*/
48	59	public function defineColor($color);
49	60
50	61	/**
51	62	* @param string $language
	63	+ * @return void
52	64	*/
53	65	public function chooseLocale($language);
54	66
55	67	/**
56	68	* @param string $currencyCode
	69	+ * @return void
57	70	*/
58	71	public function chooseCurrency($currencyCode);
59	72
60	73	/**
61	74	* @param string $taxZone
	75	+ * @return void
62	76	*/
63	77	public function chooseDefaultTaxZone($taxZone);
64	78
65	79	/**
66	80	* @param string $locale
	81	+ * @return void
67	82	*/
68	83	public function chooseDefaultLocale($locale);
69	84
70	85	/**
71	86	* @param string $currency
	87	+ * @return void
72	88	*/
73	89	public function chooseDefaultCurrency($currency);
74	90
75	91	/**
76	92	* @param string $taxCalculationStrategy
	93	+ * @return void
77	94	*/
78	95	public function chooseTaxCalculationStrategy($taxCalculationStrategy);
79	96	}

		@@ -18,39 +18,52 @@
		block discarded – undo
18	18	*/
19	19	interface CreatePageInterface extends BaseCreatePageInterface
20	20	{
	21	+ /**
	22	+ * @return void
	23	+ */
21	24	public function enable();
	25	+
	26	+ /**
	27	+ * @return void
	28	+ */
22	29	public function disable();
23	30
24	31	/**
25	32	* @param string $name
26	33	* @param string $languageCode
	34	+ * @return void
27	35	*/
28	36	public function nameIt($name, $languageCode);
29	37
30	38	/**
31	39	* @param string $code
	40	+ * @return void
32	41	*/
33	42	public function specifyCode($code);
34	43
35	44	/**
36	45	* @param string $gateway
	46	+ * @return void
37	47	*/
38	48	public function chooseGateway($gateway);
39	49
40	50	/**
41	51	* @param string $channelName
	52	+ * @return void
42	53	*/
43	54	public function checkChannel($channelName);
44	55
45	56	/**
46	57	* @param string $description
47	58	* @param string $languageCode
	59	+ * @return void
48	60	*/
49	61	public function describeIt($description, $languageCode);
50	62
51	63	/**
52	64	* @param string $instructions
53	65	* @param string $languageCode
	66	+ * @return void
54	67	*/
55	68	public function setInstructions($instructions, $languageCode);
56	69

		@@ -19,17 +19,25 @@ discard block
		block discarded – undo
19	19	*/
20	20	interface UpdatePageInterface extends BaseUpdatePageInterface
21	21	{
	22	+ /**
	23	+ * @return void
	24	+ */
22	25	public function enable();
23	26
	27	+ /**
	28	+ * @return void
	29	+ */
24	30	public function disable();
25	31
26	32	/**
27	33	* @param string $themeName
	34	+ * @return void
28	35	*/
29	36	public function setTheme($themeName);
30	37
31	38	/**
32	39	* @throws ElementNotFoundException
	40	+ * @return void
33	41	*/
34	42	public function unsetTheme();
35	43
		@@ -40,6 +48,7 @@ discard block
		block discarded – undo
40	48
41	49	/**
42	50	* @param string $language
	51	+ * @return void
43	52	*/
44	53	public function chooseLocale($language);
45	54
		@@ -52,6 +61,7 @@ discard block
		block discarded – undo
52	61
53	62	/**
54	63	* @param string $currencyCode
	64	+ * @return void
55	65	*/
56	66	public function chooseCurrency($currencyCode);
57	67
		@@ -64,6 +74,7 @@ discard block
		block discarded – undo
64	74
65	75	/**
66	76	* @param string $shippingMethod
	77	+ * @return void
67	78	*/
68	79	public function chooseShippingMethod($shippingMethod);
69	80
		@@ -76,6 +87,7 @@ discard block
		block discarded – undo
76	87
77	88	/**
78	89	* @param string $paymentMethod
	90	+ * @return void
79	91	*/
80	92	public function choosePaymentMethod($paymentMethod);
81	93

		@@ -17,7 +17,6 @@
		block discarded – undo
17	17	use Sylius\Component\Addressing\Model\ZoneInterface;
18	18	use Sylius\Component\Addressing\Repository\ZoneRepositoryInterface;
19	19	use Sylius\Component\Core\Formatter\StringInflector;
20		-use Sylius\Component\Core\Model\ChannelInterface;
21	20	use Sylius\Component\Core\Model\ShippingMethodInterface;
22	21	use Sylius\Component\Resource\Factory\FactoryInterface;
23	22	use Sylius\Component\Shipping\Calculator\DefaultCalculators;

		@@ -106,7 +106,8 @@
		block discarded – undo
106	106	* {@inheritdoc}
107	107	*/
108	108	public function getLatestProductsNames()
109		- {;
	109	+ {
	110	+;
110	111	return array_map(
111	112	function (NodeElement $element) { return $element->getText(); },
112	113	$this->getDocument()->findAll('css', '.sylius-product-name')

pamil / Sylius

Push — symfony3 ( 405d0c...88ded0 )

Status

Category

Doc Comments +12 added lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch

Doc Comments +17 added lines patch added patch discarded remove patch

Doc Comments +13 added lines patch added patch discarded remove patch

Braces +2 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements -1 removed lines patch added patch discarded remove patch