pamil / Sylius

src/Sylius/Component/Core/OrderProcessing/OrderShipmentProcessor.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 namespace Sylius\Component\Core\OrderProcessing;
 
 use Sylius\Component\Core\Model\OrderInterface;
-use Sylius\Component\Core\Model\OrderItemUnitInterface;
 use Sylius\Component\Core\Model\ShipmentInterface;
 use Sylius\Component\Order\Model\OrderInterface as BaseOrderInterface;
 use Sylius\Component\Order\Processor\OrderProcessorInterface;

etc/psalm/ZendPriorityQueueStub.php

Doc Comments +4 added lines, -4 removed lines

@@ -41,14 +41,14 @@ 
     /**
      * @param mixed $datum
      *
-     * @return bool False if the item was not found, true otherwise.
+     * @return boolean|null False if the item was not found, true otherwise.
      *
      * @psalm-param T $datum
      */
     public function remove($datum) { }
 
     /**
-     * @return bool
+     * @return boolean|null
      */
     public function isEmpty() { }
 
@@ -105,7 +105,7 @@ 
     /**
      * @param mixed $datum
      *
-     * @return bool
+     * @return boolean|null
      *
      * @psalm-param T $datum
      */
@@ -114,7 +114,7 @@ 
     /**
      * @param int $priority
      *
-     * @return bool
+     * @return boolean|null
      */
     public function hasPriority($priority) { }
 

Braces +42 added lines, -14 removed lines

@@ -36,7 +36,9 @@ 
      * @psalm-param T $data
      * @psalm-return PriorityQueue<T>
      */
-    public function insert($data, $priority = 1) { }
+    public function insert($data, $priority = 1)
+    {
+}
 
     /**
      * @param mixed $datum
@@ -45,53 +47,71 @@ 
      *
      * @psalm-param T $datum
      */
-    public function remove($datum) { }
+    public function remove($datum)
+    {
+}
 
     /**
      * @return bool
      */
-    public function isEmpty() { }
+    public function isEmpty()
+    {
+}
 
     /**
      * @return int
      */
-    public function count() { }
+    public function count()
+    {
+}
 
     /**
      * @return mixed
      */
-    public function top() { }
+    public function top()
+    {
+}
 
     /**
      * @return mixed
      */
-    public function extract() { }
+    public function extract()
+    {
+}
 
     /**
      * @return SplPriorityQueue
      *
      * @psalm-return SplPriorityQueue<T>
      */
-    public function getIterator() { }
+    public function getIterator()
+    {
+}
 
     /**
      * @return string
      */
-    public function serialize() { }
+    public function serialize()
+    {
+}
 
     /**
      * @param string $data
      *
      * @return void
      */
-    public function unserialize($data) { }
+    public function unserialize($data)
+    {
+}
 
     /**
      * @param int $flag
      *
      * @return array
      */
-    public function toArray($flag = self::EXTR_DATA) { }
+    public function toArray($flag = self::EXTR_DATA)
+    {
+}
 
     /**
      * @param string $class
@@ -100,7 +120,9 @@ 
      *
      * @psalm-return PriorityQueue<T>
      */
-    public function setInternalQueueClass($class) { }
+    public function setInternalQueueClass($class)
+    {
+}
 
     /**
      * @param mixed $datum
@@ -109,17 +131,23 @@ 
      *
      * @psalm-param T $datum
      */
-    public function contains($datum) { }
+    public function contains($datum)
+    {
+}
 
     /**
      * @param int $priority
      *
      * @return bool
      */
-    public function hasPriority($priority) { }
+    public function hasPriority($priority)
+    {
+}
 
     /**
      * @return void
      */
-    public function __clone() { }
+    public function __clone()
+    {
+}
 }

src/Sylius/Behat/Context/Setup/PromotionContext.php

Doc Comments +5 added lines

@@ -400,6 +400,7 @@ 
 
     /**
      * @Given /^([^"]+) gives ("[^"]+%") discount on shipping to every order$/
+     * @param integer $discount
      */
     public function itGivesPercentageDiscountOnShippingToEveryOrder(PromotionInterface $promotion, $discount)
     {
@@ -725,6 +726,7 @@ 
 
     /**
      * @Given /^([^"]+) gives ("[^"]+%") discount on shipping to every order over ("(?:€|£|\$)[^"]+")$/
+     * @param integer $discount
      */
     public function itGivesDiscountOnShippingToEveryOrderOver(
         PromotionInterface $promotion,
@@ -899,6 +901,9 @@ 
         return $coupon;
     }
 
+    /**
+     * @param string $prefix
+     */
     private function generateCoupons(
         int $amount,
         PromotionInterface $promotion,

src/Sylius/Behat/Page/Admin/PromotionCoupon/GeneratePageInterface.php

Doc Comments +21 added lines

@@ -23,17 +23,38 @@
 
     public function checkGenerationValidation(string $message): bool;
 
+    /**
+     * @return void
+     */
     public function generate(): void;
 
+    /**
+     * @return void
+     */
     public function specifyAmount(?int $amount): void;
 
+    /**
+     * @return void
+     */
     public function specifyCodeLength(?int $codeLength): void;
 
+    /**
+     * @return void
+     */
     public function setExpiresAt(\DateTimeInterface $date): void;
 
+    /**
+     * @return void
+     */
     public function setUsageLimit(int $limit): void;
 
+    /**
+     * @return void
+     */
     public function specifyPrefix(string $prefix): void;
 
+    /**
+     * @return void
+     */
     public function specifySuffix(string $suffix): void;
 }

src/Sylius/Behat/Page/Admin/Channel/CreatePageInterface.php

Doc Comments +51 added lines

@@ -17,37 +17,88 @@
 
 interface CreatePageInterface extends BaseCreatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable(): void;
 
+    /**
+     * @return void
+     */
     public function disable(): void;
 
+    /**
+     * @return void
+     */
     public function nameIt(string $name): void;
 
+    /**
+     * @return void
+     */
     public function specifyCode(string $code): void;
 
+    /**
+     * @return void
+     */
     public function describeItAs(string $description): void;
 
+    /**
+     * @return void
+     */
     public function setHostname(string $hostname): void;
 
+    /**
+     * @return void
+     */
     public function setContactEmail(string $contactEmail): void;
 
+    /**
+     * @return void
+     */
     public function defineColor(string $color): void;
 
+    /**
+     * @return void
+     */
     public function chooseLocale(string $language): void;
 
+    /**
+     * @return void
+     */
     public function chooseCurrency(string $currencyCode): void;
 
+    /**
+     * @return void
+     */
     public function chooseDefaultTaxZone(string $taxZone): void;
 
+    /**
+     * @return void
+     */
     public function chooseDefaultLocale(?string $locale): void;
 
+    /**
+     * @return void
+     */
     public function chooseBaseCurrency(?string $currency): void;
 
+    /**
+     * @return void
+     */
     public function chooseTaxCalculationStrategy(string $taxCalculationStrategy): void;
 
+    /**
+     * @return void
+     */
     public function allowToSkipShippingStep(): void;
 
+    /**
+     * @return void
+     */
     public function allowToSkipPaymentStep(): void;
 
+    /**
+     * @return void
+     */
     public function setType(string $type): void;
 }

src/Sylius/Behat/Page/Admin/Channel/UpdatePageInterface.php

Doc Comments +25 added lines

@@ -18,23 +18,45 @@ 
 
 interface UpdatePageInterface extends BaseUpdatePageInterface
 {
+    /**
+     * @return void
+     */
     public function enable(): void;
 
+    /**
+     * @return void
+     */
     public function disable(): void;
 
+    /**
+     * @return void
+     */
     public function setTheme(string $themeName): void;
 
     /**
      * @throws ElementNotFoundException
+     * @return void
      */
     public function unsetTheme(): void;
 
+    /**
+     * @return void
+     */
     public function chooseLocale(string $language): void;
 
+    /**
+     * @return void
+     */
     public function chooseCurrency(string $currencyCode): void;
 
+    /**
+     * @return void
+     */
     public function chooseDefaultTaxZone(string $taxZone): void;
 
+    /**
+     * @return void
+     */
     public function chooseTaxCalculationStrategy(string $taxCalculationStrategy): void;
 
     public function isCodeDisabled(): bool;
@@ -51,6 +73,9 @@ 
 
     public function isBaseCurrencyDisabled(): bool;
 
+    /**
+     * @return void
+     */
     public function changeType(string $type): void;
 
     public function getType(): string;

src/Sylius/Component/Channel/Model/ChannelInterface.php

Doc Comments +34 added lines

@@ -24,23 +24,57 @@
     ToggleableInterface,
     ResourceInterface
 {
+    /**
+     * @return string|null
+     */
     public function getName(): ?string;
 
+    /**
+     * @param string $name
+     *
+     * @return void
+     */
     public function setName(?string $name): void;
 
+    /**
+     * @return string|null
+     */
     public function getDescription(): ?string;
 
+    /**
+     * @return void
+     */
     public function setDescription(?string $description): void;
 
+    /**
+     * @return string|null
+     */
     public function getHostname(): ?string;
 
+    /**
+     * @return void
+     */
     public function setHostname(?string $hostname): void;
 
+    /**
+     * @return string|null
+     */
     public function getColor(): ?string;
 
+    /**
+     * @return void
+     */
     public function setColor(?string $color): void;
 
+    /**
+     * @return string|null
+     */
     public function getType(): ?string;
 
+    /**
+     * @param string $type
+     *
+     * @return void
+     */
     public function setType(?string $type): void;
 }

src/Sylius/Bundle/ChannelBundle/Form/Type/ChannelType.php

Spacing +1 added lines, -1 removed lines

@@ -51,7 +51,7 @@
                 'label' => 'sylius.form.channel.color',
                 'required' => false,
             ])
-            ->add('type', ChoiceType::class,[
+            ->add('type', ChoiceType::class, [
                 'label' => 'sylius.form.channel.type',
                 'required' => false,
                 'choices' => [