pagantis / prestashop

controllers/front/payment.php

Spacing +24 added lines, -24 removed lines

@@ -28,9 +28,9 @@ 
     {
         if (_PS_VERSION_ < 1.6) {
             Logger::addLog(
-                'Pagantis Exception For user ' .
-                $customer->email .
-                ' : ' .
+                'Pagantis Exception For user '.
+                $customer->email.
+                ' : '.
                 $exception->getMessage(),
                 3,
                 $exception->getCode(),
@@ -40,9 +40,9 @@ 
             );
         } else {
             PrestaShopLogger::addLog(
-                'Pagantis Exception For user ' .
-                $customer->email .
-                ' : ' .
+                'Pagantis Exception For user '.
+                $customer->email.
+                ' : '.
                 $exception->getMessage(),
                 3,
                 $exception->getCode(),
@@ -104,24 +104,24 @@ 
         );
 
         try {
-            $userAddress =  new \Pagantis\OrdersApiClient\Model\Order\User\Address();
+            $userAddress = new \Pagantis\OrdersApiClient\Model\Order\User\Address();
             $userAddress
                 ->setZipCode($shippingAddress->postcode)
-                ->setFullName($shippingAddress->firstname . ' ' . $shippingAddress->lastname)
+                ->setFullName($shippingAddress->firstname.' '.$shippingAddress->lastname)
                 ->setCountryCode($this->language)
                 ->setCity($shippingAddress->city)
-                ->setAddress($shippingAddress->address1 . ' ' . $shippingAddress->address2)
+                ->setAddress($shippingAddress->address1.' '.$shippingAddress->address2)
                 ->setTaxId($this->getTaxId($customer, $shippingAddress, $billingAddress))
                 ->setNationalId($this->getNationalId($customer, $shippingAddress, $billingAddress))
             ;
 
-            $orderShippingAddress =  new \Pagantis\OrdersApiClient\Model\Order\User\Address();
+            $orderShippingAddress = new \Pagantis\OrdersApiClient\Model\Order\User\Address();
             $orderShippingAddress
                 ->setZipCode($shippingAddress->postcode)
-                ->setFullName($shippingAddress->firstname . ' ' . $shippingAddress->lastname)
+                ->setFullName($shippingAddress->firstname.' '.$shippingAddress->lastname)
                 ->setCountryCode($this->language)
                 ->setCity($shippingAddress->city)
-                ->setAddress($shippingAddress->address1 . ' ' . $shippingAddress->address2)
+                ->setAddress($shippingAddress->address1.' '.$shippingAddress->address2)
                 ->setTaxId($this->getTaxId($customer, $shippingAddress, $billingAddress))
                 ->setNationalId($this->getNationalId($customer, $shippingAddress, $billingAddress))
                 ->setFixPhone($shippingAddress->phone)
@@ -131,10 +131,10 @@ 
             $orderBillingAddress = new \Pagantis\OrdersApiClient\Model\Order\User\Address();
             $orderBillingAddress
                 ->setZipCode($billingAddress->postcode)
-                ->setFullName($billingAddress->firstname . ' ' . $billingAddress->lastname)
+                ->setFullName($billingAddress->firstname.' '.$billingAddress->lastname)
                 ->setCountryCode($this->language)
                 ->setCity($billingAddress->city)
-                ->setAddress($billingAddress->address1 . ' ' . $billingAddress->address2)
+                ->setAddress($billingAddress->address1.' '.$billingAddress->address2)
                 ->setTaxId($this->getTaxId($customer, $billingAddress, $shippingAddress))
                 ->setNationalId($this->getNationalId($customer, $billingAddress, $shippingAddress))
                 ->setFixPhone($billingAddress->phone)
@@ -154,7 +154,7 @@ 
                 ->setNationalId($this->getNationalId($customer, $shippingAddress, $billingAddress))
             ;
 
-            if ($customer->birthday!='0000-00-00') {
+            if ($customer->birthday != '0000-00-00') {
                 $orderUser->setDateOfBirth($customer->birthday);
             }
 
@@ -188,13 +188,13 @@ 
                     ->setQuantity($item['quantity'])
                     ->setDescription($item['name']);
                 if ($promotedProduct) {
-                    $promotedAmount+=$product->getAmount();
+                    $promotedAmount += $product->getAmount();
                     $productId = $item['id_product'];
                     $finalPrice = Product::getPriceStatic($productId);
-                    $promotedMessage = 'Promoted Item: ' . $product->getDescription() .
-                         ' Price: ' . $finalPrice .
-                         ' Qty: ' . $product->getQuantity() .
-                         ' Item ID: ' . $item['id_product'];
+                    $promotedMessage = 'Promoted Item: '.$product->getDescription().
+                         ' Price: '.$finalPrice.
+                         ' Qty: '.$product->getQuantity().
+                         ' Item ID: '.$item['id_product'];
                     $metadataOrder->addMetadata('promotedProduct', $promotedMessage);
                 }
                 $details->addProduct($product);
@@ -244,7 +244,7 @@ 
             Tools::redirect($cancelUrl);
         }
 
-        $url ='';
+        $url = '';
         try {
             $orderClient = new \Pagantis\OrdersApiClient\Client(
                 $pagantisPublicKey,
@@ -255,12 +255,12 @@ 
             if ($order instanceof \Pagantis\OrdersApiClient\Model\Order) {
                 $url = $order->getActionUrls()->getForm();
                 $orderId = $order->getId();
-                $sql = "INSERT INTO `" . _DB_PREFIX_ . "pagantis_order` (`id`, `order_id`, `ps_order_id`)
+                $sql = "INSERT INTO `"._DB_PREFIX_."pagantis_order` (`id`, `order_id`, `ps_order_id`)
                      VALUES ('$cart->id','$orderId', null) 
                      ON DUPLICATE KEY UPDATE `order_id` = '$orderId'";
                 $result = Db::getInstance()->execute($sql);
                 if (!$result) {
-                    throw new UnknownException('Unable to save pagantis-order-id in database: '. $sql);
+                    throw new UnknownException('Unable to save pagantis-order-id in database: '.$sql);
                 }
             } else {
                 throw new OrderNotFoundException();
@@ -359,7 +359,7 @@ 
         if (count($langArray) != 2 && isset($lang['locale'])) {
             $langArray = explode("-", $lang['locale']);
         }
-        $this->language = Tools::strtoupper($langArray[count($langArray)-1]);
+        $this->language = Tools::strtoupper($langArray[count($langArray) - 1]);
         // Prevent null language detection
         $this->language = ($this->language) ? $this->language : 'ES';
     }

controllers/front/notify.php

Spacing +26 added lines, -26 removed lines

@@ -207,7 +207,7 @@ 
     private function getPagantisOrderId()
     {
         try {
-            $this->pagantisOrderId= Db::getInstance()->getValue(
+            $this->pagantisOrderId = Db::getInstance()->getValue(
                 'select order_id from '._DB_PREFIX_.'pagantis_order where id = '.$this->merchantOrderId
             );
 
@@ -269,20 +269,20 @@ 
         $merchantAmount = explode('.', explode(',', $merchantAmount)[0])[0];
         if ($totalAmount != $merchantAmount) {
             try {
-                $psTotalAmount = substr_replace($merchantAmount, '.', (Tools::strlen($merchantAmount) -2), 0);
+                $psTotalAmount = substr_replace($merchantAmount, '.', (Tools::strlen($merchantAmount) - 2), 0);
 
                 $pgTotalAmountInCents = (string) $this->pagantisOrder->getShoppingCart()->getTotalAmount();
                 $pgTotalAmount = substr_replace(
                     $pgTotalAmountInCents,
                     '.',
-                    (Tools::strlen($pgTotalAmountInCents) -2),
+                    (Tools::strlen($pgTotalAmountInCents) - 2),
                     0
                 );
 
-                $this->amountMismatchError = '. Amount mismatch in PrestaShop Order #'. $this->merchantOrderId .
-                    ' compared with Pagantis Order: ' . $this->pagantisOrderId .
-                    '. The order in PrestaShop has an amount of ' . $psTotalAmount . ' and in Pagantis ' .
-                    $pgTotalAmount . ' PLEASE REVIEW THE ORDER';
+                $this->amountMismatchError = '. Amount mismatch in PrestaShop Order #'.$this->merchantOrderId.
+                    ' compared with Pagantis Order: '.$this->pagantisOrderId.
+                    '. The order in PrestaShop has an amount of '.$psTotalAmount.' and in Pagantis '.
+                    $pgTotalAmount.' PLEASE REVIEW THE ORDER';
                 $this->saveLog(array(
                     'message' => $this->amountMismatchError
                 ));
@@ -305,13 +305,13 @@ 
             }
 
             // Double check
-            $tableName = _DB_PREFIX_ . 'pagantis_order';
-            $sql = ('select ps_order_id from `' . $tableName . '` where `id` = ' . $this->merchantOrderId
-                . ' and `order_id` = \'' . $this->pagantisOrderId . '\''
+            $tableName = _DB_PREFIX_.'pagantis_order';
+            $sql = ('select ps_order_id from `'.$tableName.'` where `id` = '.$this->merchantOrderId
+                . ' and `order_id` = \''.$this->pagantisOrderId.'\''
                 . ' and `ps_order_id` is not null');
             $results = Db::getInstance()->ExecuteS($sql);
             if (is_array($results) && count($results) === 1) {
-                throw new WrongStatusException('PS->record found in ' . $tableName . ': already_processed');
+                throw new WrongStatusException('PS->record found in '.$tableName.': already_processed');
             }
         } catch (\Exception $exception) {
             throw new UnknownException($exception->getMessage());
@@ -340,9 +340,9 @@ 
                 Configuration::get('PS_OS_PAYMENT'),
                 $this->merchantOrder->getOrderTotal(true),
                 $this->module->displayName,
-                'pagantisOrderId: ' . $this->pagantisOrder->getId() . ' ' .
-                'pagantisOrderStatus: '. $this->pagantisOrder->getStatus() .
-                $this->amountMismatchError .
+                'pagantisOrderId: '.$this->pagantisOrder->getId().' '.
+                'pagantisOrderStatus: '.$this->pagantisOrder->getStatus().
+                $this->amountMismatchError.
                 $metadataInfo,
                 array('transaction_id' => $this->pagantisOrderId),
                 null,
@@ -356,7 +356,7 @@ 
             Db::getInstance()->update(
                 'pagantis_order',
                 array('ps_order_id' => $this->module->currentOrder),
-                'id = \''. $this->merchantOrderId . '\' and order_id = \'' . $this->pagantisOrderId . '\''
+                'id = \''.$this->merchantOrderId.'\' and order_id = \''.$this->pagantisOrderId.'\''
             );
         } catch (\Exception $exception) {
             // Do nothing
@@ -374,9 +374,9 @@ 
             $this->orderClient->confirmOrder($this->pagantisOrderId);
             try {
                 $mode = ($_SERVER['REQUEST_METHOD'] == 'POST') ? 'NOTIFICATION' : 'REDIRECTION';
-                $message = 'Order CONFIRMED. The order was confirmed by a ' . $mode .
-                    '. Pagantis OrderId=' . $this->pagantisOrderId .
-                    '. Prestashop OrderId=' . $this->module->currentOrder;
+                $message = 'Order CONFIRMED. The order was confirmed by a '.$mode.
+                    '. Pagantis OrderId='.$this->pagantisOrderId.
+                    '. Prestashop OrderId='.$this->module->currentOrder;
                 $this->saveLog(array(
                     'message' => $message
                 ));
@@ -423,7 +423,7 @@ 
             );
             $resultSeconds = Db::getInstance()->getValue($query);
             $restSeconds = isset($resultSeconds) ? ($resultSeconds) : 0;
-            $secondsToExpire = ($restSeconds>self::CONCURRENCY_TIMEOUT) ? self::CONCURRENCY_TIMEOUT : $restSeconds;
+            $secondsToExpire = ($restSeconds > self::CONCURRENCY_TIMEOUT) ? self::CONCURRENCY_TIMEOUT : $restSeconds;
 
             $logMessage = sprintf(
                 "Redirect concurrency, User have to wait %s seconds, default seconds %s, bd time to expire %s seconds",
@@ -435,7 +435,7 @@ 
             $this->saveLog(array(
                 'message' => $logMessage
             ));
-            sleep($secondsToExpire+1);
+            sleep($secondsToExpire + 1);
             // After waiting...user continue the confirmation, hoping that previous call have finished.
             return true;
         }
@@ -452,12 +452,12 @@ 
             if (is_null($orderId)) {
                 Db::getInstance()->delete(
                     'pagantis_cart_process',
-                    'timestamp < ' . (time() - self::CONCURRENCY_TIMEOUT
+                    'timestamp < '.(time() - self::CONCURRENCY_TIMEOUT
                     )
                 );
                 return;
             }
-            Db::getInstance()->delete('pagantis_cart_process', 'id = \'' . $orderId . '\'');
+            Db::getInstance()->delete('pagantis_cart_process', 'id = \''.$orderId.'\'');
         } catch (\Exception $exception) {
             throw new ConcurrencyException();
         }
@@ -479,8 +479,8 @@ 
         $data = array(
             'merchantOrderId' => $this->merchantOrderId,
             'pagantisOrderId' => $this->pagantisOrderId,
-            'message' => ($exception)? $exception->getMessage() : 'Unable to get Exception message',
-            'statusCode' => ($exception)? $exception->getCode() : 'Unable to get Exception statusCode',
+            'message' => ($exception) ? $exception->getMessage() : 'Unable to get Exception message',
+            'statusCode' => ($exception) ? $exception->getCode() : 'Unable to get Exception statusCode',
             'method' => $method,
             'file' => __FILE__,
             'line' => $line,
@@ -504,9 +504,9 @@ 
             'id_cart' => $this->merchantOrderId,
             'key' => $this->config['secureKey'],
             'id_module' => $this->module->id,
-            'id_order' => ($this->pagantisOrder)?$this->pagantisOrder->getId(): null,
+            'id_order' => ($this->pagantisOrder) ? $this->pagantisOrder->getId() : null,
         );
-        $url = ($error)? $this->config['urlKO'] : $this->config['urlOK'];
+        $url = ($error) ? $this->config['urlKO'] : $this->config['urlOK'];
         return $this->redirect($url, $parameters);
     }
 }
\ No newline at end of file