pagantis / oscommerce

test/configure/ConfigureTest.php

Indentation -1 removed lines

@@ -11,7 +11,6 @@
  * @package Test\Configure
  *
  * @group oscommerce-configure
-
  */
 class ConfigureTest extends PagantisOscommerceTest
 {

test/basic/BasicTest.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
         $this->webDriver->get(self::OSCURL);
         $condition = WebDriverExpectedCondition::titleContains(self::TITLE);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
         $this->quit();
     }
 
@@ -42,7 +42,7 @@ 
         $this->webDriver->get(self::OSCURL.self::BACKOFFICE_FOLDER);
         $condition = WebDriverExpectedCondition::titleContains(self::ADMIN_TITLE);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
         $this->quit();
     }
 }
\ No newline at end of file

test/PagantisOscommerceTest.php

Spacing +10 added lines, -10 removed lines

@@ -73,16 +73,16 @@ 
         $faker = Factory::create();
         $this->configuration['dni'] = $this->getDNI();
         $this->configuration['birthdate'] =
-            $faker->numberBetween(1, 28) . '/' .
-            $faker->numberBetween(1, 12). '/1975'
+            $faker->numberBetween(1, 28).'/'.
+            $faker->numberBetween(1, 12).'/1975'
         ;
         $this->configuration['firstname'] = $faker->firstName;
-        $this->configuration['lastname'] = $faker->lastName . ' ' . $faker->lastName;
+        $this->configuration['lastname'] = $faker->lastName.' '.$faker->lastName;
         $this->configuration['company'] = $faker->company;
         $this->configuration['zip'] = '28'.$faker->randomNumber(3, true);
         $this->configuration['street'] = $faker->streetAddress;
-        $this->configuration['phone'] = '6' . $faker->randomNumber(8);
-        $this->configuration['email'] = date('ymd') . '@pagamastarde.com';
+        $this->configuration['phone'] = '6'.$faker->randomNumber(8);
+        $this->configuration['email'] = date('ymd').'@pagamastarde.com';
         parent::__construct($name, $data, $dataName);
     }
     /**
@@ -90,12 +90,12 @@ 
      */
     protected function getDNI()
     {
-        $dni = '0000' . rand(pow(10, 4-1), pow(10, 4)-1);
-        $value = (int) ($dni / 23);
+        $dni = '0000'.rand(pow(10, 4 - 1), pow(10, 4) - 1);
+        $value = (int)($dni / 23);
         $value *= 23;
-        $value= $dni - $value;
-        $letter= "TRWAGMYFPDXBNJZSQVHLCKEO";
-        $dniLetter= substr($letter, $value, 1);
+        $value = $dni - $value;
+        $letter = "TRWAGMYFPDXBNJZSQVHLCKEO";
+        $dniLetter = substr($letter, $value, 1);
         return $dni.$dniLetter;
     }
 

config/configure_admin.php

Spacing +14 added lines, -14 removed lines

@@ -17,21 +17,21 @@
 define('DIR_WS_HTTPS_CATALOG', '/');
 define('DIR_FS_CATALOG', '/var/www/html/');
 define('DIR_WS_IMAGES', 'images/');
-define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
-define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG . 'images/');
+define('DIR_WS_ICONS', DIR_WS_IMAGES.'icons/');
+define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG.'images/');
 define('DIR_WS_INCLUDES', 'includes/');
-define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/');
-define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
-define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
-define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
-define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
-define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG . 'includes/languages/');
-define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG . 'includes/languages/');
-define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG . 'images/');
-define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG . 'includes/modules/');
-define('DIR_FS_BACKUP', DIR_FS_ADMIN . 'backups/');
-define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG . 'download/');
-define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG . 'pub/');
+define('DIR_WS_BOXES', DIR_WS_INCLUDES.'boxes/');
+define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES.'functions/');
+define('DIR_WS_CLASSES', DIR_WS_INCLUDES.'classes/');
+define('DIR_WS_MODULES', DIR_WS_INCLUDES.'modules/');
+define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES.'languages/');
+define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG.'includes/languages/');
+define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG.'includes/languages/');
+define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG.'images/');
+define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG.'includes/modules/');
+define('DIR_FS_BACKUP', DIR_FS_ADMIN.'backups/');
+define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG.'download/');
+define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG.'pub/');
 
 define('DB_SERVER', getenv('OSCOMMERCE_DB_HOST'));
 define('DB_SERVER_USERNAME', getenv('OSCOMMERCE_DB_USER'));

config/configure.php

Spacing +7 added lines, -7 removed lines

@@ -9,17 +9,17 @@
 define('DIR_WS_HTTP_CATALOG', '/');
 define('DIR_WS_HTTPS_CATALOG', '/');
 define('DIR_WS_IMAGES', 'images/');
-define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
+define('DIR_WS_ICONS', DIR_WS_IMAGES.'icons/');
 define('DIR_WS_INCLUDES', 'includes/');
-define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
-define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
-define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
-define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
+define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES.'functions/');
+define('DIR_WS_CLASSES', DIR_WS_INCLUDES.'classes/');
+define('DIR_WS_MODULES', DIR_WS_INCLUDES.'modules/');
+define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES.'languages/');
 
 define('DIR_WS_DOWNLOAD_PUBLIC', 'pub/');
 define('DIR_FS_CATALOG', '/var/www/html');
-define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG . 'download/');
-define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG . 'pub/');
+define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG.'download/');
+define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG.'pub/');
 
 define('DB_SERVER', getenv('OSCOMMERCE_DB_HOST'));
 define('DB_SERVER_USERNAME', getenv('OSCOMMERCE_DB_USER'));

catalog/includes/modules/payment/pagantis.php

Indentation +29 added lines, -29 removed lines

@@ -29,26 +29,26 @@ 
     public $order_id;
 
     public $defaultConfigs = array('PMT_TITLE'=>'Instant Financing',
-                                   'PMT_SIMULATOR_DISPLAY_TYPE'=>'pmtSDK.simulator.types.SIMPLE',
-                                   'PMT_SIMULATOR_DISPLAY_SKIN'=>'pmtSDK.simulator.skins.BLUE',
-                                   'PMT_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
-                                   'PMT_SIMULATOR_START_INSTALLMENTS'=>3,
-                                   'PMT_SIMULATOR_MAX_INSTALLMENTS'=>12,
-                                   'PMT_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
-                                   'PMT_SIMULATOR_DISPLAY_CSS_POSITION'=>'pmtSDK.simulator.positions.INNER',
-                                   'PMT_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
-                                   'PMT_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
-                                   'PMT_FORM_DISPLAY_TYPE'=>0,
-                                   'PMT_DISPLAY_MIN_AMOUNT'=>1,
-                                   'PMT_URL_OK'=>'',
-                                   'PMT_URL_KO'=>'',
-                                   'PMT_TITLE_EXTRA' => 'Paga hasta en 12 cómodas cuotas con Paga+Tarde. Solicitud totalmente 
+                                    'PMT_SIMULATOR_DISPLAY_TYPE'=>'pmtSDK.simulator.types.SIMPLE',
+                                    'PMT_SIMULATOR_DISPLAY_SKIN'=>'pmtSDK.simulator.skins.BLUE',
+                                    'PMT_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
+                                    'PMT_SIMULATOR_START_INSTALLMENTS'=>3,
+                                    'PMT_SIMULATOR_MAX_INSTALLMENTS'=>12,
+                                    'PMT_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
+                                    'PMT_SIMULATOR_DISPLAY_CSS_POSITION'=>'pmtSDK.simulator.positions.INNER',
+                                    'PMT_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
+                                    'PMT_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
+                                    'PMT_FORM_DISPLAY_TYPE'=>0,
+                                    'PMT_DISPLAY_MIN_AMOUNT'=>1,
+                                    'PMT_URL_OK'=>'',
+                                    'PMT_URL_KO'=>'',
+                                    'PMT_TITLE_EXTRA' => 'Paga hasta en 12 cómodas cuotas con Paga+Tarde. Solicitud totalmente 
                             online y sin papeleos,¡y la respuesta es inmediata!'
     );
 
     /**
-    * Constructor
-    */
+     * Constructor
+     */
     public function __construct()
     {
         global $order;
@@ -97,8 +97,8 @@ 
      **************/
 
     /**
-    * Here you can implement using payment zones (refer to standard PayPal module as reference)
-    */
+     * Here you can implement using payment zones (refer to standard PayPal module as reference)
+     */
     public function update_status()
     {
         global $order, $db;
@@ -366,10 +366,10 @@ 
     }
 
     /**
-    * Post-processing activities
-    *
-    * @return boolean
-    */
+     * Post-processing activities
+     *
+     * @return boolean
+     */
     public function after_process()
     {
         global $insert_id, $order, $currencies;
@@ -527,16 +527,16 @@ 
     }
 
     /**
-    * Internal list of configuration keys used for configuration of the module
-    *
-    * @return array
-    */
+     * Internal list of configuration keys used for configuration of the module
+     *
+     * @return array
+     */
     public function keys()
     {
         return array('MODULE_PAYMENT_PAGANTIS_STATUS',
-           'MODULE_PAYMENT_PAGANTIS_PK',
-           'MODULE_PAYMENT_PAGANTIS_SK',
-           'MODULE_PAYMENT_PAGANTIS_SIMULATOR');
+            'MODULE_PAYMENT_PAGANTIS_PK',
+            'MODULE_PAYMENT_PAGANTIS_SK',
+            'MODULE_PAYMENT_PAGANTIS_SIMULATOR');
     }
 
     /**

Spacing +36 added lines, -36 removed lines

@@ -57,7 +57,7 @@ 
 
         if (strpos($_SERVER[REQUEST_URI], "checkout_payment.php") <= 0) {
             $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_ADMIN_TITLE; // Payment module title in Admin
-        } else {
+        }else {
             $this->title = MODULE_PAYMENT_PAGANTIS_TEXT_CATALOG_TITLE; // Payment module title in Catalog
         }
 
@@ -69,7 +69,7 @@ 
             $this->order_status = MODULE_PAYMENT_PAGANTIS_ORDER_STATUS_ID;
         }
 
-        if (strpos($_SERVER[REQUEST_URI], "checkout_confirmation.php")!==false && $_SESSION['order_id']) {
+        if (strpos($_SERVER[REQUEST_URI], "checkout_confirmation.php") !== false && $_SESSION['order_id']) {
             if ($pmtOrderId = $this->getPmtOrderId($_SESSION['order_id'])) {
                 $this->form_action_url = "https://form.pagamastarde.com/orders/$pmtOrderId";
             }
@@ -87,7 +87,7 @@ 
                 $_SERVER['REQUEST_URI']
             )
         );
-        $this->form_action_url = $this->base_url . '/catalog/ext/modules/payment/pagantis/bypass.php';
+        $this->form_action_url = $this->base_url.'/catalog/ext/modules/payment/pagantis/bypass.php';
     }
 
     /***************
@@ -106,14 +106,14 @@ 
         if (strpos($_SERVER[REQUEST_URI], "checkout_process.php") > 0) {
             if ($_POST) {
                 die('aqui hemos llegado por notificación');
-            } else {
+            }else {
                 echo "pasamos de largo pq es un GET";
             }
         }
 
         if ($this->enabled && (int)MODULE_PAYMENT_PAGANTIS_ZONE > 0 && isset($order->billing['country']['id'])) {
             $check_flag = false;
-            $check_query = tep_db_query("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_PAGANTIS_ZONE . "' and zone_country_id = '" . (int)$order->billing['country']['id'] . "' order by zone_id");
+            $check_query = tep_db_query("select zone_id from ".TABLE_ZONES_TO_GEO_ZONES." where geo_zone_id = '".MODULE_PAYMENT_PAGANTIS_ZONE."' and zone_country_id = '".(int)$order->billing['country']['id']."' order by zone_id");
             while ($check = tep_db_fetch_array($check_query)) {
                 if ($check['zone_id'] < 1) {
                     $check_flag = true;
@@ -213,7 +213,7 @@ 
             $id_hash = time().serialize($order->products).''.serialize($order->customer).''.serialize($order->delivery);
             $this->order_id = md5($id_hash);
             $_SESSION['order_id'] = $this->order_id;
-            $sql = sprintf("insert into " . TABLE_PAGANTIS . " (order_id) values ('%s')", $this->order_id);
+            $sql = sprintf("insert into ".TABLE_PAGANTIS." (order_id) values ('%s')", $this->order_id);
             tep_db_query($sql);
 
             $userAddress = new Address();
@@ -326,16 +326,16 @@ 
                 $url = $pagantisOrder->getActionUrls()->getForm();
                 $this->insertRow($this->order_id, serialize($global_vars));
                 die($this->order_id);
-            } else {
+            }else {
                 throw new OrderNotFoundException();
             }
 
             if ($url == "") {
                 throw new UnknownException(_("No ha sido posible obtener una respuesta de Pagantis"));
-            } else { //if ($this->extraConfig['PAGANTIS_FORM_DISPLAY_TYPE'] == '0') {
+            }else { //if ($this->extraConfig['PAGANTIS_FORM_DISPLAY_TYPE'] == '0') {
                 $output = "\n";
-                $output.= tep_draw_hidden_field("formUrl", $url) . "\n";
-                $output.= tep_draw_hidden_field("cancelUrl", $cancelUrl) . "\n";
+                $output .= tep_draw_hidden_field("formUrl", $url)."\n";
+                $output .= tep_draw_hidden_field("cancelUrl", $cancelUrl)."\n";
                 return $output;
             } /*else {
                 $template_fields = array(
@@ -359,7 +359,7 @@ 
     {
         if (!$_POST) {
             die('aqui hemos llegado por order');
-        } else {
+        }else {
             echo "pasamos de largo pq es un POST y ya debe estar verificado";
         }
         exit;
@@ -382,7 +382,7 @@ 
         if (MODULE_PAYMENT_PAGANTIS_TESTMODE == 'Test') {
             $secret_key = MODULE_PAYMENT_PAGANTIS_TSK;
             $public_key = MODULE_PAYMENT_PAGANTIS_TK;
-        } else {
+        }else {
             $secret_key = MODULE_PAYMENT_PAGANTIS_PSK;
             $public_key = MODULE_PAYMENT_PAGANTIS_PK;
         }
@@ -405,8 +405,8 @@ 
         }
         //$this->notify('NOTIFY_PAYMENT_AUTHNETSIM_POSTPROCESS_HOOK');
         if ($notififcation_check && $this->notification['event'] == 'charge.created') {
-            $sql = "insert into " . TABLE_ORDERS_STATUS_HISTORY . " (comments, orders_id, orders_status_id, customer_notified, date_added) values
-            ('".'Pagantis.  Transaction ID: ' .$this->notification['data']['id']."', ".$insert_id.", '".$this->order_status."', -1, now() )";
+            $sql = "insert into ".TABLE_ORDERS_STATUS_HISTORY." (comments, orders_id, orders_status_id, customer_notified, date_added) values
+            ('".'Pagantis.  Transaction ID: '.$this->notification['data']['id']."', ".$insert_id.", '".$this->order_status."', -1, now() )";
             tep_db_query($sql);
         }
         unset($_SESSION['order_id']);
@@ -421,7 +421,7 @@ 
     public function check()
     {
         if (!isset($this->_check)) {
-            $check_query = tep_db_query("select configuration_value from " . TABLE_CONFIGURATION . " where configuration_key = 'MODULE_PAYMENT_PAGANTIS_STATUS'");
+            $check_query = tep_db_query("select configuration_value from ".TABLE_CONFIGURATION." where configuration_key = 'MODULE_PAYMENT_PAGANTIS_STATUS'");
             $this->_check = tep_db_num_rows($check_query);
         }
         $this->install_pagantis_tables();
@@ -440,10 +440,10 @@ 
             tep_redirect(tep_href_link(FILENAME_MODULES, 'set=payment&module=pagantis', 'NONSSL'));
             return 'failed';
         }
-        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_PAYMENT_PAGANTIS_STATUS', 'True', '', '6', '0', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Public Key', 'MODULE_PAYMENT_PAGANTIS_PK', '', 'MANDATORY. You can get in your pagantis profile', '6', '0', now())");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Secret Key', 'MODULE_PAYMENT_PAGANTIS_SK', '', 'MANDATORY. You can get in your pagantis profile', '6', '0', now())");
-        tep_db_query("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Include simulator', 'MODULE_PAYMENT_PAGANTIS_SIMULATOR', 'True', 'Do you want to include simulator in product page?', '6', '3', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
+        tep_db_query("insert into ".TABLE_CONFIGURATION." (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Pagantis Module', 'MODULE_PAYMENT_PAGANTIS_STATUS', 'True', '', '6', '0', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
+        tep_db_query("insert into ".TABLE_CONFIGURATION." (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Public Key', 'MODULE_PAYMENT_PAGANTIS_PK', '', 'MANDATORY. You can get in your pagantis profile', '6', '0', now())");
+        tep_db_query("insert into ".TABLE_CONFIGURATION." (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Secret Key', 'MODULE_PAYMENT_PAGANTIS_SK', '', 'MANDATORY. You can get in your pagantis profile', '6', '0', now())");
+        tep_db_query("insert into ".TABLE_CONFIGURATION." (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Include simulator', 'MODULE_PAYMENT_PAGANTIS_SIMULATOR', 'True', 'Do you want to include simulator in product page?', '6', '3', 'tep_cfg_select_option(array(\'True\', \'False\'), ', now())");
 
         $this->install_pagantis_tables();
     }
@@ -453,7 +453,7 @@ 
      */
     private function install_pagantis_tables()
     {
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS." (
             `id` int(11) NOT NULL auto_increment,
             `insert_date` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP,
             `order_id` varchar(150) NOT NULL,
@@ -462,32 +462,32 @@ 
             KEY (order_id))";
         tep_db_query($sql);
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_LOG . " ( 
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_LOG." ( 
                           id int NOT NULL AUTO_INCREMENT, 
                           log text NOT NULL, 
                           createdAt timestamp DEFAULT CURRENT_TIMESTAMP, 
                           UNIQUE KEY id (id))";
         tep_db_query($sql);
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_CONFIG . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_CONFIG." (
                             id int NOT NULL AUTO_INCREMENT, 
                             config varchar(60) NOT NULL, 
                             value varchar(100) NOT NULL, 
                             UNIQUE KEY id(id))";
         tep_db_query($sql);
         foreach ((array)$this->extraConfig as $configKey => $configValue) {
-            $query = "INSERT INTO " . TABLE_PAGANTIS_CONFIG . " (config, value) values ($configKey, $configValue)";
+            $query = "INSERT INTO ".TABLE_PAGANTIS_CONFIG." (config, value) values ($configKey, $configValue)";
             tep_db_query($query);
         }
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_ORDERS . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_ORDERS." (
                             id int NOT NULL AUTO_INCREMENT, 
                             os_order_id varchar(50) NOT NULL, 
                             pmt_order_id varchar(50) NOT NULL, 
                             UNIQUE KEY id(id))";
         tep_db_query($sql);
 
-        $sql = "CREATE TABLE IF NOT EXISTS " . TABLE_PAGANTIS_CONCURRENCY . " (
+        $sql = "CREATE TABLE IF NOT EXISTS ".TABLE_PAGANTIS_CONCURRENCY." (
                             id int NOT NULL,
                             `timestamp` TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
                             UNIQUE KEY id(id))";
@@ -501,28 +501,28 @@ 
     {
         $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("delete from " . TABLE_CONFIGURATION . " where configuration_key in ('" . implode("', '", $this->keys()) . "')");
-            tep_db_query("drop table " . TABLE_PAGANTIS);
+            tep_db_query("delete from ".TABLE_CONFIGURATION." where configuration_key in ('".implode("', '", $this->keys())."')");
+            tep_db_query("drop table ".TABLE_PAGANTIS);
         }
 
         $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_LOG."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_LOG);
+            tep_db_query("drop table ".TABLE_PAGANTIS_LOG);
         }
 
         $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_CONFIG."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_CONFIG);
+            tep_db_query("drop table ".TABLE_PAGANTIS_CONFIG);
         }
 
         $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_ORDERS."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_ORDERS);
+            tep_db_query("drop table ".TABLE_PAGANTIS_ORDERS);
         }
 
         $checkTable = tep_db_query("SHOW TABLES LIKE '".TABLE_PAGANTIS_CONCURRENCY."'");
         if (tep_db_num_rows($checkTable) > 0) {
-            tep_db_query("drop table " . TABLE_PAGANTIS_CONCURRENCY);
+            tep_db_query("drop table ".TABLE_PAGANTIS_CONCURRENCY);
         }
     }
 
@@ -592,13 +592,13 @@ 
      */
     private function insertRow($orderId, $pmtOrderId)
     {
-        $query = "select * from ". TABLE_PAGANTIS_ORDERS ." where os_order_id='$orderId'";
+        $query = "select * from ".TABLE_PAGANTIS_ORDERS." where os_order_id='$orderId'";
         $resultsSelect = tep_db_query($query);
         $countResults = tep_db_num_rows($resultsSelect);
         if ($countResults == 0) {
-            $query = "INSERT INTO " . TABLE_PAGANTIS_ORDERS ."(os_order_id, pmt_order_id) values ('$orderId', '$pmtOrderId')";
-        } else {
-            $query = "UPDATE " . TABLE_PAGANTIS_ORDERS . " set pmt_order_id='$pmtOrderId' where os_order_id='$orderId'";
+            $query = "INSERT INTO ".TABLE_PAGANTIS_ORDERS."(os_order_id, pmt_order_id) values ('$orderId', '$pmtOrderId')";
+        }else {
+            $query = "UPDATE ".TABLE_PAGANTIS_ORDERS." set pmt_order_id='$pmtOrderId' where os_order_id='$orderId'";
         }
         tep_db_query($query);
     }
@@ -623,7 +623,7 @@ 
     private function getPmtOrderId($osOrderId)
     {
         $result = '';
-        $query = "select pmt_order_id from ". TABLE_PAGANTIS_ORDERS ." where os_order_id='$osOrderId'";
+        $query = "select pmt_order_id from ".TABLE_PAGANTIS_ORDERS." where os_order_id='$osOrderId'";
         $resultsSelect = tep_db_query($query);
         while ($orderRow = tep_db_fetch_array($resultsSelect)) {
             $result = $orderRow['pmt_order_id'];

catalog/includes/languages/espanol/modules/payment/pagantis.php

Spacing +2 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
 
   $publicKey = MODULE_PAYMENT_PAGANTIS_PK;
   $widget = '';
-  if ( MODULE_PAYMENT_PAGANTIS_SIMULATOR == 'True' )
+  if (MODULE_PAYMENT_PAGANTIS_SIMULATOR == 'True')
   {
       $widget = '<script>
     var simulatorId = null;
@@ -50,7 +50,7 @@ 
 <div class="PagantisSimulator"></div>';
 }
 
-  define('MODULE_PAYMENT_PAGANTIS_TEXT_CATALOG_TITLE', 'Instant financing'. $widget);  // Payment option title as displayed to the customer
+  define('MODULE_PAYMENT_PAGANTIS_TEXT_CATALOG_TITLE', 'Instant financing'.$widget); // Payment option title as displayed to the customer
 
   define('MODULE_PAYMENT_PAGANTIS_TEXT_ADMIN_TITLE', 'Pagantis');
 

catalog/includes/languages/english/modules/payment/pagantis.php

Spacing +7 added lines, -7 removed lines

@@ -11,24 +11,24 @@
  */
 
   global $customer_id, $order;
-  if ( MODULE_PAYMENT_PAGANTIS_DISCOUNT == 'True' ){
+  if (MODULE_PAYMENT_PAGANTIS_DISCOUNT == 'True') {
     $discount = 1;
-  }else{
+  }else {
     $discount = 0;
   }
 
-  if ( MODULE_PAYMENT_PAGANTIS_TESTMODE == 'Test' ){
+  if (MODULE_PAYMENT_PAGANTIS_TESTMODE == 'Test') {
     $key = MODULE_PAYMENT_PAGANTIS_TK;
-  }else{
+  }else {
     $key = MODULE_PAYMENT_PAGANTIS_PK;
   }
 
   $widget = '';
-  if ( MODULE_PAYMENT_PAGANTIS_SIMULATOR == 'True' ) {
-    $widget =   '<br/>';
+  if (MODULE_PAYMENT_PAGANTIS_SIMULATOR == 'True') {
+    $widget = '<br/>';
   }
 
-  define('MODULE_PAYMENT_PAGANTIS_TEXT_CATALOG_TITLE', 'Instant financing');  // Payment option title as displayed to the customer
+  define('MODULE_PAYMENT_PAGANTIS_TEXT_CATALOG_TITLE', 'Instant financing'); // Payment option title as displayed to the customer
 
   define('MODULE_PAYMENT_PAGANTIS_TEXT_ADMIN_TITLE', 'Pagantis');
 

Braces +2 added lines, -2 removed lines

@@ -13,13 +13,13 @@
   global $customer_id, $order;
   if ( MODULE_PAYMENT_PAGANTIS_DISCOUNT == 'True' ){
     $discount = 1;
-  }else{
+  } else{
     $discount = 0;
   }
 
   if ( MODULE_PAYMENT_PAGANTIS_TESTMODE == 'Test' ){
     $key = MODULE_PAYMENT_PAGANTIS_TK;
-  }else{
+  } else{
     $key = MODULE_PAYMENT_PAGANTIS_PK;
   }
 

catalog/ext/modules/payment/pagantis/bypass.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
     $destUrl = $_POST['formUrl'];
 } elseif ($_POST['cancelUrl']) {
     $destUrl = $_POST['cancelUrl'];
-} else {
+}else {
     $destUrl = $_SERVER['HTTP_REFERER'];
 }