pagantis / oscommerce

catalog/ext/modules/payment/pagantis/notifyController.php

Spacing +25 added lines, -25 removed lines

@@ -86,22 +86,22 @@ 
             $jsonResponse->setException($exception);
             $this->insertLog($exception);
 
-            if ($this->extraConfig['PAGANTIS_URL_KO'] =! '') {
+            if ($this->extraConfig['PAGANTIS_URL_KO'] = !'') {
                 $koUrl = $this->extraConfig['PAGANTIS_URL_KO'];
-            } else {
+            }else {
                 $koUrl = trim(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', false));
             }
 
             if ($this->origin == 'notify') {
                 $jsonResponse->printResponse();
-            } else {
+            }else {
                 if ($exception->getMessage() == AlreadyProcessedException::ERROR_MESSAGE) {
-                    if ($this->extraConfig['PAGANTIS_URL_OK']!='') {
+                    if ($this->extraConfig['PAGANTIS_URL_OK'] != '') {
                         $confirmationUrl = $this->extraConfig['PAGANTIS_URL_OK'];
-                        $confirmationUrl.="?order_id=$this->merchantOrderId";
-                    } else {
+                        $confirmationUrl .= "?order_id=$this->merchantOrderId";
+                    }else {
                         $confirmationUrl = trim(tep_href_link(FILENAME_ACCOUNT_HISTORY_INFO, '', 'SSL', false));
-                        $confirmationUrl.="?order_id=$this->merchantOrderId";
+                        $confirmationUrl .= "?order_id=$this->merchantOrderId";
                     }
 
                     header("Location: $confirmationUrl");
@@ -136,7 +136,7 @@ 
 
         if ($this->origin == 'notify') {
             $jsonResponse->printResponse();
-        } else {
+        }else {
             return $jsonResponse;
         }
     }
@@ -213,12 +213,12 @@ 
         try {
             $this->checkPagantisStatus(array('AUTHORIZED'));
         } catch (\Exception $e) {
-            if ($this->findOscommerceOrderId()!='') {
+            if ($this->findOscommerceOrderId() != '') {
                 throw new AlreadyProcessedException();
-            } else {
+            }else {
                 if ($this->pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                     $status = $this->pagantisOrder->getStatus();
-                } else {
+                }else {
                     $status = '-';
                 }
                 throw new WrongStatusException($status);
@@ -233,7 +233,7 @@ 
     {
         global $order;
 
-        if ($order->info['order_status']!=='1') {
+        if ($order->info['order_status'] !== '1') {
             throw new AlreadyProcessedException();
         }
     }
@@ -264,7 +264,7 @@ 
             $this->pagantisOrder = $this->orderClient->getOrder($this->pagantisOrderId);
             if ($this->pagantisOrder->getStatus() !== Order::STATUS_CONFIRMED) {
                 throw new UnknownException($e->getMessage());
-            } else {
+            }else {
                 $logMessage = 'Concurrency issue: Order_id '.$this->pagantisOrderId.' was confirmed by other process';
                 $this->insertLog(null, $logMessage);
             }
@@ -322,7 +322,7 @@ 
                     self::CONCURRENCY_TIMEOUT
                 );
                 tep_db_query($query);
-            } elseif ($orderId!='') {
+            } elseif ($orderId != '') {
                 $query = "delete from ".TABLE_PAGANTIS_CONCURRENCY." where id='$orderId'";
                 tep_db_query($query);
             }
@@ -343,7 +343,7 @@ 
             if (isset($orderRow['timestamp'])) {
                 if ($_GET['from'] == 'notify') {
                     throw new ConcurrencyException();
-                } else {
+                }else {
                     $query = sprintf(
                         "SELECT TIMESTAMPDIFF(SECOND,NOW()-INTERVAL %s SECOND, timestamp) as rest FROM %s %s",
                         self::CONCURRENCY_TIMEOUT,
@@ -354,7 +354,7 @@ 
                     $orderRow = tep_db_fetch_array($resultsSelect);
                     $resultsSeconds = $orderRow['rest'];
                     $restSeconds = isset($resultsSeconds) ? ($resultsSeconds) : 0;
-                    $secondsToExpire=($restSeconds>self::CONCURRENCY_TIMEOUT)? self::CONCURRENCY_TIMEOUT : $restSeconds;
+                    $secondsToExpire = ($restSeconds > self::CONCURRENCY_TIMEOUT) ? self::CONCURRENCY_TIMEOUT : $restSeconds;
                     if ($secondsToExpire > 0) {
                         sleep($secondsToExpire + 1);
                     }
@@ -369,8 +369,8 @@ 
                     $os_order_id = tep_db_fetch_array($resultsSelect);
                     if (isset($os_order_id['os_order_id'])) {
                         $redirectUrl = trim(tep_href_link(FILENAME_ACCOUNT_HISTORY_INFO, '', 'SSL', false));
-                        $redirectUrl.="?order_id=$this->oscommerceOrderId";
-                    } else {
+                        $redirectUrl .= "?order_id=$this->oscommerceOrderId";
+                    }else {
                         $redirectUrl = trim(tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', false));
                     }
 
@@ -386,7 +386,7 @@ 
                     header("Location: $redirectUrl");
                     exit;
                 }
-            } else {
+            }else {
                 $query = "INSERT INTO ".TABLE_PAGANTIS_CONCURRENCY." (id) VALUES ('$this->oscommerceOrderId');";
                 tep_db_query($query);
             }
@@ -416,12 +416,12 @@ 
             if (!$payed) {
                 if ($this->pagantisOrder instanceof \Pagantis\OrdersApiClient\Model\Order) {
                     $status = $this->pagantisOrder->getStatus();
-                } else {
+                }else {
                     $status = '-';
                 }
                 throw new WrongStatusException($status);
             }
-        } else {
+        }else {
             throw new OrderNotFoundException();
         }
     }
@@ -467,12 +467,12 @@ 
         $metadataInfo = '';
         foreach ($metadataOrder as $metadataKey => $metadataValue) {
             if ($metadataKey == 'promotedProduct') {
-                $metadataInfo.= "/Producto promocionado = $metadataValue";
+                $metadataInfo .= "/Producto promocionado = $metadataValue";
             }
         }
 
         $comment = "Pagantis id=$this->pagantisOrderId/Via=".ucfirst($this->origin)."/".$metadataInfo;
-        $query = "insert into ".TABLE_ORDERS_STATUS_HISTORY ."(comments, orders_id, orders_status_id, customer_notified,
+        $query = "insert into ".TABLE_ORDERS_STATUS_HISTORY."(comments, orders_id, orders_status_id, customer_notified,
         date_added) values ('$comment', ".$insert_id.", '2', -1, now() )";
         tep_db_query($query);
 
@@ -502,10 +502,10 @@ 
      */
     private function insertLog($exception = null, $message = null)
     {
-        $logEntry= new LogEntry();
+        $logEntry = new LogEntry();
         if ($exception instanceof \Exception) {
             $logEntryJson = $logEntry->error($exception)->toJson();
-        } else {
+        }else {
             $logEntryJson = $logEntry->info($message)->toJson();
         }
             $query = "insert into ".TABLE_PAGANTIS_LOG."(log) values ('$logEntryJson')";