pagantis / oscommerce

test/basic/BasicTest.php

Spacing +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
         $this->webDriver->get(self::OSCURL);
         $condition = WebDriverExpectedCondition::titleContains(self::TITLE);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
         $this->quit();
     }
 
@@ -42,7 +42,7 @@ 
         $this->webDriver->get(self::OSCURL.self::BACKOFFICE_FOLDER);
         $condition = WebDriverExpectedCondition::titleContains(self::ADMIN_TITLE);
         $this->webDriver->wait()->until($condition);
-        $this->assertTrue((bool) $condition);
+        $this->assertTrue((bool)$condition);
         $this->quit();
     }
 }
\ No newline at end of file

config/configure_admin.php

Spacing +14 added lines, -14 removed lines

@@ -17,21 +17,21 @@
 define('DIR_WS_HTTPS_CATALOG', '/');
 define('DIR_FS_CATALOG', '/var/www/html/');
 define('DIR_WS_IMAGES', 'images/');
-define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
-define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG . 'images/');
+define('DIR_WS_ICONS', DIR_WS_IMAGES.'icons/');
+define('DIR_WS_CATALOG_IMAGES', DIR_WS_CATALOG.'images/');
 define('DIR_WS_INCLUDES', 'includes/');
-define('DIR_WS_BOXES', DIR_WS_INCLUDES . 'boxes/');
-define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
-define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
-define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
-define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
-define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG . 'includes/languages/');
-define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG . 'includes/languages/');
-define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG . 'images/');
-define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG . 'includes/modules/');
-define('DIR_FS_BACKUP', DIR_FS_ADMIN . 'backups/');
-define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG . 'download/');
-define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG . 'pub/');
+define('DIR_WS_BOXES', DIR_WS_INCLUDES.'boxes/');
+define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES.'functions/');
+define('DIR_WS_CLASSES', DIR_WS_INCLUDES.'classes/');
+define('DIR_WS_MODULES', DIR_WS_INCLUDES.'modules/');
+define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES.'languages/');
+define('DIR_WS_CATALOG_LANGUAGES', DIR_WS_CATALOG.'includes/languages/');
+define('DIR_FS_CATALOG_LANGUAGES', DIR_FS_CATALOG.'includes/languages/');
+define('DIR_FS_CATALOG_IMAGES', DIR_FS_CATALOG.'images/');
+define('DIR_FS_CATALOG_MODULES', DIR_FS_CATALOG.'includes/modules/');
+define('DIR_FS_BACKUP', DIR_FS_ADMIN.'backups/');
+define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG.'download/');
+define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG.'pub/');
 
 define('DB_SERVER', getenv('OSCOMMERCE_DB_HOST'));
 define('DB_SERVER_USERNAME', getenv('OSCOMMERCE_DB_USER'));

config/configure.php

Spacing +7 added lines, -7 removed lines

@@ -9,17 +9,17 @@
 define('DIR_WS_HTTP_CATALOG', '/');
 define('DIR_WS_HTTPS_CATALOG', '/');
 define('DIR_WS_IMAGES', 'images/');
-define('DIR_WS_ICONS', DIR_WS_IMAGES . 'icons/');
+define('DIR_WS_ICONS', DIR_WS_IMAGES.'icons/');
 define('DIR_WS_INCLUDES', 'includes/');
-define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES . 'functions/');
-define('DIR_WS_CLASSES', DIR_WS_INCLUDES . 'classes/');
-define('DIR_WS_MODULES', DIR_WS_INCLUDES . 'modules/');
-define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES . 'languages/');
+define('DIR_WS_FUNCTIONS', DIR_WS_INCLUDES.'functions/');
+define('DIR_WS_CLASSES', DIR_WS_INCLUDES.'classes/');
+define('DIR_WS_MODULES', DIR_WS_INCLUDES.'modules/');
+define('DIR_WS_LANGUAGES', DIR_WS_INCLUDES.'languages/');
 
 define('DIR_WS_DOWNLOAD_PUBLIC', 'pub/');
 define('DIR_FS_CATALOG', '/var/www/html');
-define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG . 'download/');
-define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG . 'pub/');
+define('DIR_FS_DOWNLOAD', DIR_FS_CATALOG.'download/');
+define('DIR_FS_DOWNLOAD_PUBLIC', DIR_FS_CATALOG.'pub/');
 
 define('DB_SERVER', getenv('OSCOMMERCE_DB_HOST'));
 define('DB_SERVER_USERNAME', getenv('OSCOMMERCE_DB_USER'));

catalog/ext/modules/payment/pagantis/bypass.php

Spacing +1 added lines, -1 removed lines

@@ -4,7 +4,7 @@
     $destUrl = $_POST['formUrl'];
 } elseif ($_POST['cancelUrl']) {
     $destUrl = $_POST['cancelUrl'];
-} else {
+}else {
     $destUrl = $_SERVER['HTTP_REFERER'];
 }
 

catalog/ext/modules/payment/pagantis/configController.php

Indentation +14 added lines, -14 removed lines

@@ -9,20 +9,20 @@
  * @var array $defaultConfigs
  */
 $defaultConfigs = array('PMT_TITLE'=>'Instant Financing',
-                               'PMT_SIMULATOR_DISPLAY_TYPE'=>'pmtSDK.simulator.types.SIMPLE',
-                               'PMT_SIMULATOR_DISPLAY_SKIN'=>'pmtSDK.simulator.skins.BLUE',
-                               'PMT_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
-                               'PMT_SIMULATOR_START_INSTALLMENTS'=>3,
-                               'PMT_SIMULATOR_MAX_INSTALLMENTS'=>12,
-                               'PMT_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
-                               'PMT_SIMULATOR_DISPLAY_CSS_POSITION'=>'pmtSDK.simulator.positions.INNER',
-                               'PMT_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
-                               'PMT_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
-                               'PMT_FORM_DISPLAY_TYPE'=>0,
-                               'PMT_DISPLAY_MIN_AMOUNT'=>1,
-                               'PMT_URL_OK'=>'',
-                               'PMT_URL_KO'=>'',
-                               'PMT_TITLE_EXTRA' => 'Paga hasta en 12 cómodas cuotas con Paga+Tarde. Solicitud totalmente 
+                                'PMT_SIMULATOR_DISPLAY_TYPE'=>'pmtSDK.simulator.types.SIMPLE',
+                                'PMT_SIMULATOR_DISPLAY_SKIN'=>'pmtSDK.simulator.skins.BLUE',
+                                'PMT_SIMULATOR_DISPLAY_POSITION'=>'hookDisplayProductButtons',
+                                'PMT_SIMULATOR_START_INSTALLMENTS'=>3,
+                                'PMT_SIMULATOR_MAX_INSTALLMENTS'=>12,
+                                'PMT_SIMULATOR_CSS_POSITION_SELECTOR'=>'default',
+                                'PMT_SIMULATOR_DISPLAY_CSS_POSITION'=>'pmtSDK.simulator.positions.INNER',
+                                'PMT_SIMULATOR_CSS_PRICE_SELECTOR'=>'default',
+                                'PMT_SIMULATOR_CSS_QUANTITY_SELECTOR'=>'default',
+                                'PMT_FORM_DISPLAY_TYPE'=>0,
+                                'PMT_DISPLAY_MIN_AMOUNT'=>1,
+                                'PMT_URL_OK'=>'',
+                                'PMT_URL_KO'=>'',
+                                'PMT_TITLE_EXTRA' => 'Paga hasta en 12 cómodas cuotas con Paga+Tarde. Solicitud totalmente 
                             online y sin papeleos,¡y la respuesta es inmediata!'
 );
 

Spacing +4 added lines, -4 removed lines

@@ -41,22 +41,22 @@
 } elseif ($_SERVER['REQUEST_METHOD'] == 'POST') {
     if (count($_POST)) {
         foreach ($_POST as $config => $value) {
-            if (isset($defaultConfigs[$config]) && $response['status']==null) {
+            if (isset($defaultConfigs[$config]) && $response['status'] == null) {
                 $updateQuery = "update ".TABLE_PAGANTIS_CONFIG." set value='$value' where config='$config'";
                 $resultsSelect = tep_db_query($updateQuery);
-            } else {
+            }else {
                 $response['status'] = 400;
                 $response['result'] = 'Bad request';
             }
         }
-    } else {
+    }else {
         $response['status'] = 422;
         $response['result'] = 'Empty data';
     }
 }
 
 $formattedResult = array();
-if ($response['status']==null) {
+if ($response['status'] == null) {
     $query = "select * from ".TABLE_PAGANTIS_CONFIG;
     $resultsSelect = tep_db_query($query);
     while ($orderRow = tep_db_fetch_array($resultsSelect)) {

catalog/ext/modules/payment/pagantis/logController.php

Spacing +7 added lines, -7 removed lines

@@ -11,8 +11,8 @@ 
 $orderRow = tep_db_fetch_array($resultsSelect);
 $privateKey = $orderRow['configuration_value'];
 
-if ($secretKey!='' && $privateKey!='') {
-    $query ="select log, createdAt from ".TABLE_PAGANTIS_LOG;
+if ($secretKey != '' && $privateKey != '') {
+    $query = "select log, createdAt from ".TABLE_PAGANTIS_LOG;
 
     $where = array();
     if (isset($_GET['from'])) {
@@ -24,16 +24,16 @@ 
     }
 
 
-    if (count($where)>0) {
-        $query.=" where ";
+    if (count($where) > 0) {
+        $query .= " where ";
         foreach ((array)$where as $clause) {
-            $query.=" $clause AND";
+            $query .= " $clause AND";
         }
         $query = substr($query, 0, -3);
     }
 
     $limit = ($_GET['limit']) ? $_GET['limit'] : 50;
-    $query.=" order by createdAt desc limit $limit";
+    $query .= " order by createdAt desc limit $limit";
 
     $response = array();
     $resultsSelect = tep_db_query($query);
@@ -44,7 +44,7 @@ 
             $response[$i]['log']       = $orderRow['log'];
             $i++;
         }
-    } else {
+    }else {
         $response['result'] = 'Error';
     }
 

catalog/ext/modules/payment/pagantis/callback.php

Spacing +2 added lines, -2 removed lines

@@ -16,8 +16,8 @@
         tep_session_register($var);
     }
     $destUrl = tep_href_link(FILENAME_CHECKOUT_PROCESS, '', 'SSL', true, false);
-    $destUrl.="?order_id=$_GET[order_id]&from=notify";
-} else {
+    $destUrl .= "?order_id=$_GET[order_id]&from=notify";
+}else {
     $destUrl = tep_href_link(FILENAME_CHECKOUT_SHIPPING, '', 'SSL', true, false);
 }
 

test/PagantisOscommerceTest.php

Spacing +8 added lines, -8 removed lines

@@ -64,12 +64,12 @@ 
         $faker = Factory::create();
         $this->configuration['dni'] = $this->getDNI();
         $this->configuration['firstname'] = $faker->firstName;
-        $this->configuration['lastname'] = $faker->lastName . ' ' . $faker->lastName;
+        $this->configuration['lastname'] = $faker->lastName.' '.$faker->lastName;
         $this->configuration['company'] = $faker->company;
         $this->configuration['zip'] = '28'.$faker->randomNumber(3, true);
         $this->configuration['address'] = $faker->streetAddress;
-        $this->configuration['phone'] = '6' . $faker->randomNumber(8);
-        $this->configuration['email'] = date('ymd') . '@pagantis.com';
+        $this->configuration['phone'] = '6'.$faker->randomNumber(8);
+        $this->configuration['email'] = date('ymd').'@pagantis.com';
         parent::__construct($name, $data, $dataName);
     }
     /**
@@ -77,12 +77,12 @@ 
      */
     protected function getDNI()
     {
-        $dni = '0000' . rand(pow(10, 4-1), pow(10, 4)-1);
-        $value = (int) ($dni / 23);
+        $dni = '0000'.rand(pow(10, 4 - 1), pow(10, 4) - 1);
+        $value = (int)($dni / 23);
         $value *= 23;
-        $value= $dni - $value;
-        $letter= "TRWAGMYFPDXBNJZSQVHLCKEO";
-        $dniLetter= substr($letter, $value, 1);
+        $value = $dni - $value;
+        $letter = "TRWAGMYFPDXBNJZSQVHLCKEO";
+        $dniLetter = substr($letter, $value, 1);
         return $dni.$dniLetter;
     }
 

test/Buy/BuyRegisteredTest.php

Spacing +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
      */
     protected function checkPagantisOrderId()
     {
-        $orderId=0;
+        $orderId = 0;
         $notifyUrl = self::OSCURL.self::NOTIFICATION_FOLDER.'?order='.$orderId;
         $this->assertNotEmpty($notifyUrl, $notifyUrl);
         $response = Request::post($notifyUrl)->expects('json')->send();
@@ -149,7 +149,7 @@ 
         $this->assertEquals(
             $response->body->merchant_order_id,
             $orderId,
-            $response->body->merchant_order_id.'!='. $orderId
+            $response->body->merchant_order_id.'!='.$orderId
         );
         $this->assertContains(
             NoIdentificationException::ERROR_MESSAGE,