Inspection of "Update package padosoft/php-oara v. 2.5.39" - padosoft/laravel-affiliate-network - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00e92d...4fc683 )

unknown

created 2019-06-19 10:29 UTC

Status

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -19,7 +19,7 @@
 block discarded – undo
     /**
      * @param \DateTime $dateFrom
      * @param \DateTime $dateTo
-     * @param int $merchantID
+     * @param int $arrMerchantID
      * @return array of Transaction
      */
     public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array;

Please login to merge, or discard this patch.

src/Networks/TradeDoubler.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -71,7 +71,7 @@
 block discarded – undo
     /**
      * @param \DateTime $dateFrom
      * @param \DateTime $dateTo
-     * @param int $merchantID
+     * @param int $arrMerchantID
      * @return array of Transaction
      */
     public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

Please login to merge, or discard this patch.

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -2,15 +2,15 @@
 block discarded – undo
 
 namespace Padosoft\AffiliateNetwork\Networks;
 
-use Padosoft\AffiliateNetwork\Transaction;
+use Padosoft\AffiliateNetwork\AbstractNetwork;
+use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\DealsResultset;
 use Padosoft\AffiliateNetwork\Merchant;
-use Padosoft\AffiliateNetwork\Stat;
-use Padosoft\AffiliateNetwork\Deal;
-use Padosoft\AffiliateNetwork\AbstractNetwork;
 use Padosoft\AffiliateNetwork\NetworkInterface;
-use Padosoft\AffiliateNetwork\TradeDoublerEx;
 use Padosoft\AffiliateNetwork\ProductsResultset;
+use Padosoft\AffiliateNetwork\Stat;
+use Padosoft\AffiliateNetwork\TradeDoublerEx;
+use Padosoft\AffiliateNetwork\Transaction;
 
 if (!defined('COOKIES_BASE_DIR')){
     define('COOKIES_BASE_DIR',public_path('upload/report'));

Please login to merge, or discard this patch.

src/AffiliateNetworkServiceProvider.php 1 patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

@@ -3,8 +3,6 @@
 block discarded – undo
 namespace Padosoft\AffiliateNetwork;
 
 use Illuminate\Support\ServiceProvider;
-use Padosoft\AffiliateNetwork\Networks\Zanox;
-use Padosoft\AffiliateNetwork\Networks\ZanoxEx;
 
 class AffiliateNetworkServiceProvider extends ServiceProvider
 {

Please login to merge, or discard this patch.

src/Networks/Effiliation.php 2 patches

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -71,7 +71,7 @@  discard block
 block discarded – undo
 
     /**
      * @param int $merchantID
-     * @return array of Deal
+     * @return DealsResultset of Deal
      */
     public function getDeals($merchantID=NULL,int $page=0,int $items_per_page=10 ): DealsResultset
     {
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
     /**
      * @param \DateTime $dateFrom
      * @param \DateTime $dateTo
-     * @param int $merchantID
+     * @param int $arrMerchantID
      * @return array of Transaction
      */
     public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

Please login to merge, or discard this patch.

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -2,14 +2,14 @@
 block discarded – undo
 
 namespace Padosoft\AffiliateNetwork\Networks;
 
-use Padosoft\AffiliateNetwork\Transaction;
-use Padosoft\AffiliateNetwork\Merchant;
-use Padosoft\AffiliateNetwork\Stat;
-use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\AbstractNetwork;
-use Padosoft\AffiliateNetwork\NetworkInterface;
+use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\DealsResultset;
+use Padosoft\AffiliateNetwork\Merchant;
+use Padosoft\AffiliateNetwork\NetworkInterface;
 use Padosoft\AffiliateNetwork\ProductsResultset;
+use Padosoft\AffiliateNetwork\Stat;
+use Padosoft\AffiliateNetwork\Transaction;
 
 // require "../vendor/fubralimited/php-oara/Oara/Network/Publisher/Effiliation/Zapi/ApiClient.php";
 

Please login to merge, or discard this patch.

src/Networks/Publicideas.php 2 patches

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -71,7 +71,7 @@  discard block
 block discarded – undo
 
     /**
      * @param int $merchantID
-     * @return array of Deal
+     * @return DealsResultset of Deal
      */
     public function getDeals($merchantID=NULL,int $page=0,int $items_per_page=10 ): DealsResultset
     {
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
     /**
      * @param \DateTime $dateFrom
      * @param \DateTime $dateTo
-     * @param int $merchantID
+     * @param int $arrMerchantID
      * @return array of Transaction
      */
     public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

Please login to merge, or discard this patch.

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -2,14 +2,14 @@
 block discarded – undo
 
 namespace Padosoft\AffiliateNetwork\Networks;
 
-use Padosoft\AffiliateNetwork\Transaction;
-use Padosoft\AffiliateNetwork\Merchant;
-use Padosoft\AffiliateNetwork\Stat;
-use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\AbstractNetwork;
-use Padosoft\AffiliateNetwork\NetworkInterface;
+use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\DealsResultset;
+use Padosoft\AffiliateNetwork\Merchant;
+use Padosoft\AffiliateNetwork\NetworkInterface;
 use Padosoft\AffiliateNetwork\ProductsResultset;
+use Padosoft\AffiliateNetwork\Stat;
+use Padosoft\AffiliateNetwork\Transaction;
 
 // require "../vendor/fubralimited/php-oara/Oara/Network/Publisher/Publicideas/Zapi/ApiClient.php";
 

Please login to merge, or discard this patch.

src/Networks/Zanox.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -105,7 +105,7 @@
 block discarded – undo
     /**
      * @param \DateTime $dateFrom
      * @param \DateTime $dateTo
-     * @param int $merchantID
+     * @param int $arrMerchantID
      *
      * @return array of Transaction
      */

Please login to merge, or discard this patch.

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -2,15 +2,15 @@
 block discarded – undo
 
 namespace Padosoft\AffiliateNetwork\Networks;
 
+use Padosoft\AffiliateNetwork\AbstractNetwork;
+use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\DealsResultset;
+use Padosoft\AffiliateNetwork\Merchant;
+use Padosoft\AffiliateNetwork\NetworkInterface;
 use Padosoft\AffiliateNetwork\Product;
 use Padosoft\AffiliateNetwork\ProductsResultset;
-use Padosoft\AffiliateNetwork\Transaction;
-use Padosoft\AffiliateNetwork\Merchant;
 use Padosoft\AffiliateNetwork\Stat;
-use Padosoft\AffiliateNetwork\Deal;
-use Padosoft\AffiliateNetwork\AbstractNetwork;
-use Padosoft\AffiliateNetwork\NetworkInterface;
+use Padosoft\AffiliateNetwork\Transaction;
 use Padosoft\AffiliateNetwork\ZanoxEx;
 
 // require "../vendor/fubralimited/php-oara/Oara/Network/Publisher/Zanox/Zapi/ApiClient.php";

Please login to merge, or discard this patch.

src/Networks/NetAffiliation.php 2 patches

Doc Comments +4 added lines, -1 removed lines patch added patch discarded remove patch

@@ -43,6 +43,9 @@  discard block
 block discarded – undo
         $this->login( $this->_username, $this->_password );
     }
 
+    /**
+     * @param string $idSite
+     */
     public function addAllowedSite($idSite){
         if (trim($idSite)!=''){
             $this->_network->addAllowedSite($idSite);
@@ -147,7 +150,7 @@  discard block
 block discarded – undo
     /**
      * @param \DateTime $dateFrom
      * @param \DateTime $dateTo
-     * @param int $merchantID
+     * @param int $arrMerchantID
      * @return array of Transaction
      */
     public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

Please login to merge, or discard this patch.

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -2,15 +2,15 @@
 block discarded – undo
 
 namespace Padosoft\AffiliateNetwork\Networks;
 
+use Padosoft\AffiliateNetwork\AbstractNetwork;
+use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\DealsResultset;
-use Padosoft\AffiliateNetwork\Transaction;
 use Padosoft\AffiliateNetwork\Merchant;
-use Padosoft\AffiliateNetwork\Stat;
-use Padosoft\AffiliateNetwork\Deal;
-use Padosoft\AffiliateNetwork\AbstractNetwork;
-use Padosoft\AffiliateNetwork\NetworkInterface;
 use Padosoft\AffiliateNetwork\NetAffiliationEx;
+use Padosoft\AffiliateNetwork\NetworkInterface;
 use Padosoft\AffiliateNetwork\ProductsResultset;
+use Padosoft\AffiliateNetwork\Stat;
+use Padosoft\AffiliateNetwork\Transaction;
 
 if (!defined('COOKIES_BASE_DIR')){
     define('COOKIES_BASE_DIR',public_path('upload/report'));

Please login to merge, or discard this patch.

src/Networks/CommissionJunction.php 2 patches

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -2,14 +2,14 @@
 block discarded – undo
 
 namespace Padosoft\AffiliateNetwork\Networks;
 
-use Padosoft\AffiliateNetwork\Transaction;
-use Padosoft\AffiliateNetwork\Merchant;
-use Padosoft\AffiliateNetwork\Stat;
-use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\AbstractNetwork;
-use Padosoft\AffiliateNetwork\NetworkInterface;
+use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\DealsResultset;
+use Padosoft\AffiliateNetwork\Merchant;
+use Padosoft\AffiliateNetwork\NetworkInterface;
 use Padosoft\AffiliateNetwork\ProductsResultset;
+use Padosoft\AffiliateNetwork\Stat;
+use Padosoft\AffiliateNetwork\Transaction;
 
 // require "../vendor/fubralimited/php-oara/Oara/Network/Publisher/CommissionJunction/Zapi/ApiClient.php";
 

Please login to merge, or discard this patch.

Doc Comments +2 added lines, -1 removed lines patch added patch discarded remove patch

@@ -203,7 +203,7 @@  discard block
 block discarded – undo
     /**
      * @param \DateTime $dateFrom
      * @param \DateTime $dateTo
-     * @param int $merchantID
+     * @param int $arrMerchantID
      * @return array of Transaction
      */
     public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()): array
@@ -290,6 +290,7 @@  discard block
 block discarded – undo
 
     /**
      * Api call CommissionJunction
+     * @param string $url
      */
     private function _apiCall($url)
     {

Please login to merge, or discard this patch.

src/Networks/WebGains.php 2 patches

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -2,14 +2,14 @@
 block discarded – undo
 
 namespace Padosoft\AffiliateNetwork\Networks;
 
-use Padosoft\AffiliateNetwork\Transaction;
+use Padosoft\AffiliateNetwork\AbstractNetwork;
+use Padosoft\AffiliateNetwork\Deal;
 use Padosoft\AffiliateNetwork\DealsResultset;
 use Padosoft\AffiliateNetwork\Merchant;
-use Padosoft\AffiliateNetwork\Stat;
-use Padosoft\AffiliateNetwork\Deal;
-use Padosoft\AffiliateNetwork\AbstractNetwork;
 use Padosoft\AffiliateNetwork\NetworkInterface;
 use Padosoft\AffiliateNetwork\ProductsResultset;
+use Padosoft\AffiliateNetwork\Stat;
+use Padosoft\AffiliateNetwork\Transaction;
 
 /**
  * Class WebGains

Please login to merge, or discard this patch.

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -97,7 +97,7 @@
 block discarded – undo
 
     /**
      * @param int $merchantID to filter only one merchant
-     * @return array of Deal
+     * @return DealsResultset of Deal
      */
     public function getDeals($merchantID = null, int $page = 0, int $items_per_page = 10): DealsResultset
     {

Please login to merge, or discard this patch.

		@@ -71,7 +71,7 @@ discard block
		block discarded – undo
71	71
72	72	/**
73	73	* @param int $merchantID
74		- * @return array of Deal
	74	+ * @return DealsResultset of Deal
75	75	*/
76	76	public function getDeals($merchantID=NULL,int $page=0,int $items_per_page=10 ): DealsResultset
77	77	{
		@@ -107,7 +107,7 @@ discard block
		block discarded – undo
107	107	/**
108	108	* @param \DateTime $dateFrom
109	109	* @param \DateTime $dateTo
110		- * @param int $merchantID
	110	+ * @param int $arrMerchantID
111	111	* @return array of Transaction
112	112	*/
113	113	public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

		@@ -71,7 +71,7 @@ discard block
		block discarded – undo
71	71
72	72	/**
73	73	* @param int $merchantID
74		- * @return array of Deal
	74	+ * @return DealsResultset of Deal
75	75	*/
76	76	public function getDeals($merchantID=NULL,int $page=0,int $items_per_page=10 ): DealsResultset
77	77	{
		@@ -107,7 +107,7 @@ discard block
		block discarded – undo
107	107	/**
108	108	* @param \DateTime $dateFrom
109	109	* @param \DateTime $dateTo
110		- * @param int $merchantID
	110	+ * @param int $arrMerchantID
111	111	* @return array of Transaction
112	112	*/
113	113	public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

		@@ -203,7 +203,7 @@ discard block
		block discarded – undo
203	203	/**
204	204	* @param \DateTime $dateFrom
205	205	* @param \DateTime $dateTo
206		- * @param int $merchantID
	206	+ * @param int $arrMerchantID
207	207	* @return array of Transaction
208	208	*/
209	209	public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()): array
		@@ -290,6 +290,7 @@ discard block
		block discarded – undo
290	290
291	291	/**
292	292	* Api call CommissionJunction
	293	+ * @param string $url
293	294	*/
294	295	private function _apiCall($url)
295	296	{

		@@ -97,7 +97,7 @@
		block discarded – undo
97	97
98	98	/**
99	99	* @param int $merchantID to filter only one merchant
100		- * @return array of Deal
	100	+ * @return DealsResultset of Deal
101	101	*/
102	102	public function getDeals($merchantID = null, int $page = 0, int $items_per_page = 10): DealsResultset
103	103	{

		@@ -19,7 +19,7 @@
		block discarded – undo
19	19	/**
20	20	* @param \DateTime $dateFrom
21	21	* @param \DateTime $dateTo
22		- * @param int $merchantID
	22	+ * @param int $arrMerchantID
23	23	* @return array of Transaction
24	24	*/
25	25	public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array;

		@@ -71,7 +71,7 @@
		block discarded – undo
71	71	/**
72	72	* @param \DateTime $dateFrom
73	73	* @param \DateTime $dateTo
74		- * @param int $merchantID
	74	+ * @param int $arrMerchantID
75	75	* @return array of Transaction
76	76	*/
77	77	public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

		@@ -2,15 +2,15 @@
		block discarded – undo
2	2
3	3	namespace Padosoft\AffiliateNetwork\Networks;
4	4
5		-use Padosoft\AffiliateNetwork\Transaction;
	5	+use Padosoft\AffiliateNetwork\AbstractNetwork;
	6	+use Padosoft\AffiliateNetwork\Deal;
6	7	use Padosoft\AffiliateNetwork\DealsResultset;
7	8	use Padosoft\AffiliateNetwork\Merchant;
8		-use Padosoft\AffiliateNetwork\Stat;
9		-use Padosoft\AffiliateNetwork\Deal;
10		-use Padosoft\AffiliateNetwork\AbstractNetwork;
11	9	use Padosoft\AffiliateNetwork\NetworkInterface;
12		-use Padosoft\AffiliateNetwork\TradeDoublerEx;
13	10	use Padosoft\AffiliateNetwork\ProductsResultset;
	11	+use Padosoft\AffiliateNetwork\Stat;
	12	+use Padosoft\AffiliateNetwork\TradeDoublerEx;
	13	+use Padosoft\AffiliateNetwork\Transaction;
14	14
15	15	if (!defined('COOKIES_BASE_DIR')){
16	16	define('COOKIES_BASE_DIR',public_path('upload/report'));

		@@ -3,8 +3,6 @@
		block discarded – undo
3	3	namespace Padosoft\AffiliateNetwork;
4	4
5	5	use Illuminate\Support\ServiceProvider;
6		-use Padosoft\AffiliateNetwork\Networks\Zanox;
7		-use Padosoft\AffiliateNetwork\Networks\ZanoxEx;
8	6
9	7	class AffiliateNetworkServiceProvider extends ServiceProvider
10	8	{

		@@ -2,14 +2,14 @@
		block discarded – undo
2	2
3	3	namespace Padosoft\AffiliateNetwork\Networks;
4	4
5		-use Padosoft\AffiliateNetwork\Transaction;
6		-use Padosoft\AffiliateNetwork\Merchant;
7		-use Padosoft\AffiliateNetwork\Stat;
8		-use Padosoft\AffiliateNetwork\Deal;
9	5	use Padosoft\AffiliateNetwork\AbstractNetwork;
10		-use Padosoft\AffiliateNetwork\NetworkInterface;
	6	+use Padosoft\AffiliateNetwork\Deal;
11	7	use Padosoft\AffiliateNetwork\DealsResultset;
	8	+use Padosoft\AffiliateNetwork\Merchant;
	9	+use Padosoft\AffiliateNetwork\NetworkInterface;
12	10	use Padosoft\AffiliateNetwork\ProductsResultset;
	11	+use Padosoft\AffiliateNetwork\Stat;
	12	+use Padosoft\AffiliateNetwork\Transaction;
13	13
14	14	// require "../vendor/fubralimited/php-oara/Oara/Network/Publisher/Effiliation/Zapi/ApiClient.php";
15	15

		@@ -105,7 +105,7 @@
		block discarded – undo
105	105	/**
106	106	* @param \DateTime $dateFrom
107	107	* @param \DateTime $dateTo
108		- * @param int $merchantID
	108	+ * @param int $arrMerchantID
109	109	*
110	110	* @return array of Transaction
111	111	*/

		@@ -43,6 +43,9 @@ discard block
		block discarded – undo
43	43	$this->login( $this->_username, $this->_password );
44	44	}
45	45
	46	+ /**
	47	+ * @param string $idSite
	48	+ */
46	49	public function addAllowedSite($idSite){
47	50	if (trim($idSite)!=''){
48	51	$this->_network->addAllowedSite($idSite);
		@@ -147,7 +150,7 @@ discard block
		block discarded – undo
147	150	/**
148	151	* @param \DateTime $dateFrom
149	152	* @param \DateTime $dateTo
150		- * @param int $merchantID
	153	+ * @param int $arrMerchantID
151	154	* @return array of Transaction
152	155	*/
153	156	public function getSales(\DateTime $dateFrom, \DateTime $dateTo, array $arrMerchantID = array()) : array

padosoft / laravel-affiliate-network

Push — master ( 00e92d...4fc683 )

Status

Category

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Unused Use Statements -2 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +4 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Unused Use Statements +5 added lines, -5 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -1 removed lines patch added patch discarded remove patch

Unused Use Statements +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch