Completed
Pull Request — master (#1634)
by Christoph
05:50
created
lib/controller/messagescontroller.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -408,6 +408,10 @@
 block discarded – undo
408 408
 		return \OC::$server->getURLGenerator()->getAbsoluteURL($htmlBodyUrl);
409 409
 	}
410 410
 
411
+	/**
412
+	 * @param integer $accountId
413
+	 * @param string $folderId
414
+	 */
411 415
 	private function loadMultiple($accountId, $folderId, $ids) {
412 416
 		$messages = array_map(function($id) use ($accountId, $folderId){
413 417
 			try {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 
29 29
 namespace OCA\Mail\Controller;
30 30
 
31
-use OC;
32 31
 use OCA\Mail\Http\AttachmentDownloadResponse;
33 32
 use OCA\Mail\Http\HtmlResponse;
34 33
 use OCA\Mail\Service\AccountService;
Please login to merge, or discard this patch.
lib/controller/folderscontroller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	 * @param string $appName
44 44
 	 * @param IRequest $request
45 45
 	 * @param AccountService $accountService
46
-	 * @param $UserId
46
+	 * @param string $UserId
47 47
 	 */
48 48
 	public function __construct($appName, IRequest $request, AccountService $accountService, $UserId) {
49 49
 		parent::__construct($appName, $request);
Please login to merge, or discard this patch.
lib/controller/accountscontroller.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 	 * @param string $appName
44 44
 	 * @param IRequest $request
45 45
 	 * @param AccountService $accountService
46
-	 * @param $UserId
46
+	 * @param string $UserId
47 47
 	 */
48 48
 	public function __construct($appName, IRequest $request, AccountService $accountService, $UserId) {
49 49
 		parent::__construct($appName, $request);
Please login to merge, or discard this patch.
lib/service/autocompletion/addresscollector.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,6 @@
 block discarded – undo
65 65
 	 * Find and return all known and matching email addresses
66 66
 	 *
67 67
 	 * @param Horde_Mail_Rfc822_Address[] $term
68
-	 * @param string $UserId
69 68
 	 */
70 69
 	public function searchAddress($term) {
71 70
 		$this->logger->debug("searching for collected address <$term>");
Please login to merge, or discard this patch.
lib/controller/autocompletecontroller.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -65,7 +65,6 @@
 block discarded – undo
65 65
 	 * Find and return all known and matching email addresses
66 66
 	 *
67 67
 	 * @param Horde_Mail_Rfc822_Address[] $term
68
-	 * @param string $UserId
69 68
 	 */
70 69
 	public function searchAddress($term) {
71 70
 		$this->logger->debug("searching for collected address <$term>");
Please login to merge, or discard this patch.
lib/account.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,6 @@
 block discarded – undo
48 48
 use OCA\Mail\Model\IMessage;
49 49
 use OCA\Mail\Model\Message;
50 50
 use OCA\Mail\Model\ReplyMessage;
51
-use OCA\Mail\Service\AutoCompletion\AddressCollector;
52 51
 use OCA\Mail\Service\IAccount;
53 52
 use OCA\Mail\Service\IMailBox;
54 53
 use OCP\IConfig;
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -428,7 +428,7 @@
 block discarded – undo
428 428
 	}
429 429
 
430 430
 	/**
431
-	 * @return IMailBox
431
+	 * @return Mailbox|null
432 432
 	 */
433 433
 	public function getInbox() {
434 434
 		$folders = $this->getSpecialFolder('inbox', false);
Please login to merge, or discard this patch.
lib/service/autoconfig/autoconfig.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -175,9 +175,9 @@
 block discarded – undo
175 175
 	}
176 176
 
177 177
 	/**
178
-	 * @param $email
179
-	 * @param $password
180
-	 * @param $name
178
+	 * @param string $email
179
+	 * @param string $password
180
+	 * @param string $name
181 181
 	 * @return null|MailAccount
182 182
 	 */
183 183
 	private function detectImapAndSmtp($email, $password, $name) {
Please login to merge, or discard this patch.
lib/service/autoconfig/ispdb.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,12 +40,14 @@
 block discarded – undo
40 40
 
41 41
 	/**
42 42
 	 * @param Logger $logger
43
-	 * @param string[] $ispUrls
44 43
 	 */
45 44
 	public function __construct(Logger $logger) {
46 45
 		$this->logger = $logger;
47 46
 	}
48 47
 
48
+	/**
49
+	 * @param string $url
50
+	 */
49 51
 	private function queryUrl($url) {
50 52
 		try {
51 53
 			$xml = @simplexml_load_file($url);
Please login to merge, or discard this patch.
lib/mailbox.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -90,6 +90,11 @@  discard block
 block discarded – undo
90 90
 		$this->makeDisplayName();
91 91
 	}
92 92
 
93
+	/**
94
+	 * @param integer $from
95
+	 * @param integer $count
96
+	 * @param string $filter
97
+	 */
93 98
 	private function getSearchIds($from, $count, $filter) {
94 99
 		if ($filter instanceof Horde_Imap_Client_Search_Query) {
95 100
 			$query = $filter;
@@ -110,6 +115,10 @@  discard block
 block discarded – undo
110 115
 		return new \Horde_Imap_Client_Ids($ids, false);
111 116
 	}
112 117
 
118
+	/**
119
+	 * @param integer $from
120
+	 * @param integer $count
121
+	 */
113 122
 	private function getFetchIds($from, $count) {
114 123
 		$q = new Horde_Imap_Client_Fetch_Query();
115 124
 		$q->uid();
Please login to merge, or discard this patch.