Daemon::__construct() - Code Metrics - Inspection of "Do not subclass socket from daemon directly, it me..." - owncloud/files_antivirus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — closes-181 ( 42194d...7c5f0f )

by Victor

created 2017-11-20 14:29 UTC

Daemon::__construct() B

↳ Parent: Daemon

Complexity

Conditions	4
Paths	6

Size

Total Lines	25
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	13
cts	13
cp	1
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	6
nop	2
crap	4

<?php
/**
 * Copyright (c) 2017 Viktar Dubiniuk <[email protected]>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;
use OCP\ILogger;

class Daemon extends External {

	/** @var string  */
	private $avHost;

	/** @var int  */
	private $avPort;

	/**
	 * Daemon constructor.
	 *
	 * @param AppConfig $config
	 * @param ILogger $logger
	 * @throws InitException
	 */
	public function __construct(AppConfig $config, ILogger $logger) {
		parent::__construct($config, $logger);

		$this->avHost = $this->appConfig->getAvHost();
		$this->avPort = $this->appConfig->getAvPort();
		$checks = [
			'hostname' => $this->avHost,
			'port' => $this->avPort
		];
		$errors = [];
		foreach ($checks as $key => $check) {
			if ($check === '') {
				$errors[] = sprintf(
					'Daemon mode requires a %s but it is empty.',
					$key
				);
			}
		}

		if (count($errors) > 0) {
			throw new InitException(
				'The app is not configured properly. ' . implode(' ', $errors)
			);
		}
	}

	/**
	 * @throws InitException
	 */
	public function initScanner(){
		parent::initScanner();
		$this->writeHandle = @fsockopen($this->avHost, $this->avPort);
		if (!$this->getWriteHandle()) {
			throw new InitException(
				sprintf(
					'Could not connect to host "%s" on port %d', $this->avHost, $this->avPort
				)
			);
		}
		// request scan from the daemon
		@fwrite($this->getWriteHandle(), "nINSTREAM\n");
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
	}
}


1		<?php
2		/**
3		* Copyright (c) 2017 Viktar Dubiniuk <[email protected]>
4		* This file is licensed under the Affero General Public License version 3 or
5		* later.
6		* See the COPYING-README file.
7		*/
8
9
10		namespace OCA\Files_Antivirus\Scanner;
11
12		use OCA\Files_Antivirus\AppConfig;
13		use OCP\ILogger;
14
15		class Daemon extends External {
16
17	6	/** @var string */
18	6	private $avHost;
19
20	6	/** @var int */
21	6	private $avPort;
22
23	6	/**
24	6	* Daemon constructor.
25		*
26	6	* @param AppConfig $config
27	6	* @param ILogger $logger
28	6	* @throws InitException
29	2	*/
30	2	public function __construct(AppConfig $config, ILogger $logger) {
31	6	parent::__construct($config, $logger);
32
33		$this->avHost = $this->appConfig->getAvHost();
34		$this->avPort = $this->appConfig->getAvPort();
35		$checks = [
36	6	'hostname' => $this->avHost,
37	2	'port' => $this->avPort
38	2	];
39		$errors = [];
40		foreach ($checks as $key => $check) {
41		if ($check === '') {
42	4	$errors[] = sprintf(
43	4	'Daemon mode requires a %s but it is empty.',
44	2	$key
45	2	);
46	2	}
47		}
48
49		if (count($errors) > 0) {
50	2	throw new InitException(
51		'The app is not configured properly. ' . implode(' ', $errors)
52	2	);
53	2	}
54		}
55
56	2	/**
57	2	* @throws InitException
58		*/
59		public function initScanner(){
60		parent::initScanner();
61		$this->writeHandle = @fsockopen($this->avHost, $this->avPort);
62		if (!$this->getWriteHandle()) {
63		throw new InitException(
64		sprintf(
65		'Could not connect to host "%s" on port %d', $this->avHost, $this->avPort
66		)
67		);
68		}
69		// request scan from the daemon
70		@fwrite($this->getWriteHandle(), "nINSTREAM\n");
		0 ignored issues – show Security Best Practice introduced 2017-10-23 22:03 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
71		}
72		}
73

owncloud / files_antivirus

Push — closes-181 ( 42194d...7c5f0f )

Daemon::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like