OCA\Files_Antivirus\Scanner\Daemon

Complexity

Total Complexity

6

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

69.44%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	25	4
A	initScanner()	0	13	2

<?php
/**
 * Copyright (c) 2017 Viktar Dubiniuk <dubiniuk@owncloud.com>
 * This file is licensed under the Affero General Public License version 3 or
 * later.
 * See the COPYING-README file.
 */


namespace OCA\Files_Antivirus\Scanner;

use OCA\Files_Antivirus\AppConfig;
use OCP\ILogger;

class Daemon extends External {

	/** @var string  */
	private $avHost;

	/** @var int  */
	private $avPort;

	/**
	 * Daemon constructor.
	 *
	 * @param AppConfig $config
	 * @param ILogger $logger
	 * @throws InitException
	 */
	public function __construct(AppConfig $config, ILogger $logger) {
		parent::__construct($config, $logger);

		$this->avHost = $this->appConfig->getAvHost();
		$this->avPort = $this->appConfig->getAvPort();
		$checks = [
			'hostname' => $this->avHost,
			'port' => $this->avPort
		];
		$errors = [];
		foreach ($checks as $key => $check) {
			if ($check === '') {
				$errors[] = sprintf(
					'Daemon mode requires a %s but it is empty.',
					$key
				);
			}
		}

		if (count($errors) > 0) {
			throw new InitException(
				'The app is not configured properly. ' . implode(' ', $errors)
			);
		}
	}

	/**
	 * @throws InitException
	 */
	public function initScanner(){
		parent::initScanner();
		$this->writeHandle = @fsockopen($this->avHost, $this->avPort);
		if (!$this->getWriteHandle()) {
			throw new InitException(
				sprintf(
					'Could not connect to host "%s" on port %d', $this->avHost, $this->avPort
				)
			);
		}
		// request scan from the daemon
		@fwrite($this->getWriteHandle(), "nINSTREAM\n");

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

	}
}