owncloud / core

lib/private/Files/Storage/Wrapper/Encoding.php

Doc Comments +1 added lines, -1 removed lines

@@ -154,7 +154,7 @@
 	 * see http://php.net/manual/en/function.filetype.php
 	 *
 	 * @param string $path
-	 * @return bool
+	 * @return string|false
 	 */
 	public function filetype($path) {
 		return $this->storage->filetype($this->findPathToUse($path));

lib/private/Files/Storage/Wrapper/Jail.php

Doc Comments +4 added lines, -1 removed lines

@@ -51,6 +51,9 @@ 
 		$this->rootPath = $arguments['root'];
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public function getSourcePath($path) {
 		if ($this->rootPath === null) {
 			throw new \InvalidArgumentException('Jail rootPath is null');
@@ -131,7 +134,7 @@ 
 	 * see http://php.net/manual/en/function.filetype.php
 	 *
 	 * @param string $path
-	 * @return bool
+	 * @return string|false
 	 */
 	public function filetype($path) {
 		return $this->getWrapperStorage()->filetype($this->getSourcePath($path));

lib/private/Files/Storage/Wrapper/Wrapper.php

Doc Comments +2 added lines, -2 removed lines

@@ -132,7 +132,7 @@ 
 	 * see http://php.net/manual/en/function.filetype.php
 	 *
 	 * @param string $path
-	 * @return bool
+	 * @return string|false
 	 */
 	public function filetype($path) {
 		return $this->getWrapperStorage()->filetype($path);
@@ -461,7 +461,7 @@ 
 	/**
 	 * Returns true
 	 *
-	 * @return true
+	 * @return boolean
 	 */
 	public function test() {
 		return $this->getWrapperStorage()->test();

lib/private/Files/Meta/MetaFileVersionNode.php

Doc Comments +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
 	 * @param MetaVersionCollection $parent
 	 * @param IRootFolder $root
 	 * @param array $version
-	 * @param Storage $storage
+	 * @param Storage\IStorage $storage
 	 * @param string $internalPath
 	 */
 	public function __construct(MetaVersionCollection $parent,

lib/private/Files/Storage/StorageFactory.php

Doc Comments +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
 	 * @param \OCP\Files\Mount\IMountPoint $mountPoint
 	 * @param string $class
 	 * @param array $arguments
-	 * @return \OCP\Files\Storage
+	 * @return IStorage
 	 */
 	public function getInstance(IMountPoint $mountPoint, $class, $arguments) {
 		return $this->wrap($mountPoint, new $class($arguments));
@@ -86,7 +86,7 @@ 
 	/**
 	 * @param \OCP\Files\Mount\IMountPoint $mountPoint
 	 * @param \OCP\Files\Storage\IStorage $storage
-	 * @return \OCP\Files\Storage
+	 * @return IStorage
 	 */
 	public function wrap(IMountPoint $mountPoint, $storage) {
 		$wrappers = \array_values($this->storageWrappers);

lib/private/Files/Storage/Wrapper/Encryption.php

Doc Comments +7 added lines, -7 removed lines

@@ -360,7 +360,7 @@ 
 	 *
 	 * @param string $path
 	 * @param string $mode
-	 * @return resource|bool
+	 * @return resource
 	 * @throws GenericEncryptionException
 	 * @throws ModuleDoesNotExistsException
 	 */
@@ -644,7 +644,7 @@ 
 	 * Set the flag to true, so that the file would be
 	 * in the decrypted state.
 	 *
-	 * @param $isDisabled bool
+	 * @param boolean $isDisabled bool
 	 */
 	public static function setDisableWriteEncryption($isDisabled) {
 		self::$disableWriteEncryption = $isDisabled;
@@ -673,7 +673,7 @@ 
 	/**
 	 * Update the encrypted cache version in the database
 	 *
-	 * @param Storage $sourceStorage
+	 * @param Storage\IStorage $sourceStorage
 	 * @param string $sourceInternalPath
 	 * @param string $targetInternalPath
 	 * @param bool $isRename
@@ -718,7 +718,7 @@ 
 	/**
 	 * copy file between two storages
 	 *
-	 * @param Storage $sourceStorage
+	 * @param Storage\IStorage $sourceStorage
 	 * @param string $sourceInternalPath
 	 * @param string $targetInternalPath
 	 * @param bool $preserveMtime
@@ -902,7 +902,7 @@ 
 	/**
 	 * return header size of given file
 	 *
-	 * @param string|resource $path
+	 * @param string $path
 	 * @return int
 	 */
 	protected function getHeaderSize($path) {
@@ -953,7 +953,7 @@ 
 	/**
 	 * read header from file
 	 *
-	 * @param string|resource $path
+	 * @param string $path
 	 * @return array
 	 */
 	protected function getHeader($path) {
@@ -1049,7 +1049,7 @@ 
 	/**
 	 * check if path points to a files version
 	 *
-	 * @param $path
+	 * @param string $path
 	 * @return bool
 	 */
 	protected function isVersion($path) {

apps/files_external/lib/Lib/Storage/SFTP.php

Unused Use Statements -1 removed lines

@@ -34,7 +34,6 @@
 namespace OCA\Files_External\Lib\Storage;
 use function GuzzleHttp\Psr7\stream_for;
 use Icewind\Streams\IteratorDirectory;
-use Icewind\Streams\RetryWrapper;
 use OCP\Files\Storage\StorageAdapter;
 use phpseclib\Net\SFTP\Stream;
 use Psr\Http\Message\StreamInterface;

apps/files_external/lib/Lib/Storage/SMB.php

Unused Use Statements -1 removed lines

@@ -45,7 +45,6 @@
 use Icewind\SMB\ServerFactory;
 use Icewind\SMB\System;
 use Icewind\SMB\IShare;
-use Icewind\Streams\CallbackWrapper;
 use Icewind\Streams\IteratorDirectory;
 use OC\Cache\CappedMemoryCache;
 use OC\Files\Filesystem;

lib/private/Files/Filesystem.php

Doc Comments +27 added lines, -4 removed lines

@@ -359,6 +359,10 @@ 
 		}
 	}
 
+	/**
+	 * @param string|boolean $user
+	 * @param string $root
+	 */
 	public static function init($user, $root) {
 		if (self::$defaultInstance) {
 			return false;
@@ -517,7 +521,7 @@ 
 	/**
 	 * mount an \OC\Files\Storage\Storage in our virtual filesystem
 	 *
-	 * @param \OC\Files\Storage\Storage|string $class
+	 * @param string $class
 	 * @param array $arguments
 	 * @param string $mountpoint
 	 */
@@ -690,6 +694,9 @@ 
 		return self::$defaultInstance->is_dir($path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function is_file($path) {
 		return self::$defaultInstance->is_file($path);
 	}
@@ -702,6 +709,9 @@ 
 		return self::$defaultInstance->filetype($path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function filesize($path) {
 		return self::$defaultInstance->filesize($path);
 	}
@@ -714,6 +724,9 @@ 
 		return self::$defaultInstance->isCreatable($path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function isReadable($path) {
 		return self::$defaultInstance->isReadable($path);
 	}
@@ -726,6 +739,9 @@ 
 		return self::$defaultInstance->isDeletable($path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function isSharable($path) {
 		return self::$defaultInstance->isSharable($path);
 	}
@@ -743,6 +759,7 @@ 
 	}
 
 	/**
+	 * @param string $path
 	 * @return string
 	 */
 	public static function file_get_contents($path) {
@@ -766,8 +783,8 @@ 
 	}
 
 	/**
-	 * @param $path
-	 * @param $mode
+	 * @param string $path
+	 * @param string $mode
 	 * @return resource
 	 * @deprecated 11.0.0
 	 */
@@ -786,6 +803,9 @@ 
 		return self::$defaultInstance->fromTmpFile($tmpFile, $path);
 	}
 
+	/**
+	 * @param string $path
+	 */
 	public static function getMimeType($path) {
 		return self::$defaultInstance->getMimeType($path);
 	}
@@ -798,6 +818,9 @@ 
 		return self::$defaultInstance->free_space($path);
 	}
 
+	/**
+	 * @param string $query
+	 */
 	public static function search($query) {
 		return self::$defaultInstance->search($query);
 	}
@@ -907,7 +930,7 @@ 
 	 * @param string $path
 	 * @param boolean $includeMountPoints whether to add mountpoint sizes,
 	 * defaults to true
-	 * @return \OC\Files\FileInfo|bool False if file does not exist
+	 * @return \OCP\Files\FileInfo|null False if file does not exist
 	 */
 	public static function getFileInfo($path, $includeMountPoints = true) {
 		return self::$defaultInstance->getFileInfo($path, $includeMountPoints);