Completed
Pull Request — master (#26588)
by Thomas
09:07
created
lib/private/App/AppManager.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	/**
121 121
 	 * List all installed apps
122 122
 	 *
123
-	 * @return string[]
123
+	 * @return integer[]
124 124
 	 */
125 125
 	public function getInstalledApps() {
126 126
 		return array_keys($this->getInstalledAppsValues());
@@ -347,6 +347,9 @@  discard block
 block discarded – undo
347 347
 		return in_array($appId, $this->shippedApps);
348 348
 	}
349 349
 
350
+	/**
351
+	 * @param string $appId
352
+	 */
350 353
 	private function isAlwaysEnabled($appId) {
351 354
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
352 355
 		return in_array($appId, $alwaysEnabled);
@@ -374,7 +377,7 @@  discard block
 block discarded – undo
374 377
 
375 378
 	/**
376 379
 	 * @param string $package
377
-	 * @return mixed
380
+	 * @return integer
378 381
 	 * @since 9.2.0
379 382
 	 */
380 383
 	public function installApp($package) {
@@ -386,7 +389,7 @@  discard block
 block discarded – undo
386 389
 
387 390
 	/**
388 391
 	 * @param string $package
389
-	 * @return mixed
392
+	 * @return boolean
390 393
 	 * @since 9.2.0
391 394
 	 */
392 395
 	public function updateApp($package) {
Please login to merge, or discard this patch.
apps/updatenotification/lib/Notification/BackgroundJob.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 
25 25
 use OC\BackgroundJob\TimedJob;
26
-use OC\Installer;
27 26
 use OC\Updater\VersionCheck;
28 27
 use OCP\App\IAppManager;
29 28
 use OCP\Http\Client\IClientService;
Please login to merge, or discard this patch.
lib/private/legacy/app.php 1 patch
Doc Comments   +2 added lines, -5 removed lines patch added patch discarded remove patch
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 
164 164
 	/**
165 165
 	 * Enables the app as a theme if it has the type "theme"
166
-	 * @param $app
166
+	 * @param string $app
167 167
 	 */
168 168
 	private static function enableThemeIfApplicable($app) {
169 169
 		if (self::isType($app, 'theme')) {
@@ -815,9 +815,6 @@  discard block
 block discarded – undo
815 815
 	/**
816 816
 	 * List all apps, this is used in apps.php
817 817
 	 *
818
-	 * @param bool $onlyLocal
819
-	 * @param bool $includeUpdateInfo Should we check whether there is an update
820
-	 *                                in the app store?
821 818
 	 * @return array
822 819
 	 */
823 820
 	public static function listAllApps() {
@@ -1172,7 +1169,7 @@  discard block
 block discarded – undo
1172 1169
 	}
1173 1170
 
1174 1171
 	/**
1175
-	 * @param $config
1172
+	 * @param OCP\IConfig $config
1176 1173
 	 * @param \OCP\IL10N $l
1177 1174
 	 * @param $info
1178 1175
 	 * @throws Exception
Please login to merge, or discard this patch.
settings/Application.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,6 @@
 block discarded – undo
31 31
 
32 32
 use OC\Files\View;
33 33
 use OC\Server;
34
-use OC\Settings\Controller\AppSettingsController;
35 34
 use OC\Settings\Controller\AuthSettingsController;
36 35
 use OC\Settings\Controller\CertificateController;
37 36
 use OC\Settings\Controller\CheckSetupController;
Please login to merge, or discard this patch.