Completed
Pull Request — master (#29319)
by Thomas
08:25
created
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -191,6 +191,7 @@
 block discarded – undo
191 191
 
192 192
 /**
193 193
  * @param string $path
194
+ * @param string $token
194 195
  */
195 196
 function publicPreview_icon ( $path, $token ) {
196 197
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.
lib/private/Preview/Movie.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
 	}
82 82
 
83 83
 	/**
84
-	 * @param $absPath
85
-	 * @return bool|string
84
+	 * @param string $absPath
85
+	 * @return false|string
86 86
 	 */
87 87
 	private function extractMp4CoverArtwork($absPath) {
88 88
 		if (isset($this->noArtworkIndex[$absPath])) {
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
 	}
119 119
 
120 120
 	/**
121
-	 * @param $absPath
122
-	 * @param $second
123
-	 * @return bool|string
121
+	 * @param string $absPath
122
+	 * @param integer $second
123
+	 * @return string|false
124 124
 	 */
125 125
 	private function generateFromMovie($absPath, $second) {
126 126
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();
Please login to merge, or discard this patch.
lib/private/Files/Node/Root.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 	 * @param string $path
175 175
 	 * @throws \OCP\Files\NotFoundException
176 176
 	 * @throws \OCP\Files\NotPermittedException
177
-	 * @return string
177
+	 * @return \OCP\Files\Node
178 178
 	 */
179 179
 	public function get($path) {
180 180
 		$path = $this->normalizePath($path);
@@ -371,6 +371,9 @@  discard block
 block discarded – undo
371 371
 
372 372
 	}
373 373
 
374
+	/**
375
+	 * @param string $fullPath
376
+	 */
374 377
 	private function resolveVirtualNode($fullPath) {
375 378
 		$pieces = explode('/', $fullPath);
376 379
 		if ($pieces[1] !== 'meta') {
Please login to merge, or discard this patch.
lib/private/Files/Storage/Common.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -721,7 +721,7 @@
 block discarded – undo
721 721
 	}
722 722
 
723 723
 	/**
724
-	 * @param $internalPath
724
+	 * @param string $internalPath
725 725
 	 * @return array|string
726 726
 	 */
727 727
 	private function convertInternalPathToGlobalPath($internalPath) {
Please login to merge, or discard this patch.
apps/dav/lib/Meta/MetaFile.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@
 block discarded – undo
26 26
 use OC\Files\Meta\MetaFileVersionNode;
27 27
 use OCA\DAV\Files\ICopySource;
28 28
 use OCA\DAV\Files\IFileNode;
29
-use OCP\Files\FileInfo;
30 29
 use OCP\Files\Node;
31 30
 use Sabre\DAV\File;
32 31
 
Please login to merge, or discard this patch.
lib/private/Preview.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -257,7 +257,6 @@  discard block
 block discarded – undo
257 257
 	 * Sets the path of the file you want a preview of
258 258
 	 *
259 259
 	 * @param File $file
260
-	 * @param \OCP\Files\FileInfo|null $info
261 260
 	 * @param string $versionId
262 261
 	 *
263 262
 	 * @return Preview
@@ -919,7 +918,7 @@  discard block
 block discarded – undo
919 918
 	 * @param int $previewWidth
920 919
 	 * @param int $previewHeight
921 920
 	 *
922
-	 * @return int[]
921
+	 * @return double[]
923 922
 	 */
924 923
 	private function scale($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
925 924
 		$scalingUp = $this->getScalingUp();
Please login to merge, or discard this patch.