Completed
Push — master ( fcf463...00ea85 )
by Phil
09:08
created
lib/private/Settings/SettingsManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,6 @@
 block discarded – undo
34 34
 use OCP\IGroupManager;
35 35
 use OCP\Defaults;
36 36
 use OCP\IURLGenerator;
37
-
38 37
 use OC\Settings\Panels\Personal\Profile;
39 38
 use OC\Settings\Panels\Personal\Legacy as LegacyPersonal;
40 39
 use OC\Settings\Panels\Admin\Legacy as LegacyAdmin;
Please login to merge, or discard this patch.
lib/private/Repair/RepairMismatchFileCachePath.php 1 patch
Doc Comments   +14 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 	 * @param string $wrongPath wrong path of the entry to fix
96 96
 	 * @param int $correctStorageNumericId numeric idea of the correct storage
97 97
 	 * @param string $correctPath value to which to set the path of the entry 
98
-	 * @return bool true for success
98
+	 * @return boolean|null true for success
99 99
 	 */
100 100
 	private function fixEntryPath(IOutput $out, $fileId, $wrongPath, $correctStorageNumericId, $correctPath) {
101 101
 		// delete target if exists
@@ -125,6 +125,9 @@  discard block
 block discarded – undo
125 125
 		$out->advance(1, $text);
126 126
 	}
127 127
 
128
+	/**
129
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
130
+	 */
128 131
 	private function addQueryConditionsParentIdWrongPath($qb) {
129 132
 		// thanks, VicDeo!
130 133
 		if ($this->connection->getDatabasePlatform() instanceof MySqlPlatform) {
@@ -164,6 +167,9 @@  discard block
 block discarded – undo
164 167
 		}
165 168
 	}
166 169
 
170
+	/**
171
+	 * @param \OCP\DB\QueryBuilder\IQueryBuilder $qb
172
+	 */
167 173
 	private function addQueryConditionsNonExistingParentIdEntry($qb, $storageNumericId = null) {
168 174
 		// Subquery for parent existence
169 175
 		$qbe = $this->connection->getQueryBuilder();
@@ -193,6 +199,9 @@  discard block
 block discarded – undo
193 199
 		}
194 200
 	}
195 201
 
202
+	/**
203
+	 * @param integer $storageNumericId
204
+	 */
196 205
 	private function countResultsToProcessParentIdWrongPath($storageNumericId = null) {
197 206
 		$qb = $this->connection->getQueryBuilder();
198 207
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -203,6 +212,9 @@  discard block
 block discarded – undo
203 212
 		return $count;
204 213
 	}
205 214
 
215
+	/**
216
+	 * @param integer $storageNumericId
217
+	 */
206 218
 	private function countResultsToProcessNonExistingParentIdEntry($storageNumericId = null) {
207 219
 		$qb = $this->connection->getQueryBuilder();
208 220
 		$qb->select($qb->createFunction('COUNT(*)'));
@@ -353,6 +365,7 @@  discard block
 block discarded – undo
353 365
 	 *
354 366
 	 * @param int $storageId storage id
355 367
 	 * @param string $path path for which to create the parent entry
368
+	 * @param integer $reuseFileId
356 369
 	 * @return int file id of the newly created parent
357 370
 	 */
358 371
 	private function getOrCreateEntry($storageId, $path, $reuseFileId = null) {
Please login to merge, or discard this patch.