owncloud / core

lib/private/User/Manager.php

Unused Use Statements -3 removed lines

@@ -39,9 +39,6 @@
 use OCP\IUser;
 use OCP\IUserManager;
 use OCP\IConfig;
-use OCP\User\IProvidesExtendedSearchBackend;
-use OCP\User\IProvidesEMailBackend;
-use OCP\User\IProvidesQuotaBackend;
 use OCP\UserInterface;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

Doc Comments +4 added lines, -1 removed lines

@@ -341,7 +341,7 @@ 
 	/**
 	 * @param string $uid
 	 * @param UserInterface $backend
-	 * @return IUser | null
+	 * @return null|User | null
 	 * @deprecated core is responsible for creating accounts, see user_ldap how it is done
 	 */
 	public function createUserFromBackend($uid, $password, $backend) {
@@ -421,6 +421,9 @@ 
 		}, $accounts);
 	}
 
+	/**
+	 * @param string $backendClass
+	 */
 	public function getBackend($backendClass) {
 		if (isset($this->backends[$backendClass])) {
 			return $this->backends[$backendClass];

lib/private/User/User.php

Doc Comments +5 added lines, -1 removed lines

@@ -78,7 +78,7 @@ 
 	 *
 	 * @param Account $account
 	 * @param AccountMapper $mapper
-	 * @param null $emitter
+	 * @param Manager $emitter
 	 * @param IConfig|null $config
 	 * @param null $urlGenerator
 	 * @param EventDispatcher|null $eventDispatcher
@@ -452,6 +452,10 @@ 
 		return $url;
 	}
 
+	/**
+	 * @param string $feature
+	 * @param string $value
+	 */
 	public function triggerChange($feature, $value = null) {
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);

Unused Use Statements -1 removed lines

@@ -41,7 +41,6 @@
 use OCP\IConfig;
 use OCP\IUserBackend;
 use OCP\User\IChangePasswordBackend;
-use OCP\UserInterface;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\GenericEvent;
 

lib/private/User/Session.php

Doc Comments +9 added lines, -4 removed lines

@@ -312,7 +312,7 @@ 
 	 * @param IRequest $request
 	 * @throws LoginException
 	 * @throws PasswordLoginForbiddenException
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	public function logClientIn($user, $password, IRequest $request) {
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -355,6 +355,9 @@ 
 		return $this->config->getSystemValue('token_auth_enforced', false);
 	}
 
+	/**
+	 * @param string $username
+	 */
 	protected function isTwoFactorEnforced($username) {
 		Util::emitHook(
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -555,7 +558,6 @@ 
 	 *
 	 * Log in a user and regenerate a new session.
 	 *
-	 * @param \OCP\Authentication\IApacheBackend $backend
 	 * @return bool
 	 * @throws LoginException
 	 */
@@ -889,7 +891,7 @@ 
 	/**
 	 * logout the user from the session
 	 *
-	 * @return bool
+	 * @return boolean|null
 	 */
 	public function logout() {
 
@@ -970,6 +972,9 @@ 
 		}
 	}
 
+	/**
+	 * @param IRequest $request
+	 */
 	public function verifyAuthHeaders($request) {
 		foreach ($this->getAuthModules(true) as $module) {
 			$user = $module->auth($request);
@@ -989,7 +994,7 @@ 
 	}
 
 	/**
-	 * @param $includeBuiltIn
+	 * @param boolean $includeBuiltIn
 	 * @return \Generator | IAuthModule[]
 	 * @throws Exception
 	 */

Unused Use Statements -1 removed lines

@@ -53,7 +53,6 @@
 use OCP\IRequest;
 use OCP\ISession;
 use OCP\IUser;
-use OCP\IUserBackend;
 use OCP\IUserManager;
 use OCP\IUserSession;
 use OCP\Session\Exceptions\SessionNotAvailableException;