Completed
Pull Request — master (#29107)
by Piotr
09:51
created
lib/private/MembershipManager.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
 	 * are users in the group (identified by backend group id
492 492
 	 * if $isBackendGroupId is true, or gid if $isBackendGroupId is false)
493 493
 	 *
494
-	 * @param string|int $groupId
494
+	 * @param string $groupId
495 495
 	 * @param bool $isBackendGroupId
496 496
 	 * @param string $pattern
497 497
 	 * @return int
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 
570 570
 	/**
571 571
 	 * @param IQueryBuilder $qb
572
-	 * @return int
572
+	 * @return boolean
573 573
 	 */
574 574
 	private function getAffectedQuery(IQueryBuilder $qb) {
575 575
 		// If affected is equal or more then 1, it means operation was successful
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 use OC\Group\BackendGroup;
25 25
 use OC\User\Account;
26
-use OCP\AppFramework\Db\Entity;
27 26
 use OCP\IConfig;
28 27
 use OCP\IDBConnection;
29 28
 use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
Please login to merge, or discard this patch.
lib/private/Group/GroupMapper.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -71,6 +71,10 @@
 block discarded – undo
71 71
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
72 72
 	}
73 73
 
74
+	/**
75
+	 * @param \Closure $callback
76
+	 * @param string $search
77
+	 */
74 78
 	public function callForAllGroups($callback, $search) {
75 79
 		$qb = $this->db->getQueryBuilder();
76 80
 		$qb->select(['*'])
Please login to merge, or discard this patch.
lib/private/Group/Manager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -263,7 +263,7 @@
 block discarded – undo
263 263
 	 *
264 264
 	 * @param \OC\User\User|null|false $user
265 265
 	 * @param string|null $scope string
266
-	 * @return array with group ids
266
+	 * @return integer[] with group ids
267 267
 	 */
268 268
 	public function getUserGroupIds($user, $scope = null) {
269 269
 		/** @var \OCP\IGroup[] $groupsForUser */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,6 @@
 block discarded – undo
46 46
 use OCP\AppFramework\Db\DoesNotExistException;
47 47
 use OCP\AppFramework\Db\MultipleObjectsReturnedException;
48 48
 use OCP\GroupInterface;
49
-use OCP\IDBConnection;
50 49
 use OCP\IGroup;
51 50
 use OCP\IGroupManager;
52 51
 
Please login to merge, or discard this patch.
lib/private/User/User.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 	 * @param Account $account
87 87
 	 * @param AccountMapper $mapper
88 88
 	 * @param MembershipManager $membershipManager
89
-	 * @param null $emitter
89
+	 * @param Manager $emitter
90 90
 	 * @param IConfig|null $config
91 91
 	 * @param null $urlGenerator
92 92
 	 * @param EventDispatcher|null $eventDispatcher
@@ -479,6 +479,10 @@  discard block
 block discarded – undo
479 479
 		return $url;
480 480
 	}
481 481
 
482
+	/**
483
+	 * @param string $feature
484
+	 * @param string $value
485
+	 */
482 486
 	public function triggerChange($feature, $value = null) {
483 487
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields(), true)) {
484 488
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.