Completed
Pull Request — master (#29669)
by Tom
09:17
created
lib/private/User/Manager.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -432,6 +432,9 @@
 block discarded – undo
432 432
 		}, $accounts);
433 433
 	}
434 434
 
435
+	/**
436
+	 * @param string $backendClass
437
+	 */
435 438
 	public function getBackend($backendClass) {
436 439
 		if (isset($this->backends[$backendClass])) {
437 440
 			return $this->backends[$backendClass];
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -39,9 +39,6 @@
 block discarded – undo
39 39
 use OCP\IUser;
40 40
 use OCP\IUserManager;
41 41
 use OCP\IConfig;
42
-use OCP\User\IProvidesExtendedSearchBackend;
43
-use OCP\User\IProvidesEMailBackend;
44
-use OCP\User\IProvidesQuotaBackend;
45 42
 use OCP\UserInterface;
46 43
 use Symfony\Component\EventDispatcher\GenericEvent;
47 44
 
Please login to merge, or discard this patch.
lib/private/User/User.php 2 patches
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 	 *
79 79
 	 * @param Account $account
80 80
 	 * @param AccountMapper $mapper
81
-	 * @param null $emitter
81
+	 * @param Manager $emitter
82 82
 	 * @param IConfig|null $config
83 83
 	 * @param null $urlGenerator
84 84
 	 * @param EventDispatcher|null $eventDispatcher
@@ -452,6 +452,10 @@  discard block
 block discarded – undo
452 452
 		return $url;
453 453
 	}
454 454
 
455
+	/**
456
+	 * @param string $feature
457
+	 * @param string $value
458
+	 */
455 459
 	public function triggerChange($feature, $value = null) {
456 460
 		if ($this->emitter && in_array($feature, $this->account->getUpdatedFields())) {
457 461
 			$this->emitter->emit('\OC\User', 'changeUser', [$this, $feature, $value]);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,6 @@
 block discarded – undo
41 41
 use OCP\IConfig;
42 42
 use OCP\IUserBackend;
43 43
 use OCP\User\IChangePasswordBackend;
44
-use OCP\UserInterface;
45 44
 use Symfony\Component\EventDispatcher\EventDispatcher;
46 45
 use Symfony\Component\EventDispatcher\GenericEvent;
47 46
 
Please login to merge, or discard this patch.
lib/private/User/Session.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,6 @@
 block discarded – undo
53 53
 use OCP\IRequest;
54 54
 use OCP\ISession;
55 55
 use OCP\IUser;
56
-use OCP\IUserBackend;
57 56
 use OCP\IUserManager;
58 57
 use OCP\IUserSession;
59 58
 use OCP\Session\Exceptions\SessionNotAvailableException;
Please login to merge, or discard this patch.
Doc Comments   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
 	 * @param IRequest $request
316 316
 	 * @throws LoginException
317 317
 	 * @throws PasswordLoginForbiddenException
318
-	 * @return boolean
318
+	 * @return boolean|null
319 319
 	 */
320 320
 	public function logClientIn($user, $password, IRequest $request) {
321 321
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -358,6 +358,9 @@  discard block
 block discarded – undo
358 358
 		return $this->config->getSystemValue('token_auth_enforced', false);
359 359
 	}
360 360
 
361
+	/**
362
+	 * @param string $username
363
+	 */
361 364
 	protected function isTwoFactorEnforced($username) {
362 365
 		Util::emitHook(
363 366
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -560,7 +563,6 @@  discard block
 block discarded – undo
560 563
 	 *
561 564
 	 * Log in a user and regenerate a new session.
562 565
 	 *
563
-	 * @param \OCP\Authentication\IApacheBackend $backend
564 566
 	 * @return bool
565 567
 	 * @throws LoginException
566 568
 	 */
@@ -980,6 +982,9 @@  discard block
 block discarded – undo
980 982
 		}
981 983
 	}
982 984
 
985
+	/**
986
+	 * @param IRequest $request
987
+	 */
983 988
 	public function verifyAuthHeaders($request) {
984 989
 		foreach ($this->getAuthModules(true) as $module) {
985 990
 			$user = $module->auth($request);
@@ -999,7 +1004,7 @@  discard block
 block discarded – undo
999 1004
 	}
1000 1005
 
1001 1006
 	/**
1002
-	 * @param $includeBuiltIn
1007
+	 * @param boolean $includeBuiltIn
1003 1008
 	 * @return \Generator | IAuthModule[]
1004 1009
 	 * @throws Exception
1005 1010
 	 */
Please login to merge, or discard this patch.