Completed
Pull Request — master (#22299)
by Erik
13:51
created
apps/user_ldap/command/setconfig.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,6 @@
 block discarded – undo
73 73
 	/**
74 74
 	 * save the configuration value as provided
75 75
 	 * @param string $configID
76
-	 * @param string $configKey
77
-	 * @param string $configValue
78 76
 	 */
79 77
 	protected function setValue($configID, $key, $value) {
80 78
 		$configHolder = new Configuration($configID);
Please login to merge, or discard this patch.
apps/user_ldap/lib/jobs.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 	}
69 69
 
70 70
 	/**
71
-	 * @return int
71
+	 * @return string
72 72
 	 */
73 73
 	static private function getRefreshInterval() {
74 74
 		//defaults to every hour
Please login to merge, or discard this patch.
apps/user_ldap/lib/wizard.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
 	 * @param integer $filterType int, for which use case the filter shall be created
865 865
 	 * can be any of self::LFILTER_USER_LIST, self::LFILTER_LOGIN or
866 866
 	 * self::LFILTER_GROUP_LIST
867
-	 * @return string|false string with the filter on success, false otherwise
867
+	 * @return string string with the filter on success, false otherwise
868 868
 	 * @throws \Exception
869 869
 	 */
870 870
 	private function composeLdapFilter($filterType) {
@@ -1107,7 +1107,7 @@  discard block
 block discarded – undo
1107 1107
 	}
1108 1108
 
1109 1109
 	/**
1110
-	 * @param array $reqs
1110
+	 * @param string[] $reqs
1111 1111
 	 * @return bool
1112 1112
 	 */
1113 1113
 	private function checkRequirements($reqs) {
Please login to merge, or discard this patch.
lib/private/api.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 	/**
189 189
 	 * merge the returned result objects into one response
190 190
 	 * @param array $responses
191
-	 * @return array|\OC_OCS_Result
191
+	 * @return OC_OCS_Result
192 192
 	 */
193 193
 	public static function mergeResponses($responses) {
194 194
 		// Sort into shipped and third-party
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 
335 335
 	/**
336 336
 	 * http basic auth
337
-	 * @return string|false (username, or false on failure)
337
+	 * @return string (username, or false on failure)
338 338
 	 */
339 339
 	private static function loginUser() {
340 340
 		if(self::$isLoggedIn === true) {
@@ -440,6 +440,7 @@  discard block
 block discarded – undo
440 440
 
441 441
 	/**
442 442
 	 * Based on the requested format the response content type is set
443
+	 * @param string $format
443 444
 	 */
444 445
 	public static function setContentType($format = null) {
445 446
 		$format = is_null($format) ? self::requestedFormat() : $format;
Please login to merge, or discard this patch.
lib/private/app/appmanager.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 	/**
89 89
 	 * List all installed apps
90 90
 	 *
91
-	 * @return string[]
91
+	 * @return integer[]
92 92
 	 */
93 93
 	public function getInstalledApps() {
94 94
 		return array_keys($this->getInstalledAppsValues());
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 	/**
217 217
 	 * Returns a list of apps that need upgrade
218 218
 	 *
219
-	 * @param array $version ownCloud version as array of version components
219
+	 * @param array $ocVersion ownCloud version as array of version components
220 220
 	 * @return array list of app info from apps that need an upgrade
221 221
 	 *
222 222
 	 * @internal
@@ -289,6 +289,9 @@  discard block
 block discarded – undo
289 289
 		return in_array($appId, $this->shippedApps);
290 290
 	}
291 291
 
292
+	/**
293
+	 * @param string $appId
294
+	 */
292 295
 	private function isAlwaysEnabled($appId) {
293 296
 		$alwaysEnabled = $this->getAlwaysEnabledApps();
294 297
 		return in_array($appId, $alwaysEnabled);
Please login to merge, or discard this patch.
lib/private/db/connection.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 	 * If an SQLLogger is configured, the execution is logged.
168 168
 	 *
169 169
 	 * @param string                                      $query  The SQL query to execute.
170
-	 * @param array                                       $params The parameters to bind to the query, if any.
170
+	 * @param string[]                                       $params The parameters to bind to the query, if any.
171 171
 	 * @param array                                       $types  The types the previous parameters are in.
172 172
 	 * @param \Doctrine\DBAL\Cache\QueryCacheProfile|null $qcp    The query cache profile, optional.
173 173
 	 *
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 	 * columns or sequences.
213 213
 	 *
214 214
 	 * @param string $seqName Name of the sequence object from which the ID should be returned.
215
-	 * @return string A string representation of the last inserted ID.
215
+	 * @return integer A string representation of the last inserted ID.
216 216
 	 */
217 217
 	public function lastInsertId($seqName = null)
218 218
 	{
Please login to merge, or discard this patch.
lib/private/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/files/storage/wrapper/encryption.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -777,7 +777,7 @@
 block discarded – undo
777 777
 	/**
778 778
 	 * check if path points to a files version
779 779
 	 *
780
-	 * @param $path
780
+	 * @param string $path
781 781
 	 * @return bool
782 782
 	 */
783 783
 	protected function isVersion($path) {
Please login to merge, or discard this patch.
lib/private/files/stream/encryption.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
 	 *
176 176
 	 * @param resource $source
177 177
 	 * @param string $mode
178
-	 * @param array $context
178
+	 * @param resource $context
179 179
 	 * @param string $protocol
180 180
 	 * @param string $class
181 181
 	 * @return resource
Please login to merge, or discard this patch.