Completed
Pull Request — master (#22299)
by Erik
13:51
created
settings/controller/certificatecontroller.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	 *
71 71
 	 * @NoAdminRequired
72 72
 	 * @NoSubadminRequired
73
-	 * @return array
73
+	 * @return DataResponse
74 74
 	 */
75 75
 	public function addPersonalRootCertificate() {
76 76
 		return $this->addCertificate($this->userCertificateManager);
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 * Add a new root certificate to a trust store
81 81
 	 *
82 82
 	 * @param ICertificateManager $certificateManager
83
-	 * @return array
83
+	 * @return DataResponse
84 84
 	 */
85 85
 	private function addCertificate(ICertificateManager $certificateManager) {
86 86
 		$headers = [];
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
 	/**
159 159
 	 * Add a new personal root certificate to the system's trust store
160 160
 	 *
161
-	 * @return array
161
+	 * @return DataResponse
162 162
 	 */
163 163
 	public function addSystemRootCertificate() {
164 164
 		return $this->addCertificate($this->systemCertificateManager);
Please login to merge, or discard this patch.
apps/files_trashbin/lib/trashbin.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
 
73 73
 	/**
74 74
 	 * @param string $filename
75
-	 * @return array
75
+	 * @return string[]
76 76
 	 * @throws \OC\User\NoUserException
77 77
 	 */
78 78
 	public static function getUidAndFilename($filename) {
@@ -649,7 +649,7 @@  discard block
 block discarded – undo
649 649
 	 * if the size limit for the trash bin is reached, we delete the oldest
650 650
 	 * files in the trash bin until we meet the limit again
651 651
 	 *
652
-	 * @param array $files
652
+	 * @param \OCP\Files\FileInfo[] $files
653 653
 	 * @param string $user
654 654
 	 * @param int $availableSpace available disc space
655 655
 	 * @return int size of deleted files
@@ -677,7 +677,7 @@  discard block
 block discarded – undo
677 677
 	/**
678 678
 	 * delete files older then max storage time
679 679
 	 *
680
-	 * @param array $files list of files sorted by mtime
680
+	 * @param \OCP\Files\FileInfo[] $files list of files sorted by mtime
681 681
 	 * @param string $user
682 682
 	 * @return integer[] size of deleted files and number of deleted files
683 683
 	 */
Please login to merge, or discard this patch.
apps/files_versions/lib/storage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
 	 * Returns the list of members for a group-principal
137 137
 	 *
138 138
 	 * @param string $principal
139
-	 * @return array
139
+	 * @return string[]
140 140
 	 */
141 141
 	function getGroupMemberSet($principal) {
142 142
 		// TODO: for now the group principal has only one member, the user itself
Please login to merge, or discard this patch.
core/command/security/listcertificates.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use Symfony\Component\Console\Command\Command;
29 29
 use Symfony\Component\Console\Helper\Table;
30 30
 use Symfony\Component\Console\Input\InputInterface;
31
-use Symfony\Component\Console\Input\InputOption;
32 31
 use Symfony\Component\Console\Output\OutputInterface;
33 32
 
34 33
 class ListCertificates extends Base {
Please login to merge, or discard this patch.
lib/private/files/storage/storage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -99,6 +99,7 @@  discard block
 block discarded – undo
99 99
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
100 100
 	 * @param \OCP\Lock\ILockingProvider $provider
101 101
 	 * @throws \OCP\Lock\LockedException
102
+	 * @return void
102 103
 	 */
103 104
 	public function acquireLock($path, $type, ILockingProvider $provider);
104 105
 
@@ -106,6 +107,7 @@  discard block
 block discarded – undo
106 107
 	 * @param string $path The path of the file to release the lock for
107 108
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
108 109
 	 * @param \OCP\Lock\ILockingProvider $provider
110
+	 * @return void
109 111
 	 */
110 112
 	public function releaseLock($path, $type, ILockingProvider $provider);
111 113
 
@@ -114,6 +116,7 @@  discard block
 block discarded – undo
114 116
 	 * @param int $type \OCP\Lock\ILockingProvider::LOCK_SHARED or \OCP\Lock\ILockingProvider::LOCK_EXCLUSIVE
115 117
 	 * @param \OCP\Lock\ILockingProvider $provider
116 118
 	 * @throws \OCP\Lock\LockedException
119
+	 * @return void
117 120
 	 */
118 121
 	public function changeLock($path, $type, ILockingProvider $provider);
119 122
 }
Please login to merge, or discard this patch.
lib/private/files/view.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 	 * and does not take the chroot into account )
196 196
 	 *
197 197
 	 * @param string $path
198
-	 * @return \OCP\Files\Mount\IMountPoint
198
+	 * @return Mount\MountPoint|null
199 199
 	 */
200 200
 	public function getMount($path) {
201 201
 		return Filesystem::getMountManager()->find($this->getAbsolutePath($path));
@@ -906,7 +906,7 @@  discard block
 block discarded – undo
906 906
 
907 907
 	/**
908 908
 	 * @param string $path
909
-	 * @return bool|string
909
+	 * @return string|false
910 910
 	 * @throws \OCP\Files\InvalidPathException
911 911
 	 */
912 912
 	public function toTmpFile($path) {
@@ -2029,7 +2029,7 @@  discard block
 block discarded – undo
2029 2029
 
2030 2030
 	/**
2031 2031
 	 * @param string $filename
2032
-	 * @return array
2032
+	 * @return string[]
2033 2033
 	 * @throws \OC\User\NoUserException
2034 2034
 	 * @throws NotFoundException
2035 2035
 	 */
Please login to merge, or discard this patch.
apps/dav/command/syncsystemaddressbook.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,6 @@
 block discarded – undo
44 44
 	private $syncService;
45 45
 
46 46
 	/**
47
-	 * @param IUserManager $userManager
48 47
 	 * @param SyncService $syncService
49 48
 	 */
50 49
 	function __construct(SyncService $syncService) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
 use OCP\IUserManager;
25 25
 use Symfony\Component\Console\Command\Command;
26 26
 use Symfony\Component\Console\Helper\ProgressBar;
27
-use Symfony\Component\Console\Input\InputArgument;
28 27
 use Symfony\Component\Console\Input\InputInterface;
29 28
 use Symfony\Component\Console\Output\OutputInterface;
30 29
 
Please login to merge, or discard this patch.
apps/dav/lib/carddav/syncservice.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@
 block discarded – undo
227 227
 	}
228 228
 
229 229
 	/**
230
-	 * @return array|null
230
+	 * @return string
231 231
 	 */
232 232
 	public function getLocalSystemAddressBook() {
233 233
 		if (is_null($this->localSystemAddressBook)) {
Please login to merge, or discard this patch.
apps/dav/command/createaddressbook.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -50,7 +50,6 @@
 block discarded – undo
50 50
 	/**
51 51
 	 * @param IUserManager $userManager
52 52
 	 * @param IDBConnection $dbConnection
53
-	 * @param IConfig $config
54 53
 	 * @param ILogger $logger
55 54
 	 */
56 55
 	function __construct(IUserManager $userManager,
Please login to merge, or discard this patch.