Completed
Pull Request — master (#30106)
by Juan Pablo
13:21
created
lib/public/Share/IShareProvider.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,6 +63,7 @@  discard block
 block discarded – undo
63 63
 	 *
64 64
 	 * @param \OCP\Share\IShare $share
65 65
 	 * @since 9.0.0
66
+	 * @return void
66 67
 	 */
67 68
 	public function delete(\OCP\Share\IShare $share);
68 69
 
@@ -74,6 +75,7 @@  discard block
 block discarded – undo
74 75
 	 * @param \OCP\Share\IShare $share
75 76
 	 * @param string $recipient UserId of the recipient
76 77
 	 * @since 9.0.0
78
+	 * @return void
77 79
 	 */
78 80
 	public function deleteFromSelf(\OCP\Share\IShare $share, $recipient);
79 81
 
@@ -181,6 +183,7 @@  discard block
 block discarded – undo
181 183
 	 * @param string $uid
182 184
 	 * @param int $shareType
183 185
 	 * @since 9.1.0
186
+	 * @return void
184 187
 	 */
185 188
 	public function userDeleted($uid, $shareType);
186 189
 
@@ -191,6 +194,7 @@  discard block
 block discarded – undo
191 194
 	 *
192 195
 	 * @param string $gid
193 196
 	 * @since 9.1.0
197
+	 * @return void
194 198
 	 */
195 199
 	public function groupDeleted($gid);
196 200
 
@@ -202,6 +206,7 @@  discard block
 block discarded – undo
202 206
 	 * @param string $uid
203 207
 	 * @param string $gid
204 208
 	 * @since 9.1.0
209
+	 * @return void
205 210
 	 */
206 211
 	public function userDeletedFromGroup($uid, $gid);
207 212
 
@@ -213,7 +218,6 @@  discard block
 block discarded – undo
213 218
 	 *
214 219
 	 * @param \OCP\Share\IShare $share
215 220
 	 * @param string $recipient userId of recipient
216
-	 * @param int $state state to set
217 221
 	 * @return \OCP\Share\IShare
218 222
 	 * @since 10.0.6
219 223
 	 */
Please login to merge, or discard this patch.
apps/files_sharing/lib/API/Share20OCS.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -537,7 +537,7 @@  discard block
 block discarded – undo
537 537
 	/**
538 538
 	 * @param \OCP\Files\File|\OCP\Files\Folder $node
539 539
 	 * @param boolean $includeTags include tags in response
540
-	 * @param int|null $stateFilter state filter or empty for all, defaults to 0 (accepted)
540
+	 * @param integer $stateFilter state filter or empty for all, defaults to 0 (accepted)
541 541
 	 * @return \OC\OCS\Result
542 542
 	 */
543 543
 	private function getSharedWithMe($node = null, $includeTags, $stateFilter = 0) {
@@ -887,6 +887,9 @@  discard block
 block discarded – undo
887 887
 		return $this->updateShareState($id, \OCP\Share::STATE_REJECTED);
888 888
 	}
889 889
 
890
+	/**
891
+	 * @param integer $id
892
+	 */
890 893
 	private function updateShareState($id, $state) {
891 894
 		if (!$this->shareManager->shareApiEnabled()) {
892 895
 			return new \OC\OCS\Result(null, 404, $this->l->t('Share API is disabled'));
@@ -992,6 +995,7 @@  discard block
 block discarded – undo
992 995
 	 * not support this we need to check all backends.
993 996
 	 *
994 997
 	 * @param string $id
998
+	 * @param string $recipient
995 999
 	 * @return \OCP\Share\IShare
996 1000
 	 * @throws ShareNotFound
997 1001
 	 */
Please login to merge, or discard this patch.
apps/files_sharing/lib/Hooks.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -114,6 +114,10 @@
 block discarded – undo
114 114
 		);
115 115
 	}
116 116
 
117
+	/**
118
+	 * @param IShare[] $shares
119
+	 * @param string $fileId
120
+	 */
117 121
 	private function filterSharesByFileId($shares, $fileId) {
118 122
 		return array_filter($shares, function(IShare $share) use ($fileId) {
119 123
 			return strval($share->getNodeId()) === strval($fileId);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use OCP\Share\IShare;
34 34
 use Symfony\Component\EventDispatcher\GenericEvent;
35 35
 use OCA\Files_Sharing\Service\NotificationPublisher;
36
-use OCP\Share\Exceptions\ShareNotFound;
37 36
 
38 37
 class Hooks {
39 38
 
Please login to merge, or discard this patch.