@@ -73,8 +73,6 @@  | 
                                                    ||
| 73 | 73 | /**  | 
                                                        
| 74 | 74 | * save the configuration value as provided  | 
                                                        
| 75 | 75 | * @param string $configID  | 
                                                        
| 76 | - * @param string $configKey  | 
                                                        |
| 77 | - * @param string $configValue  | 
                                                        |
| 78 | 76 | */  | 
                                                        
| 79 | 77 |  	protected function setValue($configID, $key, $value) { | 
                                                        
| 80 | 78 | $configHolder = new Configuration($configID);  | 
                                                        
@@ -68,7 +68,7 @@  | 
                                                    ||
| 68 | 68 | }  | 
                                                        
| 69 | 69 | |
| 70 | 70 | /**  | 
                                                        
| 71 | - * @return int  | 
                                                        |
| 71 | + * @return string  | 
                                                        |
| 72 | 72 | */  | 
                                                        
| 73 | 73 |  	static private function getRefreshInterval() { | 
                                                        
| 74 | 74 | //defaults to every hour  | 
                                                        
@@ -864,7 +864,7 @@ discard block  | 
                                                    ||
| 864 | 864 | * @param integer $filterType int, for which use case the filter shall be created  | 
                                                        
| 865 | 865 | * can be any of self::LFILTER_USER_LIST, self::LFILTER_LOGIN or  | 
                                                        
| 866 | 866 | * self::LFILTER_GROUP_LIST  | 
                                                        
| 867 | - * @return string|false string with the filter on success, false otherwise  | 
                                                        |
| 867 | + * @return string string with the filter on success, false otherwise  | 
                                                        |
| 868 | 868 | * @throws \Exception  | 
                                                        
| 869 | 869 | */  | 
                                                        
| 870 | 870 |  	private function composeLdapFilter($filterType) { | 
                                                        
@@ -1107,7 +1107,7 @@ discard block  | 
                                                    ||
| 1107 | 1107 | }  | 
                                                        
| 1108 | 1108 | |
| 1109 | 1109 | /**  | 
                                                        
| 1110 | - * @param array $reqs  | 
                                                        |
| 1110 | + * @param string[] $reqs  | 
                                                        |
| 1111 | 1111 | * @return bool  | 
                                                        
| 1112 | 1112 | */  | 
                                                        
| 1113 | 1113 |  	private function checkRequirements($reqs) { | 
                                                        
@@ -88,7 +88,7 @@  | 
                                                    ||
| 88 | 88 | * send a message to the client  | 
                                                        
| 89 | 89 | *  | 
                                                        
| 90 | 90 | * @param string $type  | 
                                                        
| 91 | - * @param mixed $data  | 
                                                        |
| 91 | + * @param string $data  | 
                                                        |
| 92 | 92 | *  | 
                                                        
| 93 | 93 | * @throws \BadMethodCallException  | 
                                                        
| 94 | 94 | * if only one parameter is given, a typeless message will be send with that parameter as data  | 
                                                        
@@ -777,7 +777,7 @@  | 
                                                    ||
| 777 | 777 | /**  | 
                                                        
| 778 | 778 | * check if path points to a files version  | 
                                                        
| 779 | 779 | *  | 
                                                        
| 780 | - * @param $path  | 
                                                        |
| 780 | + * @param string $path  | 
                                                        |
| 781 | 781 | * @return bool  | 
                                                        
| 782 | 782 | */  | 
                                                        
| 783 | 783 |  	protected function isVersion($path) { | 
                                                        
@@ -144,6 +144,9 @@  | 
                                                    ||
| 144 | 144 | return true;  | 
                                                        
| 145 | 145 | }  | 
                                                        
| 146 | 146 | |
| 147 | + /**  | 
                                                        |
| 148 | + * @param string $path  | 
                                                        |
| 149 | + */  | 
                                                        |
| 147 | 150 |  	public function url_stat($path) { | 
                                                        
| 148 | 151 |  		if (isset(self::$data[$path])) { | 
                                                        
| 149 | 152 | $size = strlen(self::$data[$path]);  | 
                                                        
@@ -197,6 +197,9 @@ discard block  | 
                                                    ||
| 197 | 197 |  		return self::linkToRoute( 'core_ajax_preview', array('x' => 32, 'y' => 32, 'file' => $path )); | 
                                                        
| 198 | 198 | }  | 
                                                        
| 199 | 199 | |
| 200 | + /**  | 
                                                        |
| 201 | + * @param string $path  | 
                                                        |
| 202 | + */  | 
                                                        |
| 200 | 203 |  	public static function publicPreviewIcon( $path, $token ) { | 
                                                        
| 201 | 204 |  		return self::linkToRoute( 'core_ajax_public_preview', array('x' => 32, 'y' => 32, 'file' => $path, 't' => $token)); | 
                                                        
| 202 | 205 | }  | 
                                                        
@@ -827,7 +830,7 @@ discard block  | 
                                                    ||
| 827 | 830 | *  | 
                                                        
| 828 | 831 | * @param string $path  | 
                                                        
| 829 | 832 | * @param \OCP\Files\FileInfo $rootInfo (optional)  | 
                                                        
| 830 | - * @return array  | 
                                                        |
| 833 | + * @return string  | 
                                                        |
| 831 | 834 | * @throws \OCP\Files\NotFoundException  | 
                                                        
| 832 | 835 | */  | 
                                                        
| 833 | 836 |  	public static function getStorageInfo($path, $rootInfo = null) { | 
                                                        
@@ -123,7 +123,7 @@ discard block  | 
                                                    ||
| 123 | 123 | * Returns expensive repair steps to be run on the  | 
                                                        
| 124 | 124 | * command line with a special option.  | 
                                                        
| 125 | 125 | *  | 
                                                        
| 126 | - * @return array of RepairStep instances  | 
                                                        |
| 126 | + * @return OldGroupMembershipShares[] of RepairStep instances  | 
                                                        |
| 127 | 127 | */  | 
                                                        
| 128 | 128 |  	public static function getExpensiveRepairSteps() { | 
                                                        
| 129 | 129 | return [  | 
                                                        
@@ -161,6 +161,8 @@ discard block  | 
                                                    ||
| 161 | 161 |  	 * {@inheritDoc} | 
                                                        
| 162 | 162 | *  | 
                                                        
| 163 | 163 | * Re-declared as public to allow invocation from within the closure above in php 5.3  | 
                                                        
| 164 | + * @param string $scope  | 
                                                        |
| 165 | + * @param string $method  | 
                                                        |
| 164 | 166 | */  | 
                                                        
| 165 | 167 |  	public function emit($scope, $method, array $arguments = array()) { | 
                                                        
| 166 | 168 | parent::emit($scope, $method, $arguments);  | 
                                                        
@@ -741,11 +741,19 @@ discard block  | 
                                                    ||
| 741 | 741 | }  | 
                                                        
| 742 | 742 | |
| 743 | 743 | // case-insensitive array_search  | 
                                                        
| 744 | +  | 
                                                        |
| 745 | + /**  | 
                                                        |
| 746 | + * @param string $needle  | 
                                                        |
| 747 | + */  | 
                                                        |
| 744 | 748 |  	protected function array_searchi($needle, $haystack, $mem='getName') { | 
                                                        
| 745 | 749 |  		if(!is_array($haystack)) { | 
                                                        
| 746 | 750 | return false;  | 
                                                        
| 747 | 751 | }  | 
                                                        
| 748 | 752 | return array_search(strtolower($needle), array_map(  | 
                                                        
| 753 | +  | 
                                                        |
| 754 | + /**  | 
                                                        |
| 755 | + * @param string $tag  | 
                                                        |
| 756 | + */  | 
                                                        |
| 749 | 757 |  			function($tag) use($mem) { | 
                                                        
| 750 | 758 | return strtolower(call_user_func(array($tag, $mem)));  | 
                                                        
| 751 | 759 | }, $haystack)  | 
                                                        
@@ -770,7 +778,7 @@ discard block  | 
                                                    ||
| 770 | 778 | * Get a tag by its name.  | 
                                                        
| 771 | 779 | *  | 
                                                        
| 772 | 780 | * @param string $name The tag name.  | 
                                                        
| 773 | - * @return integer|bool The tag object's offset within the $this->tags  | 
                                                        |
| 781 | + * @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags  | 
                                                        |
| 774 | 782 | * array or false if it doesn't exist.  | 
                                                        
| 775 | 783 | */  | 
                                                        
| 776 | 784 |  	private function getTagByName($name) { | 
                                                        
@@ -781,7 +789,7 @@ discard block  | 
                                                    ||
| 781 | 789 | * Get a tag by its ID.  | 
                                                        
| 782 | 790 | *  | 
                                                        
| 783 | 791 | * @param string $id The tag ID to look for.  | 
                                                        
| 784 | - * @return integer|bool The tag object's offset within the $this->tags  | 
                                                        |
| 792 | + * @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags  | 
                                                        |
| 785 | 793 | * array or false if it doesn't exist.  | 
                                                        
| 786 | 794 | */  | 
                                                        
| 787 | 795 |  	private function getTagById($id) { |