| @@ -98,7 +98,7 @@ | ||
| 98 | 98 | /** | 
| 99 | 99 | * get the stored metadata of a file or folder | 
| 100 | 100 | * | 
| 101 | - * @param string|int $file | |
| 101 | + * @param string $file | |
| 102 | 102 | * @return array|false | 
| 103 | 103 | */ | 
| 104 | 104 |  	public function get($file) { | 
| @@ -124,7 +124,7 @@ | ||
| 124 | 124 | * @UseSession | 
| 125 | 125 | * | 
| 126 | 126 | * Authenticates against password-protected shares | 
| 127 | - * @param $token | |
| 127 | + * @param string $token | |
| 128 | 128 | * @param string $password | 
| 129 | 129 | * @return RedirectResponse|TemplateResponse | 
| 130 | 130 | */ | 
| @@ -218,6 +218,10 @@ | ||
| 218 | 218 | |
| 219 | 219 | } | 
| 220 | 220 | |
| 221 | + /** | |
| 222 | + * @param OC\Files\FileInfo[] $content | |
| 223 | + * @param string[] $expected | |
| 224 | + */ | |
| 221 | 225 |  	public function verifyDirContent($content, $expected) { | 
| 222 | 226 |  		foreach ($content as $c) { | 
| 223 | 227 |  			if (!in_array($c['name'], $expected)) { | 
| @@ -246,8 +246,8 @@ discard block | ||
| 246 | 246 | |
| 247 | 247 | /** | 
| 248 | 248 | * verify that the array contains the expected results | 
| 249 | - * @param array $result | |
| 250 | - * @param array $expected | |
| 249 | + * @param OCP\Files\FileInfo[] $result | |
| 250 | + * @param string[] $expected | |
| 251 | 251 | */ | 
| 252 | 252 |  	private function verifyArray($result, $expected) { | 
| 253 | 253 | $this->assertSame(count($expected), count($result)); | 
| @@ -266,6 +266,11 @@ discard block | ||
| 266 | 266 | } | 
| 267 | 267 | } | 
| 268 | 268 | |
| 269 | + /** | |
| 270 | + * @param OCP\Files\FileInfo[] $files | |
| 271 | + * @param string $trashRoot | |
| 272 | + * @param integer $expireDate | |
| 273 | + */ | |
| 269 | 274 |  	private function manipulateDeleteTime($files, $trashRoot, $expireDate) { | 
| 270 | 275 | $counter = 0; | 
| 271 | 276 |  		foreach ($files as &$file) { | 
| @@ -625,7 +630,6 @@ discard block | ||
| 625 | 630 | /** | 
| 626 | 631 | * @param string $user | 
| 627 | 632 | * @param bool $create | 
| 628 | - * @param bool $password | |
| 629 | 633 | */ | 
| 630 | 634 |  	public static function loginHelper($user, $create = false) { | 
| 631 | 635 |  		if ($create) { | 
| @@ -648,11 +652,20 @@ discard block | ||
| 648 | 652 | |
| 649 | 653 | // just a dummy class to make protected methods available for testing | 
| 650 | 654 |  class TrashbinForTesting extends Files_Trashbin\Trashbin { | 
| 655 | + | |
| 656 | + /** | |
| 657 | + * @param OCP\Files\FileInfo[] $files | |
| 658 | + * @param integer $limit | |
| 659 | + */ | |
| 651 | 660 |  	public function dummyDeleteExpiredFiles($files, $limit) { | 
| 652 | 661 | // dummy value for $retention_obligation because it is not needed here | 
| 653 | 662 | return parent::deleteExpiredFiles($files, \Test_Trashbin::TEST_TRASHBIN_USER1, $limit, 0); | 
| 654 | 663 | } | 
| 655 | 664 | |
| 665 | + /** | |
| 666 | + * @param OCP\Files\FileInfo[] $files | |
| 667 | + * @param integer $availableSpace | |
| 668 | + */ | |
| 656 | 669 |  	public function dummyDeleteFiles($files, $availableSpace) { | 
| 657 | 670 | return parent::deleteFiles($files, \Test_Trashbin::TEST_TRASHBIN_USER1, $availableSpace); | 
| 658 | 671 | } | 
| @@ -73,8 +73,6 @@ | ||
| 73 | 73 | /** | 
| 74 | 74 | * save the configuration value as provided | 
| 75 | 75 | * @param string $configID | 
| 76 | - * @param string $configKey | |
| 77 | - * @param string $configValue | |
| 78 | 76 | */ | 
| 79 | 77 |  	protected function setValue($configID, $key, $value) { | 
| 80 | 78 | $configHolder = new Configuration($configID); | 
| @@ -28,7 +28,6 @@ | ||
| 28 | 28 | use Symfony\Component\Console\Command\Command; | 
| 29 | 29 | use Symfony\Component\Console\Helper\Table; | 
| 30 | 30 | use Symfony\Component\Console\Input\InputInterface; | 
| 31 | -use Symfony\Component\Console\Input\InputOption; | |
| 32 | 31 | use Symfony\Component\Console\Output\OutputInterface; | 
| 33 | 32 | |
| 34 | 33 |  class ListCertificates extends Base { | 
| @@ -68,7 +68,7 @@ | ||
| 68 | 68 | } | 
| 69 | 69 | |
| 70 | 70 | /** | 
| 71 | - * @return int | |
| 71 | + * @return string | |
| 72 | 72 | */ | 
| 73 | 73 |  	static private function getRefreshInterval() { | 
| 74 | 74 | //defaults to every hour | 
| @@ -864,7 +864,7 @@ discard block | ||
| 864 | 864 | * @param integer $filterType int, for which use case the filter shall be created | 
| 865 | 865 | * can be any of self::LFILTER_USER_LIST, self::LFILTER_LOGIN or | 
| 866 | 866 | * self::LFILTER_GROUP_LIST | 
| 867 | - * @return string|false string with the filter on success, false otherwise | |
| 867 | + * @return string string with the filter on success, false otherwise | |
| 868 | 868 | * @throws \Exception | 
| 869 | 869 | */ | 
| 870 | 870 |  	private function composeLdapFilter($filterType) { | 
| @@ -1107,7 +1107,7 @@ discard block | ||
| 1107 | 1107 | } | 
| 1108 | 1108 | |
| 1109 | 1109 | /** | 
| 1110 | - * @param array $reqs | |
| 1110 | + * @param string[] $reqs | |
| 1111 | 1111 | * @return bool | 
| 1112 | 1112 | */ | 
| 1113 | 1113 |  	private function checkRequirements($reqs) { | 
| @@ -131,7 +131,7 @@ | ||
| 131 | 131 | } | 
| 132 | 132 | |
| 133 | 133 | /** | 
| 134 | - * @param $message | |
| 134 | + * @param string $message | |
| 135 | 135 | * @param array $additional | 
| 136 | 136 | * @return array | 
| 137 | 137 | */ | 
| @@ -73,7 +73,7 @@ | ||
| 73 | 73 | * 5.2.6.5 and 5.1 will be turned into 5.2 and 5.1 | 
| 74 | 74 | * @param string $first | 
| 75 | 75 | * @param string $second | 
| 76 | - * @return array first element is the first version, second element is the | |
| 76 | + * @return string[] first element is the first version, second element is the | |
| 77 | 77 | * second version | 
| 78 | 78 | */ | 
| 79 | 79 |  	private function normalizeVersions($first, $second) { |