Completed
Pull Request — master (#26115)
by Thomas
20:20
created
apps/dav/lib/CardDAV/AddressBookImpl.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 	 * @param AddressBook $addressBook
52 52
 	 * @param array $addressBookInfo
53 53
 	 * @param CardDavBackend $backend
54
-	 * @param IUrlGenerator $urlGenerator
54
+	 * @param IURLGenerator $urlGenerator
55 55
 	 */
56 56
 	public function __construct(
57 57
 			AddressBook $addressBook,
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
 	}
135 135
 
136 136
 	/**
137
-	 * @return mixed
137
+	 * @return integer
138 138
 	 * @since 5.0.0
139 139
 	 */
140 140
 	public function getPermissions() {
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	 * read vCard data into a vCard object
173 173
 	 *
174 174
 	 * @param string $cardData
175
-	 * @return VCard
175
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
176 176
 	 */
177 177
 	protected function readCard($cardData) {
178 178
 		return  Reader::read($cardData);
Please login to merge, or discard this patch.
apps/dav/lib/CardDAV/CardDavBackend.php 1 patch
Doc Comments   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -189,7 +189,8 @@  discard block
 block discarded – undo
189 189
 	}
190 190
 
191 191
 	/**
192
-	 * @param $addressBookUri
192
+	 * @param string $addressBookUri
193
+	 * @param string $principal
193 194
 	 * @return array|null
194 195
 	 */
195 196
 	public function getAddressBooksByUri($principal, $addressBookUri) {
@@ -871,6 +872,7 @@  discard block
 block discarded – undo
871 872
 	 *   * readOnly - boolean
872 873
 	 *   * summary - Optional, a description for the share
873 874
 	 *
875
+	 * @param integer $addressBookId
874 876
 	 * @return array
875 877
 	 */
876 878
 	public function getShares($addressBookId) {
@@ -924,7 +926,7 @@  discard block
 block discarded – undo
924 926
 	 * read vCard data into a vCard object
925 927
 	 *
926 928
 	 * @param string $cardData
927
-	 * @return VCard
929
+	 * @return \Sabre\VObject\Parser\Sabre\VObject\Document|null
928 930
 	 */
929 931
 	protected function readCard($cardData) {
930 932
 		return  Reader::read($cardData);
@@ -970,7 +972,7 @@  discard block
 block discarded – undo
970 972
 
971 973
 	/**
972 974
 	 * For shared address books the sharee is set in the ACL of the address book
973
-	 * @param $addressBookId
975
+	 * @param integer $addressBookId
974 976
 	 * @param $acl
975 977
 	 * @return array
976 978
 	 */
@@ -978,6 +980,9 @@  discard block
 block discarded – undo
978 980
 		return $this->sharingBackend->applyShareAcl($addressBookId, $acl);
979 981
 	}
980 982
 
983
+	/**
984
+	 * @param boolean $toV2
985
+	 */
981 986
 	private function convertPrincipal($principalUri, $toV2) {
982 987
 		if ($this->principalBackend->getPrincipalPrefix() === 'principals') {
983 988
 			list(, $name) = URLUtil::splitPath($principalUri);
Please login to merge, or discard this patch.