Completed
Pull Request — master (#24350)
by Robin
10:03
created
apps/user_ldap/command/setconfig.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -73,8 +73,6 @@
 block discarded – undo
73 73
 	/**
74 74
 	 * save the configuration value as provided
75 75
 	 * @param string $configID
76
-	 * @param string $configKey
77
-	 * @param string $configValue
78 76
 	 */
79 77
 	protected function setValue($configID, $key, $value) {
80 78
 		$configHolder = new Configuration($configID);
Please login to merge, or discard this patch.
apps/user_ldap/lib/jobs.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
 	}
69 69
 
70 70
 	/**
71
-	 * @return int
71
+	 * @return string
72 72
 	 */
73 73
 	static private function getRefreshInterval() {
74 74
 		//defaults to every hour
Please login to merge, or discard this patch.
apps/user_ldap/lib/wizard.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -864,7 +864,7 @@  discard block
 block discarded – undo
864 864
 	 * @param integer $filterType int, for which use case the filter shall be created
865 865
 	 * can be any of self::LFILTER_USER_LIST, self::LFILTER_LOGIN or
866 866
 	 * self::LFILTER_GROUP_LIST
867
-	 * @return string|false string with the filter on success, false otherwise
867
+	 * @return string string with the filter on success, false otherwise
868 868
 	 * @throws \Exception
869 869
 	 */
870 870
 	private function composeLdapFilter($filterType) {
@@ -1107,7 +1107,7 @@  discard block
 block discarded – undo
1107 1107
 	}
1108 1108
 
1109 1109
 	/**
1110
-	 * @param array $reqs
1110
+	 * @param string[] $reqs
1111 1111
 	 * @return bool
1112 1112
 	 */
1113 1113
 	private function checkRequirements($reqs) {
Please login to merge, or discard this patch.
lib/private/eventsource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 	 * send a message to the client
89 89
 	 *
90 90
 	 * @param string $type
91
-	 * @param mixed $data
91
+	 * @param string $data
92 92
 	 *
93 93
 	 * @throws \BadMethodCallException
94 94
 	 * if only one parameter is given, a typeless message will be send with that parameter as data
Please login to merge, or discard this patch.
lib/private/helper.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -197,6 +197,9 @@  discard block
 block discarded – undo
197 197
 		return self::linkToRoute( 'core_ajax_preview', array('x' => 32, 'y' => 32, 'file' => $path ));
198 198
 	}
199 199
 
200
+	/**
201
+	 * @param string $path
202
+	 */
200 203
 	public static function publicPreviewIcon( $path, $token ) {
201 204
 		return self::linkToRoute( 'core_ajax_public_preview', array('x' => 32, 'y' => 32, 'file' => $path, 't' => $token));
202 205
 	}
@@ -827,7 +830,7 @@  discard block
 block discarded – undo
827 830
 	 *
828 831
 	 * @param string $path
829 832
 	 * @param \OCP\Files\FileInfo $rootInfo (optional)
830
-	 * @return array
833
+	 * @return string
831 834
 	 * @throws \OCP\Files\NotFoundException
832 835
 	 */
833 836
 	public static function getStorageInfo($path, $rootInfo = null) {
Please login to merge, or discard this patch.
lib/private/tags.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -741,11 +741,19 @@  discard block
 block discarded – undo
741 741
 	}
742 742
 
743 743
 	// case-insensitive array_search
744
+
745
+	/**
746
+	 * @param string $needle
747
+	 */
744 748
 	protected function array_searchi($needle, $haystack, $mem='getName') {
745 749
 		if(!is_array($haystack)) {
746 750
 			return false;
747 751
 		}
748 752
 		return array_search(strtolower($needle), array_map(
753
+
754
+			/**
755
+			 * @param string $tag
756
+			 */
749 757
 			function($tag) use($mem) {
750 758
 				return strtolower(call_user_func(array($tag, $mem)));
751 759
 			}, $haystack)
@@ -770,7 +778,7 @@  discard block
 block discarded – undo
770 778
 	* Get a tag by its name.
771 779
 	*
772 780
 	* @param string $name The tag name.
773
-	* @return integer|bool The tag object's offset within the $this->tags
781
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
774 782
 	*                      array or false if it doesn't exist.
775 783
 	*/
776 784
 	private function getTagByName($name) {
@@ -781,7 +789,7 @@  discard block
 block discarded – undo
781 789
 	* Get a tag by its ID.
782 790
 	*
783 791
 	* @param string $id The tag ID to look for.
784
-	* @return integer|bool The tag object's offset within the $this->tags
792
+	* @return \OCP\AppFramework\Db\Entity The tag object's offset within the $this->tags
785 793
 	*                      array or false if it doesn't exist.
786 794
 	*/
787 795
 	private function getTagById($id) {
Please login to merge, or discard this patch.
lib/private/user/session.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
 	/**
143 143
 	 * get the current active user
144 144
 	 *
145
-	 * @return \OCP\IUser|null Current user, otherwise null
145
+	 * @return null|User Current user, otherwise null
146 146
 	 */
147 147
 	public function getUser() {
148 148
 		// FIXME: This is a quick'n dirty work-around for the incognito mode as
Please login to merge, or discard this patch.
lib/private/util.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1434,7 +1434,7 @@
 block discarded – undo
1434 1434
 	 * Normalize a unicode string
1435 1435
 	 *
1436 1436
 	 * @param string $value a not normalized string
1437
-	 * @return bool|string
1437
+	 * @return string
1438 1438
 	 */
1439 1439
 	public static function normalizeUnicode($value) {
1440 1440
 		if(Normalizer::isNormalized($value)) {
Please login to merge, or discard this patch.
lib/public/template.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,8 +100,8 @@
 block discarded – undo
100 100
 /**
101 101
  * Return the relative date in relation to today. Returns something like "last hour" or "two month ago"
102 102
  * @param int $timestamp unix timestamp
103
- * @param boolean $dateOnly
104
- * @return \OC_L10N_String human readable interpretation of the timestamp
103
+ * @param integer $dateOnly
104
+ * @return string human readable interpretation of the timestamp
105 105
  *
106 106
  * @deprecated 8.0.0 Use \OCP\Template::relative_modified_date() instead
107 107
  */
Please login to merge, or discard this patch.