Completed
Pull Request — master (#28212)
by Tom
10:01
created
core/Command/User/SyncBackend.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 	 * @param SyncService $syncService
158 158
 	 * @param UserInterface $backend
159 159
 	 * @param string $missingAccountsAction
160
-	 * @param array $validActions
160
+	 * @param string[] $validActions
161 161
 	 */
162 162
 	private function syncMultipleUsers (
163 163
 		InputInterface $input,
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	 * @param SyncService $syncService
207 207
 	 * @param UserInterface $backend
208 208
 	 * @param string $missingAccountsAction
209
-	 * @param array $validActions
209
+	 * @param string[] $validActions
210 210
 	 */
211 211
 	private function syncSingleUser(
212 212
 		$uid,
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
 	}
252 252
 
253 253
 	/**
254
-	 * @param array $uids a list of uids to the the action
254
+	 * @param string[] $uids a list of uids to the the action
255 255
 	 * @param callable $callbackExists the callback used if the account for the uid exists. The
256 256
 	 * uid and the specific account will be passed as parameter to the callback in that order
257 257
 	 * @param callable $callbackMissing the callback used if the account doesn't exists. The uid (not
Please login to merge, or discard this patch.
core/Migrations/Version20170221114437.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,8 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace OC\Migrations;
3 3
 
4
-use OC\Migration\OutputAdapter;
5
-use OC\Migration\SimpleOutput;
6 4
 use OC\User\AccountMapper;
7 5
 use OC\User\AccountTermMapper;
8 6
 use OC\User\Database;
Please login to merge, or discard this patch.
lib/private/Repair.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@
 block discarded – undo
159 159
 	 * Returns expensive repair steps to be run on the
160 160
 	 * command line with a special option.
161 161
 	 *
162
-	 * @return IRepairStep[]
162
+	 * @return OldGroupMembershipShares[]
163 163
 	 */
164 164
 	public static function getExpensiveRepairSteps() {
165 165
 		return [
Please login to merge, or discard this patch.
lib/private/User/AccountMapper.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
 	/**
48 48
 	 * Delegate to term mapper to avoid needing to inject term mapper
49
-	 * @param $account_id
49
+	 * @param integer $account_id
50 50
 	 * @param array $terms
51 51
 	 */
52 52
 	public function setTermsForAccount($account_id, array $terms) {
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
 	/**
57 57
 	 * Delegate to term mapper to avoid needing to inject term mapper
58
-	 * @param $account_id
58
+	 * @param integer $account_id
59 59
 	 * @return AccountTerm[] $terms
60 60
 	 */
61 61
 	public function findByAccountId($account_id) {
@@ -176,6 +176,9 @@  discard block
 block discarded – undo
176 176
 		return $this->findEntities($qb->getSQL(), $qb->getParameters(), $limit, $offset);
177 177
 	}
178 178
 
179
+	/**
180
+	 * @param boolean $hasLoggedIn
181
+	 */
179 182
 	public function getUserCountPerBackend($hasLoggedIn) {
180 183
 		$qb = $this->db->getQueryBuilder();
181 184
 		$qb->select(['backend', $qb->createFunction('count(*) as `count`')])
@@ -218,6 +221,11 @@  discard block
 block discarded – undo
218 221
 		return (int) $data['count'];
219 222
 	}
220 223
 
224
+	/**
225
+	 * @param \Closure $callback
226
+	 * @param string $search
227
+	 * @param boolean $onlySeen
228
+	 */
221 229
 	public function callForAllUsers($callback, $search, $onlySeen) {
222 230
 		$qb = $this->db->getQueryBuilder();
223 231
 		$qb->select(['*'])
Please login to merge, or discard this patch.
lib/private/User/SyncServiceCallback.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
 
22 22
 namespace OC\User;
23 23
 
24
-use OCP\Migration\IOutput;
24
+use OCP\Migration\IOutput;
25 25
 use OCP\Util;
26 26
 
27 27
 class SyncServiceCallback {
Please login to merge, or discard this patch.