Completed
Pull Request — master (#25260)
by Christoph
19:18
created
lib/private/User/Session.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 	 * @param IRequest $request
301 301
 	 * @throws LoginException
302 302
 	 * @throws PasswordLoginForbiddenException
303
-	 * @return boolean
303
+	 * @return boolean|null
304 304
 	 */
305 305
 	public function logClientIn($user, $password, IRequest $request) {
306 306
 		$isTokenPassword = $this->isTokenPassword($password);
@@ -340,6 +340,9 @@  discard block
 block discarded – undo
340 340
 		return $this->config->getSystemValue('token_auth_enforced', false);
341 341
 	}
342 342
 
343
+	/**
344
+	 * @param string $username
345
+	 */
343 346
 	protected function isTwoFactorEnforced($username) {
344 347
 		Util::emitHook(
345 348
 			'\OCA\Files_Sharing\API\Server2Server',
@@ -414,6 +417,10 @@  discard block
 block discarded – undo
414 417
 		return false;
415 418
 	}
416 419
 
420
+	/**
421
+	 * @param string $uid
422
+	 * @param string $password
423
+	 */
417 424
 	private function loginWithPassword($uid, $password) {
418 425
 		$this->manager->emit('\OC\User', 'preLogin', array($uid, $password));
419 426
 		$user = $this->manager->checkPassword($uid, $password);
@@ -442,6 +449,9 @@  discard block
 block discarded – undo
442 449
 		return false;
443 450
 	}
444 451
 
452
+	/**
453
+	 * @param string $token
454
+	 */
445 455
 	private function loginWithToken($token) {
446 456
 		try {
447 457
 			$dbToken = $this->tokenProvider->getToken($token);
Please login to merge, or discard this patch.